[jira] [Commented] (OFBIZ-4528) Out of stock products screw up the pagination during category browsing

["Mridul Pathak (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175930#comment-14175930 ] 

Mridul Pathak commented on OFBIZ-4528:
--------------------------------------

I reviewed the patch and have couple suggestions,
1. filterOutOfStockProducts() method should be moved to ProductWorker.java and made public.
2. In the method calls there is additional white space before opening bracket.

> Out of stock products screw up the pagination during category browsing
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-4528
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4528
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order, specialpurpose/ecommerce
>    Affects Versions: Release Branch 11.04, Trunk
>            Reporter: Kiran Gawde
>            Assignee: Ashish Vijaywargiya
>         Attachments: OFBIZ-4528.patch
>
>
> Pagination is handled in getProductCategoryAndLimitedMembers
> Then the out of stock filtering is done in CategoryDetail.groovy.
> Hence the pagination is screwed up. Certain pages might show less records or no records based upon data condition.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)