You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Denis Cabasson (JIRA)" <ji...@codehaus.org> on 2007/07/03 16:57:13 UTC
[jira] Created: (MECLIPSE-292) Behaviour for sources and Javadoc
attachement for dependencies should be consistent
Behaviour for sources and Javadoc attachement for dependencies should be consistent
-----------------------------------------------------------------------------------
Key: MECLIPSE-292
URL: http://jira.codehaus.org/browse/MECLIPSE-292
Project: Maven 2.x Eclipse Plugin
Issue Type: Improvement
Components: dependency resolution
Affects Versions: 2.4
Environment: Windows XP, Maven 2.0.6, maven-eclipse-plugin 2.4-20070628.215652-24
Reporter: Denis Cabasson
Priority: Minor
Fix For: 2.4
Why couldn't we have a consistent behaviour for javadoc and sources jar attachment?
Why not adding a downloadJavadoc property, which, when set to true, would download and attach the javadoc to the dependency.
I don't really see why javadoc should be a fallback if sources are not available.
Some developpers might prefer to have javadoc linked, some sources linked and some both. Shouldn't the eclipse plugin allow for all the possiblities instead of stating that the preferred option is always to get the sources instead of the Javadoc?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MECLIPSE-292) Behaviour for sources and Javadoc
attachement for dependencies should be consistent
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox closed MECLIPSE-292.
------------------------------
Resolution: Fixed
Fix Version/s: 2.4
Eclipse doesn't support variables in the javadoc classpath and having absolute references breaks the unit tests for now.
> Behaviour for sources and Javadoc attachement for dependencies should be consistent
> -----------------------------------------------------------------------------------
>
> Key: MECLIPSE-292
> URL: http://jira.codehaus.org/browse/MECLIPSE-292
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Improvement
> Components: dependency resolution
> Affects Versions: 2.4
> Environment: Windows XP, Maven 2.0.6, maven-eclipse-plugin 2.4-20070628.215652-24
> Reporter: Denis Cabasson
> Assignee: Brian Fox
> Priority: Minor
> Fix For: 2.4
>
> Attachments: MECLIPSE-292-updated.patch, MECLIPSE-292.patch
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Why couldn't we have a consistent behaviour for javadoc and sources jar attachment?
> Why not adding a downloadJavadoc property, which, when set to true, would download and attach the javadoc to the dependency.
> I don't really see why javadoc should be a fallback if sources are not available.
> Some developpers might prefer to have javadoc linked, some sources linked and some both. Shouldn't the eclipse plugin allow for all the possiblities instead of stating that the preferred option is always to get the sources instead of the Javadoc?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-292) Behaviour for sources and Javadoc
attachement for dependencies should be consistent
Posted by "Tony Falabella (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_111528 ]
Tony Falabella commented on MECLIPSE-292:
-----------------------------------------
I have the following configuration:
Windows XP
maven 2.0.7 (not sure if the plugin uses it's own or not so this might not be needed)
org.maven.ide.eclipse_0.0.11.20070916-2300
org.maven.ide.eclipse.feature_0.0.11.20070916-2300
eclipse 3.3
As of 2007-10-26, this still appears to be an issue. It is as the other bug [http://jira.codehaus.org/browse/MECLIPSE-143] describes. If you have both "Download Artifact Sources" and "Download Artifact JavaDocs" options checked, if sources are found for a library it doesn't even look for JavaDocs.
As a test I created a repository that has both the xxx-javadoc.jar and xxx-sources.jar. I've turned DEBUG logging on. If I have both "Download Artifact Sources" and "Download Artifact JavaDocs" options checked I never see anything in the log for it attempting to even look for the xxx-javadoc.jar . Thus no xxx-javadoc.jar ends up in the localrepos. It does properly find the xxx-sources.jar and that then appears in the localrepos. If I remove the dependency, clear out the localrepos, and only check the "Download Artifact JavaDocs" option and try again, I see the following in the log:
{noformat}
10/26/07 9:06:28 AM EDT: [DEBUG] Trying repository tonylocal2
10/26/07 9:06:28 AM EDT: [DEBUG] SHA1 not found, trying MD5 File: C:\Documents and Settings\af25830\.m2\futures-source-repository2\org\acegisecurity\acegi-security\1.0.3\acegi-security-1.0.3-javadoc.jar.sha1 does not exist
10/26/07 9:06:28 AM EDT: [WARN] *** CHECKSUM FAILED - Error retrieving checksum file for org/acegisecurity/acegi-security/1.0.3/acegi-security-1.0.3-javadoc.jar - IGNORING
10/26/07 9:06:28 AM EDT: [DEBUG] Artifact resolved
10/26/07 9:06:28 AM EDT: Scanned javadoc C:/Documents and Settings/af25830/.m2/localrepository/org/acegisecurity/acegi-security/1.0.3/acegi-security-1.0.3-javadoc.jar 0.0
{noformat}
In this case it does properly find the xxx-javadocs.jar and they then appear in the localrepos and are properly associated as javadocs with the jar in Eclipse.
I agree though, it should not be an "either-or" in regards to downloading source or javadocs.
> Behaviour for sources and Javadoc attachement for dependencies should be consistent
> -----------------------------------------------------------------------------------
>
> Key: MECLIPSE-292
> URL: http://jira.codehaus.org/browse/MECLIPSE-292
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Improvement
> Components: dependency resolution
> Affects Versions: 2.4
> Environment: Windows XP, Maven 2.0.6, maven-eclipse-plugin 2.4-20070628.215652-24
> Reporter: Denis Cabasson
> Assignee: Brian Fox
> Priority: Minor
> Fix For: 2.5
>
> Attachments: MECLIPSE-292-fixbug.patch, MECLIPSE-292-updated.patch, MECLIPSE-292.patch
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Why couldn't we have a consistent behaviour for javadoc and sources jar attachment?
> Why not adding a downloadJavadoc property, which, when set to true, would download and attach the javadoc to the dependency.
> I don't really see why javadoc should be a fallback if sources are not available.
> Some developpers might prefer to have javadoc linked, some sources linked and some both. Shouldn't the eclipse plugin allow for all the possiblities instead of stating that the preferred option is always to get the sources instead of the Javadoc?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-292) Behaviour for sources and Javadoc
attachement for dependencies should be consistent
Posted by "Denis Cabasson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Denis Cabasson updated MECLIPSE-292:
------------------------------------
Attachment: MECLIPSE-292-fixbug.patch
Parenthesis was wrongly placed.
Submitted patch should get the caching mecanism up and working.
> Behaviour for sources and Javadoc attachement for dependencies should be consistent
> -----------------------------------------------------------------------------------
>
> Key: MECLIPSE-292
> URL: http://jira.codehaus.org/browse/MECLIPSE-292
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Improvement
> Components: dependency resolution
> Affects Versions: 2.4
> Environment: Windows XP, Maven 2.0.6, maven-eclipse-plugin 2.4-20070628.215652-24
> Reporter: Denis Cabasson
> Assignee: Brian Fox
> Priority: Minor
> Fix For: 2.4
>
> Attachments: MECLIPSE-292-fixbug.patch, MECLIPSE-292-updated.patch, MECLIPSE-292.patch
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Why couldn't we have a consistent behaviour for javadoc and sources jar attachment?
> Why not adding a downloadJavadoc property, which, when set to true, would download and attach the javadoc to the dependency.
> I don't really see why javadoc should be a fallback if sources are not available.
> Some developpers might prefer to have javadoc linked, some sources linked and some both. Shouldn't the eclipse plugin allow for all the possiblities instead of stating that the preferred option is always to get the sources instead of the Javadoc?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-292) Behaviour for sources and Javadoc
attachement for dependencies should be consistent
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MECLIPSE-292:
-------------------------------
Attachment: MECLIPSE-292-updated.patch
Updated patch. We just need some tests and doc updates.
> Behaviour for sources and Javadoc attachement for dependencies should be consistent
> -----------------------------------------------------------------------------------
>
> Key: MECLIPSE-292
> URL: http://jira.codehaus.org/browse/MECLIPSE-292
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Improvement
> Components: dependency resolution
> Affects Versions: 2.4
> Environment: Windows XP, Maven 2.0.6, maven-eclipse-plugin 2.4-20070628.215652-24
> Reporter: Denis Cabasson
> Assignee: Brian Fox
> Priority: Minor
> Attachments: MECLIPSE-292-updated.patch, MECLIPSE-292.patch
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Why couldn't we have a consistent behaviour for javadoc and sources jar attachment?
> Why not adding a downloadJavadoc property, which, when set to true, would download and attach the javadoc to the dependency.
> I don't really see why javadoc should be a fallback if sources are not available.
> Some developpers might prefer to have javadoc linked, some sources linked and some both. Shouldn't the eclipse plugin allow for all the possiblities instead of stating that the preferred option is always to get the sources instead of the Javadoc?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-292) Behaviour for sources and Javadoc
attachement for dependencies should be consistent
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MECLIPSE-292:
-------------------------------
Fix Version/s: (was: 2.4)
> Behaviour for sources and Javadoc attachement for dependencies should be consistent
> -----------------------------------------------------------------------------------
>
> Key: MECLIPSE-292
> URL: http://jira.codehaus.org/browse/MECLIPSE-292
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Improvement
> Components: dependency resolution
> Affects Versions: 2.4
> Environment: Windows XP, Maven 2.0.6, maven-eclipse-plugin 2.4-20070628.215652-24
> Reporter: Denis Cabasson
> Priority: Minor
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Why couldn't we have a consistent behaviour for javadoc and sources jar attachment?
> Why not adding a downloadJavadoc property, which, when set to true, would download and attach the javadoc to the dependency.
> I don't really see why javadoc should be a fallback if sources are not available.
> Some developpers might prefer to have javadoc linked, some sources linked and some both. Shouldn't the eclipse plugin allow for all the possiblities instead of stating that the preferred option is always to get the sources instead of the Javadoc?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work started: (MECLIPSE-292) Behaviour for sources and
Javadoc attachement for dependencies should be consistent
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on MECLIPSE-292 started by Brian Fox.
> Behaviour for sources and Javadoc attachement for dependencies should be consistent
> -----------------------------------------------------------------------------------
>
> Key: MECLIPSE-292
> URL: http://jira.codehaus.org/browse/MECLIPSE-292
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Improvement
> Components: dependency resolution
> Affects Versions: 2.4
> Environment: Windows XP, Maven 2.0.6, maven-eclipse-plugin 2.4-20070628.215652-24
> Reporter: Denis Cabasson
> Assignee: Brian Fox
> Priority: Minor
> Fix For: 2.4
>
> Attachments: MECLIPSE-292-fixbug.patch, MECLIPSE-292-updated.patch, MECLIPSE-292.patch
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Why couldn't we have a consistent behaviour for javadoc and sources jar attachment?
> Why not adding a downloadJavadoc property, which, when set to true, would download and attach the javadoc to the dependency.
> I don't really see why javadoc should be a fallback if sources are not available.
> Some developpers might prefer to have javadoc linked, some sources linked and some both. Shouldn't the eclipse plugin allow for all the possiblities instead of stating that the preferred option is always to get the sources instead of the Javadoc?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-292) Behaviour for sources and Javadoc
attachement for dependencies should be consistent
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101584 ]
Brian Fox commented on MECLIPSE-292:
------------------------------------
tested by hand and works. The classpath file has absolute references to the javadoc jar, it should use M2_REPO like the rest.
> Behaviour for sources and Javadoc attachement for dependencies should be consistent
> -----------------------------------------------------------------------------------
>
> Key: MECLIPSE-292
> URL: http://jira.codehaus.org/browse/MECLIPSE-292
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Improvement
> Components: dependency resolution
> Affects Versions: 2.4
> Environment: Windows XP, Maven 2.0.6, maven-eclipse-plugin 2.4-20070628.215652-24
> Reporter: Denis Cabasson
> Assignee: Brian Fox
> Priority: Minor
> Attachments: MECLIPSE-292-updated.patch, MECLIPSE-292.patch
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Why couldn't we have a consistent behaviour for javadoc and sources jar attachment?
> Why not adding a downloadJavadoc property, which, when set to true, would download and attach the javadoc to the dependency.
> I don't really see why javadoc should be a fallback if sources are not available.
> Some developpers might prefer to have javadoc linked, some sources linked and some both. Shouldn't the eclipse plugin allow for all the possiblities instead of stating that the preferred option is always to get the sources instead of the Javadoc?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-292) Behaviour for sources and Javadoc
attachement for dependencies should be consistent
Posted by "Denis Cabasson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Denis Cabasson updated MECLIPSE-292:
------------------------------------
Attachment: MECLIPSE-292.patch
Proposed patch. Add a downloadJavadoc attribute, working the same way as downloadSources.
There is nothing to be done in the classpath writer as all the code there is already able to handle source and javadoc.
We just need to resolve javadoc jar, even when source jar is available.
Some refactoring done (on this part).
> Behaviour for sources and Javadoc attachement for dependencies should be consistent
> -----------------------------------------------------------------------------------
>
> Key: MECLIPSE-292
> URL: http://jira.codehaus.org/browse/MECLIPSE-292
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Improvement
> Components: dependency resolution
> Affects Versions: 2.4
> Environment: Windows XP, Maven 2.0.6, maven-eclipse-plugin 2.4-20070628.215652-24
> Reporter: Denis Cabasson
> Priority: Minor
> Attachments: MECLIPSE-292.patch
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Why couldn't we have a consistent behaviour for javadoc and sources jar attachment?
> Why not adding a downloadJavadoc property, which, when set to true, would download and attach the javadoc to the dependency.
> I don't really see why javadoc should be a fallback if sources are not available.
> Some developpers might prefer to have javadoc linked, some sources linked and some both. Shouldn't the eclipse plugin allow for all the possiblities instead of stating that the preferred option is always to get the sources instead of the Javadoc?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (MECLIPSE-292) Behaviour for sources and Javadoc
attachement for dependencies should be consistent
Posted by "Denis Cabasson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Denis Cabasson reopened MECLIPSE-292:
-------------------------------------
@Brian : Your updated version of the patch seems to have broken the caching mecanism.
> Behaviour for sources and Javadoc attachement for dependencies should be consistent
> -----------------------------------------------------------------------------------
>
> Key: MECLIPSE-292
> URL: http://jira.codehaus.org/browse/MECLIPSE-292
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Improvement
> Components: dependency resolution
> Affects Versions: 2.4
> Environment: Windows XP, Maven 2.0.6, maven-eclipse-plugin 2.4-20070628.215652-24
> Reporter: Denis Cabasson
> Assignee: Brian Fox
> Priority: Minor
> Fix For: 2.4
>
> Attachments: MECLIPSE-292-updated.patch, MECLIPSE-292.patch
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Why couldn't we have a consistent behaviour for javadoc and sources jar attachment?
> Why not adding a downloadJavadoc property, which, when set to true, would download and attach the javadoc to the dependency.
> I don't really see why javadoc should be a fallback if sources are not available.
> Some developpers might prefer to have javadoc linked, some sources linked and some both. Shouldn't the eclipse plugin allow for all the possiblities instead of stating that the preferred option is always to get the sources instead of the Javadoc?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MECLIPSE-292) Behaviour for sources and Javadoc
attachement for dependencies should be consistent
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox closed MECLIPSE-292.
------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.4)
2.5
> Behaviour for sources and Javadoc attachement for dependencies should be consistent
> -----------------------------------------------------------------------------------
>
> Key: MECLIPSE-292
> URL: http://jira.codehaus.org/browse/MECLIPSE-292
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Improvement
> Components: dependency resolution
> Affects Versions: 2.4
> Environment: Windows XP, Maven 2.0.6, maven-eclipse-plugin 2.4-20070628.215652-24
> Reporter: Denis Cabasson
> Assignee: Brian Fox
> Priority: Minor
> Fix For: 2.5
>
> Attachments: MECLIPSE-292-fixbug.patch, MECLIPSE-292-updated.patch, MECLIPSE-292.patch
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Why couldn't we have a consistent behaviour for javadoc and sources jar attachment?
> Why not adding a downloadJavadoc property, which, when set to true, would download and attach the javadoc to the dependency.
> I don't really see why javadoc should be a fallback if sources are not available.
> Some developpers might prefer to have javadoc linked, some sources linked and some both. Shouldn't the eclipse plugin allow for all the possiblities instead of stating that the preferred option is always to get the sources instead of the Javadoc?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira