You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/01 11:54:18 UTC
[GitHub] [airflow] ashb commented on a change in pull request #5507:
[AIRFLOW-4871] Allow creating DagRuns via RBAC UI
ashb commented on a change in pull request #5507: [AIRFLOW-4871] Allow creating DagRuns via RBAC UI
URL: https://github.com/apache/airflow/pull/5507#discussion_r299006946
##########
File path: tests/www/test_views.py
##########
@@ -85,10 +85,11 @@ def login(self):
def logout(self):
return self.client.get('/logout/')
- def clear_table(self, model):
- self.session.query(model).delete()
- self.session.commit()
- self.session.close()
+ @classmethod
+ def clear_table(cls, model):
+ cls.session.query(model).delete()
Review comment:
I guess since we're closing the session anyway that makes sense here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services