[jira] [Commented] (PARQUET-1973) Support ZSTD JNI BufferPool

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299831#comment-17299831 ] 

ASF GitHub Bot commented on PARQUET-1973:
-----------------------------------------

shangxinli commented on a change in pull request #865:
URL: https://github.com/apache/parquet-mr/pull/865#discussion_r592678142



##########
File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/codec/ZstandardCodec.java
##########
@@ -91,7 +102,14 @@ public CompressionOutputStream createOutputStream(OutputStream stream, Compresso
 
   @Override
   public CompressionOutputStream createOutputStream(OutputStream stream) throws IOException {
-    return new ZstdCompressorStream(stream, conf.getInt(PARQUET_COMPRESS_ZSTD_LEVEL, DEFAULT_PARQUET_COMPRESS_ZSTD_LEVEL),
+    BufferPool pool;

Review comment:
       Thanks Dongjoon for working on this! 
   
   It is kind of late. Just a minor comment: if you can wrap the code into a method and call it in both CompressionInputStream() and CompressionOutputStream, it would avoid duplicating. Not a big deal though. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support ZSTD JNI BufferPool
> ---------------------------
>
>                 Key: PARQUET-1973
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1973
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-mr
>    Affects Versions: 1.12.0
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>            Priority: Major
>             Fix For: 1.12.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)