You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/23 06:28:40 UTC

[GitHub] [doris] morningman opened a new pull request, #10359: [chore] Rename Doris binary output format

morningman opened a new pull request, #10359:
URL: https://github.com/apache/doris/pull/10359

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   As we discuss in thread: https://lists.apache.org/thread/b1cm011rqdqhbrn4h1qjlh1b3j2tqhjk
   This CL mainly changes:
   1. Change the BE binary file from `palo_be` to `doris_be`
       For compatibility, there will be a soft link `palo_be` link to `doris_be`, so that some supervisor program can still work with `palo_be` name.
   2. Change the FE binary file from `palo-fe.jar` to `doris-fe.jar`
   3. Change some names in document.
   4. Not build meta_tools by default, to save some compile time.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes, somehow)
   5. Has unit tests been added: (No Need)
   6. Has document been added or modified: (Yes)
   7. Does it need to update dependencies: (No)
   8. Are there any changes that cannot be rolled back: (No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei commented on pull request #10359: [chore] Rename Doris binary output format

Posted by GitBox <gi...@apache.org>.
yiguolei commented on PR #10359:
URL: https://github.com/apache/doris/pull/10359#issuecomment-1165287510

   > 
   
   Maybe could not, because start_fe.sh depend on PaloFe...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #10359: [chore] Rename Doris binary output format

Posted by GitBox <gi...@apache.org>.
morningman commented on PR #10359:
URL: https://github.com/apache/doris/pull/10359#issuecomment-1166303719

   > Shall we modify the file `fe/fe-core/src/main/java/org/apache/doris/PaloFe.java`?
   
   This change is try to minimize the impact of the origin behavior.
   So you can see I add a soft link for BE binary for compatibility.
   But is not easy to do that for FE, because we can not add soft link for a jar file or class name.
   
   Maybe we could change PaloFe's later, but not this time.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #10359: [chore] Rename Doris binary output format

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10359:
URL: https://github.com/apache/doris/pull/10359#issuecomment-1165286354

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #10359: [chore] Rename Doris binary output format

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10359:
URL: https://github.com/apache/doris/pull/10359#issuecomment-1165286410

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] adonis0147 commented on pull request #10359: [chore] Rename Doris binary output format

Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #10359:
URL: https://github.com/apache/doris/pull/10359#issuecomment-1165136996

   Shall we modify the file `fe/fe-core/src/main/java/org/apache/doris/PaloFe.java`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei merged pull request #10359: [chore] Rename Doris binary output format

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10359:
URL: https://github.com/apache/doris/pull/10359


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org