You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/03/21 00:51:28 UTC

Review Request 32349: Removed http::put and added a TODO.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32349/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

This was not used in the code. I've added a TODO to avoid proliferating functions and parameters here by taking a 'Request' object. Cody has a patch here as well but doesn't have the time to work on it atm: https://reviews.apache.org/r/28254/


Diffs
-----

  3rdparty/libprocess/include/process/http.hpp 2b366986b1f617e95bda94e07f2a0e532f5626f6 
  3rdparty/libprocess/src/http.cpp 276cecd17364989093e6eed8e97ff3a02fb0d0ef 

Diff: https://reviews.apache.org/r/32349/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request 32349: Removed http::put and added a TODO.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32349/#review77646
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On March 20, 2015, 11:51 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32349/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 11:51 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This was not used in the code. I've added a TODO to avoid proliferating functions and parameters here by taking a 'Request' object. Cody has a patch here as well but doesn't have the time to work on it atm: https://reviews.apache.org/r/28254/
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 2b366986b1f617e95bda94e07f2a0e532f5626f6 
>   3rdparty/libprocess/src/http.cpp 276cecd17364989093e6eed8e97ff3a02fb0d0ef 
> 
> Diff: https://reviews.apache.org/r/32349/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>