You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Andrei Shakirin (Created) (JIRA)" <ji...@apache.org> on 2012/04/19 10:27:43 UTC

[jira] [Created] (CXF-4248) DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response

DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response
-------------------------------------------------------------------------------

                 Key: CXF-4248
                 URL: https://issues.apache.org/jira/browse/CXF-4248
             Project: CXF
          Issue Type: Improvement
            Reporter: Andrei Shakirin
            Priority: Minor
         Attachments: HTTPConduit.patch

Hi,

Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
Expected: response will be ignored
Actual: DocLiteralInInterceptor throws NPE
Caused by: java.lang.NullPointerException
        at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
        at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
        at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
        at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
        at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
        at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
        at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
rInterceptor.java:62)

Fix proposal: I have discovered that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
In addition to this, the use of some protocol extensions (e.g.
WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.

I would propose to process oneWay response only in following cases:
A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on consumer

In other case oneWay response will be ignored by client.

Patch is attached.

Regards,
Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4248) DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response

Posted by "Andrei Shakirin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264558#comment-13264558 ] 

Andrei Shakirin commented on CXF-4248:
--------------------------------------

Hi Dan,

Agree, proposed way is more elegant, because RMMessageConstants is not really fit for API package. 
Improved patch is attached.

Andrei.
                
> DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response
> -------------------------------------------------------------------------------
>
>                 Key: CXF-4248
>                 URL: https://issues.apache.org/jira/browse/CXF-4248
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andrei Shakirin
>            Priority: Minor
>         Attachments: HTTPConduit.patch, OneWayResponseProcessing.patch
>
>
> Hi,
> Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
> Expected: response will be ignored
> Actual: DocLiteralInInterceptor throws NPE
> Caused by: java.lang.NullPointerException
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
>         at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
>         at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
>         at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
>         at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
>         at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
> rInterceptor.java:62)
> Fix proposal: I have discovered (thanks Aki!) that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
> R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
> One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
> In addition to this, the use of some protocol extensions (e.g.
> WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.
> I would propose to process successful oneWay responses only in following cases:
> A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
> B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on client.
> In other case oneWay response will be ignored by client.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-4248) DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response

Posted by "Andrei Shakirin (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Shakirin updated CXF-4248:
---------------------------------

    Description: 
Hi,

Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
Expected: response will be ignored
Actual: DocLiteralInInterceptor throws NPE
Caused by: java.lang.NullPointerException
        at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
        at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
        at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
        at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
        at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
        at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
        at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
rInterceptor.java:62)

Fix proposal: I have discovered that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
In addition to this, the use of some protocol extensions (e.g.
WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.

I would propose to process successful oneWay responses only in following cases:
A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on client.

In other case oneWay response will be ignored by client.

Patch is attached.

Regards,
Andrei.

  was:
Hi,

Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
Expected: response will be ignored
Actual: DocLiteralInInterceptor throws NPE
Caused by: java.lang.NullPointerException
        at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
        at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
        at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
        at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
        at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
        at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
        at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
rInterceptor.java:62)

Fix proposal: I have discovered that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
In addition to this, the use of some protocol extensions (e.g.
WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.

I would propose to process successful oneWay responses only in following cases:
A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on consumer

In other case oneWay response will be ignored by client.

Patch is attached.

Regards,
Andrei.

    
> DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response
> -------------------------------------------------------------------------------
>
>                 Key: CXF-4248
>                 URL: https://issues.apache.org/jira/browse/CXF-4248
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andrei Shakirin
>            Priority: Minor
>         Attachments: HTTPConduit.patch
>
>
> Hi,
> Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
> Expected: response will be ignored
> Actual: DocLiteralInInterceptor throws NPE
> Caused by: java.lang.NullPointerException
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
>         at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
>         at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
>         at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
>         at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
>         at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
> rInterceptor.java:62)
> Fix proposal: I have discovered that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
> R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
> One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
> In addition to this, the use of some protocol extensions (e.g.
> WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.
> I would propose to process successful oneWay responses only in following cases:
> A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
> B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on client.
> In other case oneWay response will be ignored by client.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-4248) DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response

Posted by "Andrei Shakirin (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Shakirin updated CXF-4248:
---------------------------------

    Description: 
Hi,

Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
Expected: response will be ignored
Actual: DocLiteralInInterceptor throws NPE
Caused by: java.lang.NullPointerException
        at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
        at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
        at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
        at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
        at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
        at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
        at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
rInterceptor.java:62)

Fix proposal: I have discovered that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
In addition to this, the use of some protocol extensions (e.g.
WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.

I would propose to process successful oneWay responses only in following cases:
A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on consumer

In other case oneWay response will be ignored by client.

Patch is attached.

Regards,
Andrei.

  was:
Hi,

Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
Expected: response will be ignored
Actual: DocLiteralInInterceptor throws NPE
Caused by: java.lang.NullPointerException
        at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
        at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
        at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
        at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
        at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
        at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
        at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
rInterceptor.java:62)

Fix proposal: I have discovered that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
In addition to this, the use of some protocol extensions (e.g.
WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.

I would propose to process oneWay response only in following cases:
A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on consumer

In other case oneWay response will be ignored by client.

Patch is attached.

Regards,
Andrei.

    
> DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response
> -------------------------------------------------------------------------------
>
>                 Key: CXF-4248
>                 URL: https://issues.apache.org/jira/browse/CXF-4248
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andrei Shakirin
>            Priority: Minor
>         Attachments: HTTPConduit.patch
>
>
> Hi,
> Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
> Expected: response will be ignored
> Actual: DocLiteralInInterceptor throws NPE
> Caused by: java.lang.NullPointerException
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
>         at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
>         at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
>         at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
>         at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
>         at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
> rInterceptor.java:62)
> Fix proposal: I have discovered that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
> R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
> One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
> In addition to this, the use of some protocol extensions (e.g.
> WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.
> I would propose to process successful oneWay responses only in following cases:
> A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
> B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on consumer
> In other case oneWay response will be ignored by client.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CXF-4248) DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response

Posted by "Aki Yoshida (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aki Yoshida resolved CXF-4248.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.4.8
                   2.5.4
                   2.6.1

Andrei's second patch set applied.

                
> DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response
> -------------------------------------------------------------------------------
>
>                 Key: CXF-4248
>                 URL: https://issues.apache.org/jira/browse/CXF-4248
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andrei Shakirin
>            Assignee: Aki Yoshida
>            Priority: Minor
>             Fix For: 2.6.1, 2.5.4, 2.4.8
>
>         Attachments: HTTPConduit.patch, OneWayResponseProcessing-fixed.patch, OneWayResponseProcessing.patch
>
>
> Hi,
> Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
> Expected: response will be ignored
> Actual: DocLiteralInInterceptor throws NPE
> Caused by: java.lang.NullPointerException
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
>         at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
>         at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
>         at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
>         at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
>         at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
> rInterceptor.java:62)
> Fix proposal: I have discovered (thanks Aki!) that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
> R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
> One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
> In addition to this, the use of some protocol extensions (e.g.
> WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.
> I would propose to process successful oneWay responses only in following cases:
> A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
> B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on client.
> In other case oneWay response will be ignored by client.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-4248) DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response

Posted by "Andrei Shakirin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Shakirin updated CXF-4248:
---------------------------------

    Attachment: OneWayResponseProcessing.patch
    
> DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response
> -------------------------------------------------------------------------------
>
>                 Key: CXF-4248
>                 URL: https://issues.apache.org/jira/browse/CXF-4248
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andrei Shakirin
>            Priority: Minor
>         Attachments: HTTPConduit.patch, OneWayResponseProcessing.patch
>
>
> Hi,
> Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
> Expected: response will be ignored
> Actual: DocLiteralInInterceptor throws NPE
> Caused by: java.lang.NullPointerException
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
>         at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
>         at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
>         at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
>         at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
>         at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
> rInterceptor.java:62)
> Fix proposal: I have discovered (thanks Aki!) that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
> R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
> One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
> In addition to this, the use of some protocol extensions (e.g.
> WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.
> I would propose to process successful oneWay responses only in following cases:
> A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
> B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on client.
> In other case oneWay response will be ignored by client.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-4248) DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response

Posted by "Andrei Shakirin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Shakirin updated CXF-4248:
---------------------------------

    Attachment: OneWayResponseProcessing-fixed.patch
    
> DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response
> -------------------------------------------------------------------------------
>
>                 Key: CXF-4248
>                 URL: https://issues.apache.org/jira/browse/CXF-4248
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andrei Shakirin
>            Priority: Minor
>         Attachments: HTTPConduit.patch, OneWayResponseProcessing-fixed.patch, OneWayResponseProcessing.patch
>
>
> Hi,
> Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
> Expected: response will be ignored
> Actual: DocLiteralInInterceptor throws NPE
> Caused by: java.lang.NullPointerException
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
>         at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
>         at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
>         at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
>         at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
>         at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
> rInterceptor.java:62)
> Fix proposal: I have discovered (thanks Aki!) that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
> R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
> One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
> In addition to this, the use of some protocol extensions (e.g.
> WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.
> I would propose to process successful oneWay responses only in following cases:
> A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
> B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on client.
> In other case oneWay response will be ignored by client.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-4248) DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response

Posted by "Andrei Shakirin (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Shakirin updated CXF-4248:
---------------------------------

    Description: 
Hi,

Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
Expected: response will be ignored
Actual: DocLiteralInInterceptor throws NPE
Caused by: java.lang.NullPointerException
        at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
        at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
        at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
        at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
        at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
        at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
        at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
rInterceptor.java:62)

Fix proposal: I have discovered (thanks Aki!) that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
In addition to this, the use of some protocol extensions (e.g.
WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.

I would propose to process successful oneWay responses only in following cases:
A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on client.

In other case oneWay response will be ignored by client.

Patch is attached.

Regards,
Andrei.

  was:
Hi,

Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
Expected: response will be ignored
Actual: DocLiteralInInterceptor throws NPE
Caused by: java.lang.NullPointerException
        at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
        at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
        at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
        at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
        at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
        at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
        at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
        at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
rInterceptor.java:62)

Fix proposal: I have discovered that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
In addition to this, the use of some protocol extensions (e.g.
WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.

I would propose to process successful oneWay responses only in following cases:
A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on client.

In other case oneWay response will be ignored by client.

Patch is attached.

Regards,
Andrei.

    
> DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response
> -------------------------------------------------------------------------------
>
>                 Key: CXF-4248
>                 URL: https://issues.apache.org/jira/browse/CXF-4248
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andrei Shakirin
>            Priority: Minor
>         Attachments: HTTPConduit.patch
>
>
> Hi,
> Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
> Expected: response will be ignored
> Actual: DocLiteralInInterceptor throws NPE
> Caused by: java.lang.NullPointerException
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
>         at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
>         at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
>         at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
>         at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
>         at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
> rInterceptor.java:62)
> Fix proposal: I have discovered (thanks Aki!) that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
> R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
> One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
> In addition to this, the use of some protocol extensions (e.g.
> WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.
> I would propose to process successful oneWay responses only in following cases:
> A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
> B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on client.
> In other case oneWay response will be ignored by client.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (CXF-4248) DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response

Posted by "Aki Yoshida (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aki Yoshida reassigned CXF-4248:
--------------------------------

    Assignee: Aki Yoshida
    
> DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response
> -------------------------------------------------------------------------------
>
>                 Key: CXF-4248
>                 URL: https://issues.apache.org/jira/browse/CXF-4248
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andrei Shakirin
>            Assignee: Aki Yoshida
>            Priority: Minor
>         Attachments: HTTPConduit.patch, OneWayResponseProcessing-fixed.patch, OneWayResponseProcessing.patch
>
>
> Hi,
> Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
> Expected: response will be ignored
> Actual: DocLiteralInInterceptor throws NPE
> Caused by: java.lang.NullPointerException
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
>         at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
>         at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
>         at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
>         at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
>         at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
> rInterceptor.java:62)
> Fix proposal: I have discovered (thanks Aki!) that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
> R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
> One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
> In addition to this, the use of some protocol extensions (e.g.
> WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.
> I would propose to process successful oneWay responses only in following cases:
> A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
> B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on client.
> In other case oneWay response will be ignored by client.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-4248) DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response

Posted by "Andrei Shakirin (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Shakirin updated CXF-4248:
---------------------------------

    Attachment: HTTPConduit.patch
    
> DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response
> -------------------------------------------------------------------------------
>
>                 Key: CXF-4248
>                 URL: https://issues.apache.org/jira/browse/CXF-4248
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andrei Shakirin
>            Priority: Minor
>         Attachments: HTTPConduit.patch
>
>
> Hi,
> Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
> Expected: response will be ignored
> Actual: DocLiteralInInterceptor throws NPE
> Caused by: java.lang.NullPointerException
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
>         at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
>         at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
>         at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
>         at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
>         at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
> rInterceptor.java:62)
> Fix proposal: I have discovered that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
> R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
> One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
> In addition to this, the use of some protocol extensions (e.g.
> WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.
> I would propose to process oneWay response only in following cases:
> A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
> B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on consumer
> In other case oneWay response will be ignored by client.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4248) DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262035#comment-13262035 ] 

Daniel Kulp commented on CXF-4248:
----------------------------------

Patch would create a split-package issue between cxf-api and cxf-rt-ws-rm which would be a really bad thing. 

My suggestion would be to add a single property (your PROCESS_ONEWAY_REPONSE) to Message.java and have the HTTPConduit look for that.   That WS-RM interceptors should SET that property on the message or exchange as part of the work they do.


                
> DocLiteralInInterceptor throws NPE if oneWay operation sends non-empty response
> -------------------------------------------------------------------------------
>
>                 Key: CXF-4248
>                 URL: https://issues.apache.org/jira/browse/CXF-4248
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andrei Shakirin
>            Priority: Minor
>         Attachments: HTTPConduit.patch
>
>
> Hi,
> Test case: Web service provides oneWay operation (SoapUI mock), but sends non-empty SOAP response back
> Expected: response will be ignored
> Actual: DocLiteralInInterceptor throws NPE
> Caused by: java.lang.NullPointerException
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.shouldWrapParameters(DocLiteralInInterceptor.java:292)
>         at org.apache.cxf.interceptor.DocLiteralInInterceptor.handleMessage(DocLiteralInInterceptor.java:103)
>         at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:263)
>         at org.apache.cxf.endpoint.ClientImpl.onMessage(ClientImpl.java:799)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1627)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1494)
>         at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1402)
>         at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
>         at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:649)
>         at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSende
> rInterceptor.java:62)
> Fix proposal: I have discovered (thanks Aki!) that there are some cases when oneWay response can be proceeded. Regarding Basic Profile 1.1: 
> R2714 For one-way operations, an HTTP Response MESSAGE MAY contain an envelope.
> One-way operations typically do not produce SOAP responses. However, some INSTANCEs may choose to communicate infrastructure-related faults (e.g. MustUnderstand, VersionMismatch) in the HTTP Response message.
> In addition to this, the use of some protocol extensions (e.g.
> WS-ReliableMessaging) may create the possibility for non-empty responses to one-way messages. For these reasons the Basic Profile 1.1 requirement that the HTTP Response message not contain a SOAP envelope has been relaxed.
> I would propose to process successful oneWay responses only in following cases:
> A) if RM is active (check RMMessageConstants.RM_PROPERTIES_OUTBOUND, RMMessageConstants.RM_PROPERTIES_INBOUND)
> B) if user activate it with org.apache.cxf.transport.processOneWayResponse property on client.
> In other case oneWay response will be ignored by client.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira