You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Olivier Lafontaine (JIRA)" <ji...@apache.org> on 2016/01/26 19:05:39 UTC
[jira] [Updated] (HTTPCLIENT-1715) NTLMEngineImpl.Type1Message not
thread safe but declared as a constant
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lafontaine updated HTTPCLIENT-1715:
-------------------------------------------
Summary: NTLMEngineImpl.Type1Message not thread safe but declared as a constant (was: NTLMEngineImpl.Type1Message not thread safe but declared as a singleton)
> NTLMEngineImpl.Type1Message not thread safe but declared as a constant
> ----------------------------------------------------------------------
>
> Key: HTTPCLIENT-1715
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1715
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.5.1
> Reporter: Olivier Lafontaine
>
> {{NTLMEngineImpl}} declares a {{static final}} member named {{TYPE_1_MESSAGE}} of type {{Type1Message}}. Members of {{Type1Message}} are final and do not change, but that is not the case for members of its superclass {{NTLMMessage}}.
> Whenever the method {{NTLMEngineImpl#getType1Message(String, String)}} is called, the method {{NTLMMessage#getResponse()}} get called on the {{TYPE_1_MESSAGE}} instance and this modifies the following members of {{NTLMMessage}}:
> * messageContents
> * currentOutputPosition
> This is not thread safe and we get exceptions as seen in HTTPCLIENT-1686.
> My guess is that the computed response string should be kept in a constant instead of a {{Type1Message}} instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org