[GitHub] [hive] aturoczy commented on a diff in pull request #4447: HIVE-27460: HiveMetastoreClient should not wrap TTransportException in MetaException

["aturoczy (via GitHub)" <gi...@apache.org>]

aturoczy commented on code in PR #4447:
URL: https://github.com/apache/hive/pull/4447#discussion_r1256329973


##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:
##########
@@ -569,9 +553,16 @@ private void open() throws MetaException {
                   + "Continuing without it.", e);
             }
           }
+        } catch (TTransportException e) {
+          tte = e;
+          if (LOG.isDebugEnabled()) {

Review Comment:
   I know it is a copy but I think we should not have ... in the end of the message



##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:
##########
@@ -569,9 +553,16 @@ private void open() throws MetaException {
                   + "Continuing without it.", e);
             }
           }
+        } catch (TTransportException e) {
+          tte = e;
+          if (LOG.isDebugEnabled()) {
+            LOG.warn("Failed to connect to the MetaStore Server...", e);

Review Comment:
   If the isDebugEnabled should not be Log.debug() instead of Log.Warn? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org