You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/11/22 09:40:20 UTC
Review Request 15778: Drop messages from non-leading Masters in the
scheduler driver.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15778/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-832
https://issues.apache.org/jira/browse/MESOS-832
Repository: mesos-git
Description
-------
See MESOS-832 for additional context.
Diffs
-----
src/sched/sched.cpp 51f95bb6a0825b5bf7df917405b7788112a347d9
src/tests/fault_tolerance_tests.cpp 6cb5829119ed3e855740fb9331e4fb19c16d3629
Diff: https://reviews.apache.org/r/15778/diff/
Testing
-------
Added a test and ran it with 20,000 iterations.
Thanks,
Ben Mahler
Re: Review Request 15778: Drop messages from non-leading Masters in the
scheduler driver.
Posted by Ben Mahler <be...@gmail.com>.
> On Nov. 23, 2013, 12:34 a.m., Vinod Kone wrote:
> > src/sched/sched.cpp, line 676
> > <https://reviews.apache.org/r/15778/diff/1/?file=389852#file389852line676>
> >
> > why no changes here?
Framework messages are sent by the slave.
> On Nov. 23, 2013, 12:34 a.m., Vinod Kone wrote:
> > src/sched/sched.cpp, line 698
> > <https://reviews.apache.org/r/15778/diff/1/?file=389852#file389852line698>
> >
> > Can you add a comment here on why you are doing the master check here?
>
> Vinod Kone wrote:
> s/doing/not doing/
The master sends error messages during framework failover to terminate the old scheduler driver.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15778/#review29321
-----------------------------------------------------------
On Nov. 22, 2013, 8:40 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15778/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2013, 8:40 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-832
> https://issues.apache.org/jira/browse/MESOS-832
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See MESOS-832 for additional context.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 51f95bb6a0825b5bf7df917405b7788112a347d9
> src/tests/fault_tolerance_tests.cpp 6cb5829119ed3e855740fb9331e4fb19c16d3629
>
> Diff: https://reviews.apache.org/r/15778/diff/
>
>
> Testing
> -------
>
> Added a test and ran it with 20,000 iterations.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 15778: Drop messages from non-leading Masters in the
scheduler driver.
Posted by Vinod Kone <vi...@gmail.com>.
> On Nov. 23, 2013, 12:34 a.m., Vinod Kone wrote:
> > src/sched/sched.cpp, line 698
> > <https://reviews.apache.org/r/15778/diff/1/?file=389852#file389852line698>
> >
> > Can you add a comment here on why you are doing the master check here?
s/doing/not doing/
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15778/#review29321
-----------------------------------------------------------
On Nov. 22, 2013, 8:40 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15778/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2013, 8:40 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-832
> https://issues.apache.org/jira/browse/MESOS-832
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See MESOS-832 for additional context.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 51f95bb6a0825b5bf7df917405b7788112a347d9
> src/tests/fault_tolerance_tests.cpp 6cb5829119ed3e855740fb9331e4fb19c16d3629
>
> Diff: https://reviews.apache.org/r/15778/diff/
>
>
> Testing
> -------
>
> Added a test and ran it with 20,000 iterations.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 15778: Drop messages from non-leading Masters in the
scheduler driver.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15778/#review29321
-----------------------------------------------------------
src/sched/sched.cpp
<https://reviews.apache.org/r/15778/#comment56490>
s/leader/leading master/
or
s/leader/registered master/
?
src/sched/sched.cpp
<https://reviews.apache.org/r/15778/#comment56491>
Can you add a comment on why you need the if check. I presume this is because the driver itself can generate updates.
src/sched/sched.cpp
<https://reviews.apache.org/r/15778/#comment56492>
why no changes here?
src/sched/sched.cpp
<https://reviews.apache.org/r/15778/#comment56493>
Can you add a comment here on why you are doing the master check here?
src/tests/fault_tolerance_tests.cpp
<https://reviews.apache.org/r/15778/#comment56494>
new line.
src/tests/fault_tolerance_tests.cpp
<https://reviews.apache.org/r/15778/#comment56507>
Can you mention in the comment that you are spoofing the sender to be a random master? Also, mention that this should be dropped by the driver.
src/tests/fault_tolerance_tests.cpp
<https://reviews.apache.org/r/15778/#comment56508>
Is this possible?
- Vinod Kone
On Nov. 22, 2013, 8:40 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15778/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2013, 8:40 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-832
> https://issues.apache.org/jira/browse/MESOS-832
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See MESOS-832 for additional context.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 51f95bb6a0825b5bf7df917405b7788112a347d9
> src/tests/fault_tolerance_tests.cpp 6cb5829119ed3e855740fb9331e4fb19c16d3629
>
> Diff: https://reviews.apache.org/r/15778/diff/
>
>
> Testing
> -------
>
> Added a test and ran it with 20,000 iterations.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 15778: Drop messages from non-leading Masters in the
scheduler driver.
Posted by Ben Mahler <be...@gmail.com>.
> On Nov. 25, 2013, 10:26 p.m., Vinod Kone wrote:
> > src/tests/fault_tolerance_tests.cpp, line 1833
> > <https://reviews.apache.org/r/15778/diff/1-2/?file=389853#file389853line1833>
> >
> > s/,/;,/ ?
fixed
> On Nov. 25, 2013, 10:26 p.m., Vinod Kone wrote:
> > src/tests/fault_tolerance_tests.cpp, line 1835
> > <https://reviews.apache.org/r/15778/diff/1-2/?file=389853#file389853line1835>
> >
> > s/onto//
thanks!
> On Nov. 25, 2013, 10:26 p.m., Vinod Kone wrote:
> > src/sched/sched.cpp, line 378
> > <https://reviews.apache.org/r/15778/diff/1-2/?file=389852#file389852line378>
> >
> > s/leading/registered/ is probably more applicable? sorry, i missed it the last time. but i will leave it up to you.
I see, hmm the wording is a bit tricky with "registered" since we'd want to say "the master we're registered with" as opposed to the "registered master", so I'll leave as leading.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15778/#review29400
-----------------------------------------------------------
On Nov. 23, 2013, 1:09 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15778/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2013, 1:09 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-832
> https://issues.apache.org/jira/browse/MESOS-832
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See MESOS-832 for additional context.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 51f95bb6a0825b5bf7df917405b7788112a347d9
> src/tests/fault_tolerance_tests.cpp 6cb5829119ed3e855740fb9331e4fb19c16d3629
>
> Diff: https://reviews.apache.org/r/15778/diff/
>
>
> Testing
> -------
>
> Added a test and ran it with 20,000 iterations.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 15778: Drop messages from non-leading Masters in the
scheduler driver.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15778/#review29400
-----------------------------------------------------------
Ship it!
src/sched/sched.cpp
<https://reviews.apache.org/r/15778/#comment56627>
s/leading/registered/ is probably more applicable? sorry, i missed it the last time. but i will leave it up to you.
src/tests/fault_tolerance_tests.cpp
<https://reviews.apache.org/r/15778/#comment56625>
s/,/;,/ ?
src/tests/fault_tolerance_tests.cpp
<https://reviews.apache.org/r/15778/#comment56626>
s/onto//
- Vinod Kone
On Nov. 23, 2013, 1:09 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15778/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2013, 1:09 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-832
> https://issues.apache.org/jira/browse/MESOS-832
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See MESOS-832 for additional context.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 51f95bb6a0825b5bf7df917405b7788112a347d9
> src/tests/fault_tolerance_tests.cpp 6cb5829119ed3e855740fb9331e4fb19c16d3629
>
> Diff: https://reviews.apache.org/r/15778/diff/
>
>
> Testing
> -------
>
> Added a test and ran it with 20,000 iterations.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 15778: Drop messages from non-leading Masters in the
scheduler driver.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15778/
-----------------------------------------------------------
(Updated Nov. 25, 2013, 10:57 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Vinod's review.
Bugs: MESOS-832
https://issues.apache.org/jira/browse/MESOS-832
Repository: mesos-git
Description
-------
See MESOS-832 for additional context.
Diffs (updated)
-----
src/sched/sched.cpp 51f95bb6a0825b5bf7df917405b7788112a347d9
src/tests/fault_tolerance_tests.cpp 6cb5829119ed3e855740fb9331e4fb19c16d3629
Diff: https://reviews.apache.org/r/15778/diff/
Testing
-------
Added a test and ran it with 20,000 iterations.
Thanks,
Ben Mahler
Re: Review Request 15778: Drop messages from non-leading Masters in the
scheduler driver.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15778/
-----------------------------------------------------------
(Updated Nov. 23, 2013, 1:09 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Vinod's review.
Bugs: MESOS-832
https://issues.apache.org/jira/browse/MESOS-832
Repository: mesos-git
Description
-------
See MESOS-832 for additional context.
Diffs (updated)
-----
src/sched/sched.cpp 51f95bb6a0825b5bf7df917405b7788112a347d9
src/tests/fault_tolerance_tests.cpp 6cb5829119ed3e855740fb9331e4fb19c16d3629
Diff: https://reviews.apache.org/r/15778/diff/
Testing
-------
Added a test and ran it with 20,000 iterations.
Thanks,
Ben Mahler