[GitHub] [incubator-pegasus] hycdong commented on a diff in pull request #1104: refactor(java-client): add more detail message for error log

[GitBox <gi...@apache.org>]

hycdong commented on code in PR #1104:
URL: https://github.com/apache/incubator-pegasus/pull/1104#discussion_r951050454


##########
java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:
##########
@@ -1672,14 +1731,18 @@ public int batchDel2(List<Pair<byte[], byte[]>> keys, List<PException> results,
   @Override
   public void multiDel(byte[] hashKey, List<byte[]> sortKeys, int timeout) throws PException {
     if (timeout <= 0) timeout = defaultTimeout;
-    int count = sortKeys == null ? 0 : sortKeys.size();
+    int count = sortKeys == null ? -1 : sortKeys.size();

Review Comment:
   Why would you update count from 0 into -1 when sortKeys is null?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org