You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@apache.org> on 2026/07/09 12:56:31 UTC

Re: svn commit: r1935776 - in subversion/trunk: . .github/workflows build subversion/libsvn_subr/utf8proc subversion/tests/cmdline subversion/tests/cmdline/svntest

On 1. 7. 2026 17:51, ivan@apache.org wrote:
> Author: ivan
> Date: Wed Jul  1 15:51:12 2026
> New Revision: 1935776
[...]
> Modified: subversion/trunk/Makefile.in
> ==============================================================================
> --- subversion/trunk/Makefile.in	Wed Jul  1 15:26:27 2026	(r1935775)
> +++ subversion/trunk/Makefile.in	Wed Jul  1 15:51:12 2026	(r1935776)
> @@ -642,9 +642,6 @@ check: bin @TRANSFORM_LIBTOOL_SCRIPTS@ $
>   	  if test "$(SVN_BIN_DIR)" != ""; then                               \
>   	    flags="--bin $(SVN_BIN_DIR) $$flags";                            \
>   	  fi;                                                                \
> -	  if test "$(PYTHON_VENV)" != ""; then                               \
> -	    flags="--python-venv $(PYTHON_VENV) $$flags";                    \
> -	  fi;                                                                \
>   	  if test "$(STORE_PRISTINE)" != ""; then                            \
>   	    flags="--store-pristine $(STORE_PRISTINE) $$flags";              \
>   	  fi;                                                                \
> @@ -654,6 +651,9 @@ check: bin @TRANSFORM_LIBTOOL_SCRIPTS@ $
>   	  if test "$(VALGRIND_OPTS)" != ""; then                             \
>   	    flags="--valgrind-opts $(VALGRIND_OPTS) $$flags";                \
>   	  fi;                                                                \
> +	  if test "$(CHECK_XML_SCHEMA)" != ""; then             \
> +	    flags="--check-xml-schema $$flags";                 \
> +	  fi;                                                                \
>   	  LD_LIBRARY_PATH='$(auth_plugin_dirs):$(LD_LIBRARY_PATH)'           \
>   	  $(PYTHON) $(top_srcdir)/build/run_tests.py                         \
>   	            --config-file $(top_srcdir)/subversion/tests/tests.conf  \

Tiny nitpick: formatting breaks alignment of line continuation escapes.


-- Brane

Re: svn commit: r1935776 - in subversion/trunk: . .github/workflows build subversion/libsvn_subr/utf8proc subversion/tests/cmdline subversion/tests/cmdline/svntest

Posted by Ivan Zhakov <iv...@apache.org>.
On Thu, 9 Jul 2026 at 15:57, Branko Čibej <br...@apache.org> wrote:

> On 1. 7. 2026 17:51, ivan@apache.org wrote:
>
> Author: ivan
> Date: Wed Jul  1 15:51:12 2026
> New Revision: 1935776
>
> [...]
>
> Modified: subversion/trunk/Makefile.in
> ==============================================================================
> --- subversion/trunk/Makefile.in	Wed Jul  1 15:26:27 2026	(r1935775)
> +++ subversion/trunk/Makefile.in	Wed Jul  1 15:51:12 2026	(r1935776)
> @@ -642,9 +642,6 @@ check: bin @TRANSFORM_LIBTOOL_SCRIPTS@ $
>  	  if test "$(SVN_BIN_DIR)" != ""; then                               \
>  	    flags="--bin $(SVN_BIN_DIR) $$flags";                            \
>  	  fi;                                                                \
> -	  if test "$(PYTHON_VENV)" != ""; then                               \
> -	    flags="--python-venv $(PYTHON_VENV) $$flags";                    \
> -	  fi;                                                                \
>  	  if test "$(STORE_PRISTINE)" != ""; then                            \
>  	    flags="--store-pristine $(STORE_PRISTINE) $$flags";              \
>  	  fi;                                                                \
> @@ -654,6 +651,9 @@ check: bin @TRANSFORM_LIBTOOL_SCRIPTS@ $
>  	  if test "$(VALGRIND_OPTS)" != ""; then                             \
>  	    flags="--valgrind-opts $(VALGRIND_OPTS) $$flags";                \
>  	  fi;                                                                \
> +	  if test "$(CHECK_XML_SCHEMA)" != ""; then             \
> +	    flags="--check-xml-schema $$flags";                 \
> +	  fi;                                                                \
>  	  LD_LIBRARY_PATH='$(auth_plugin_dirs):$(LD_LIBRARY_PATH)'           \
>  	  $(PYTHON) $(top_srcdir)/build/run_tests.py                         \
>  	            --config-file $(top_srcdir)/subversion/tests/tests.conf  \
>
>
> Tiny nitpick: formatting breaks alignment of line continuation escapes.
>
>
> Oops. Fixed in r1936024.

Thanks!

-- 
Ivan Zhakov