You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2017/12/08 21:53:11 UTC
Review Request 64465: Added a test for non-quota role reservation
allocation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64465/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Michael Park.
Repository: mesos
Description
-------
This test checks against the symptom of failing to allocate
non-quota role’s reservations if resources are set aside for
the quota limit headroom. See MESOS-8293.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 862f4683da04d37d9fe9f471d6ec9cd7751f39ec
Diff: https://reviews.apache.org/r/64465/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 64465: Added a test for non-quota role reservation
allocation.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64465/#review194003
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/hierarchical_allocator_tests.cpp
Lines 1466-1497 (patched)
<https://reviews.apache.org/r/64465/#comment272698>
Can we combine these into a single path?
- Benjamin Mahler
On Dec. 8, 2017, 10:16 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64465/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 10:16 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Michael Park.
>
>
> Bugs: MESOS-8293
> https://issues.apache.org/jira/browse/MESOS-8293
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test checks against the symptom of failing to allocate
> non-quota role's reservations if resources are set aside for
> the quota limit headroom. See MESOS-8293.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp f5fb47ed09682ebdd047aec7e79a86597ee09f53
>
>
> Diff: https://reviews.apache.org/r/64465/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 64465: Added a test for non-quota role reservation
allocation.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64465/
-----------------------------------------------------------
(Updated Dec. 8, 2017, 2:16 p.m.)
Review request for mesos, Benjamin Mahler and Michael Park.
Repository: mesos
Description
-------
This test checks against the symptom of failing to allocate
non-quota role’s reservations if resources are set aside for
the quota limit headroom. See MESOS-8293.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 862f4683da04d37d9fe9f471d6ec9cd7751f39ec
Diff: https://reviews.apache.org/r/64465/diff/2/
Changes: https://reviews.apache.org/r/64465/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 64465: Added a test for non-quota role reservation
allocation.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64465/
-----------------------------------------------------------
(Updated Dec. 8, 2017, 1:54 p.m.)
Review request for mesos, Benjamin Mahler and Michael Park.
Repository: mesos
Description
-------
This test checks against the symptom of failing to allocate
non-quota role’s reservations if resources are set aside for
the quota limit headroom. See MESOS-8293.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 862f4683da04d37d9fe9f471d6ec9cd7751f39ec
Diff: https://reviews.apache.org/r/64465/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu