[GitHub] [felix-dev] cziegeler commented on a diff in pull request #170: [FELIX-6554] Fixed concurrent access to the internal maps

[GitBox <gi...@apache.org>]

cziegeler commented on code in PR #170:
URL: https://github.com/apache/felix-dev/pull/170#discussion_r938778902


##########
configurator/src/main/java/org/apache/felix/configurator/impl/model/State.java:
##########
@@ -39,9 +39,8 @@ public class State extends AbstractState implements Serializable {
 
     public static final String FILE_NAME = "state.ser";
 
-    private Map<Long, Long> bundlesLastModified = new HashMap<>();
-
-    private Map<Long, Long> bundlesConfigAdminBundleId = new HashMap<>();
+    private Map<Long, Long> bundlesLastModified = new ConcurrentHashMap<>();

Review Comment:
   Its used for versioning of the serialized format, it makes it easier to make any change to this class in future versions. It might be a little bit overkill here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org