[GitHub] [calcite] cshuo commented on a change in pull request #1729: [CALCITE-3715] Add an interface to pass the table hints to RelOptTable

[GitBox <gi...@apache.org>]

cshuo commented on a change in pull request #1729: [CALCITE-3715] Add an interface to pass the table hints to RelOptTable
URL: https://github.com/apache/calcite/pull/1729#discussion_r364057758
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/RelOptTable.java
 ##########
 @@ -150,5 +151,29 @@ RelRoot expandView(RelDataType rowType, String queryString,
    * expression. */
   interface ToRelContext extends ViewExpander {
     RelOptCluster getCluster();
+
+    /**
+     * Returns the table hints of the table to convert,
+     * usually you can use the hints to pass along some dynamic params.
 
 Review comment:
   `params` -> `properties` better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services