You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/06 12:08:52 UTC

[GitHub] [arrow] wesm commented on a change in pull request #7108: PARQUET-1857: [C++] Do not fail to read unencrypted files with over 32767 row groups. Change some DCHECKs causing segfaults to throw exceptions

wesm commented on a change in pull request #7108:
URL: https://github.com/apache/arrow/pull/7108#discussion_r420739547



##########
File path: cpp/src/parquet/arrow/reader_internal.h
##########
@@ -76,7 +76,8 @@ class FileColumnIterator {
       return nullptr;
     }
 
-    auto row_group_reader = reader_->RowGroup(row_groups_.front());
+    int row_group_index = row_groups_.front();
+    auto row_group_reader = reader_->RowGroup(row_group_index);

Review comment:
       Without this change I was unable to determine at which row group index the failure occurred in the debugger. I can revert it but it seems useful to be able to know 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org