[commit request] (TRINIDAD-2449) warning logged for bad icons is internal - not required for customers

["Anand V. Nath" <an...@oracle.com>]

Hello Dev,

Can someone review and commit the patch?

Thanks
Anand
On 2/6/2014 11:10 AM, Anand V Nath (JIRA) wrote:
>       [ https://issues.apache.org/jira/browse/TRINIDAD-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Anand V Nath updated TRINIDAD-2449:
> -----------------------------------
>
>      Status: Patch Available  (was: Open)
>
>> warning logged for bad icons is internal - not required for customers
>> ---------------------------------------------------------------------
>>
>>                  Key: TRINIDAD-2449
>>                  URL: https://issues.apache.org/jira/browse/TRINIDAD-2449
>>              Project: MyFaces Trinidad
>>           Issue Type: Bug
>>           Components: Skinning
>>     Affects Versions: 2.1.0-core
>>             Reporter: Anand V Nath
>>             Priority: Trivial
>>          Attachments: jira-2449.patch
>>
>>
>> Skinning framework has a convention for defining IconStyles. Styles ending with '-icon' (or contains '-icon:' for handling psuedo classes) or alias ending with 'Icon:alias' are considered as IconStyles. The basic requirement for an IconStyle is that it should have a 'content'. However skin framework does not enforce this. For backward compatibility reasons and because the styles were already public, we allow users to use styles defined in the IconStyle format as normal styles. But we log a warning for those IconStyles that do not have a 'content':
>> WARNING: The skin selector af|treeTable::expanded-icon is not a Skin Icon Object since it does not have a content attribute. If you created this selector, please rename it to end with "style" instead of "icon" so that the Skinning Framework will treat it as a style, not an icon.
>> The warning for bad IconStyles is mainly for internal styles and not required for external customers. We can log this as an INFO instead of WARNING.
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.1.5#6160)