You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/11 01:56:05 UTC

[GitHub] [shardingsphere] zzs52 opened a new pull request #12984: Update ConnectionTransactionTest.java

zzs52 opened a new pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984


   Fixes #12899
   
   Changes proposed in this pull request:
   -Test cases added for ConnectionTransaction
   -
   -
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] zzs52 commented on a change in pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
zzs52 commented on a change in pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#discussion_r726112775



##########
File path: shardingsphere-kernel/shardingsphere-transaction/shardingsphere-transaction-core/src/test/java/org/apache/shardingsphere/transaction/ConnectionTransactionTest.java
##########
@@ -22,33 +22,58 @@
 import org.apache.shardingsphere.transaction.config.TransactionRuleConfiguration;
 import org.apache.shardingsphere.transaction.context.TransactionContexts;
 import org.apache.shardingsphere.transaction.rule.TransactionRule;
-import org.junit.Before;
+
 import org.junit.Test;
 
 import java.util.Collections;
 import java.util.Map;
 
-import static org.hamcrest.CoreMatchers.is;
-import static org.junit.Assert.assertThat;
+import static org.hamcrest.CoreMatchers.equalTo;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.*;

Review comment:
       Ok,thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-1001896430


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#12984](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d17929) into [master](https://codecov.io/gh/apache/shardingsphere/commit/4951c4c83147ff2b18b49f2834e51d5dda7382c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4951c4c) will **decrease** coverage by `3.84%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/12984/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #12984      +/-   ##
   ============================================
   - Coverage     63.43%   59.58%   -3.85%     
   - Complexity     1372     1794     +422     
   ============================================
     Files          2502     2961     +459     
     Lines         37553    43904    +6351     
     Branches       6458     7444     +986     
   ============================================
   + Hits          23822    26161    +2339     
   - Misses        11846    15713    +3867     
   - Partials       1885     2030     +145     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...resql/constant/PostgreSQLMessageSeverityLevel.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9jb25zdGFudC9Qb3N0Z3JlU1FMTWVzc2FnZVNldmVyaXR5TGV2ZWwuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ml/swapper/ShadowRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cveWFtbC9zd2FwcGVyL1NoYWRvd1J1bGVDb25maWd1cmF0aW9uWWFtbFN3YXBwZXIuamF2YQ==) | `16.12% <0.00%> (-77.42%)` | :arrow_down: |
   | [...or/statement/impl/SQL92TCLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL3N0YXRlbWVudC9pbXBsL1NRTDkyVENMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...alect/handler/ddl/CreateTableStatementHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9oYW5kbGVyL2RkbC9DcmVhdGVUYWJsZVN0YXRlbWVudEhhbmRsZXIuamF2YQ==) | `38.46% <0.00%> (-61.54%)` | :arrow_down: |
   | [...hecker/AbstractShadowRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvY2hlY2tlci9BYnN0cmFjdFNoYWRvd1J1bGVDb25maWd1cmF0aW9uQ2hlY2tlci5qYXZh) | `57.50% <0.00%> (-42.50%)` | :arrow_down: |
   | [...ardingSphereAlgorithmConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9zd2FwcGVyL2FsZ29yaXRobS9TaGFyZGluZ1NwaGVyZUFsZ29yaXRobUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `60.00% <0.00%> (-40.00%)` | :arrow_down: |
   | [...ropShardingBroadcastTableRulesStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yZGwvZHJvcC9pbXBsL0Ryb3BTaGFyZGluZ0Jyb2FkY2FzdFRhYmxlUnVsZXNTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `60.00% <0.00%> (-40.00%)` | :arrow_down: |
   | [...rdingsphere/infra/route/engine/SQLRouteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3JvdXRlL2VuZ2luZS9TUUxSb3V0ZUVuZ2luZS5qYXZh) | `33.33% <0.00%> (-33.34%)` | :arrow_down: |
   | [...ardingsphere/transaction/core/TransactionType.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYW5zYWN0aW9uL2NvcmUvVHJhbnNhY3Rpb25UeXBlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | [...t/sqlserver/ddl/SQLServerCreateTableStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvc3Fsc2VydmVyL2RkbC9TUUxTZXJ2ZXJDcmVhdGVUYWJsZVN0YXRlbWVudC5qYXZh) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [1584 more](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4951c4c...3d17929](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] zzs52 commented on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
zzs52 commented on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-940822291


   > Please fix CI
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] zzs52 commented on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
zzs52 commented on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-942837555


   > Hi, the CI still failed
   
   Ok,I made another modification.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] menghaoranss commented on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-1001974100


   @zzs52 there's no files changed 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] zzs52 commented on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
zzs52 commented on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-940823690


   > Please fix CI
   
   ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] zzs52 closed pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
zzs52 closed pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-940624817


   Please fix CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] zzs52 removed a comment on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
zzs52 removed a comment on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-940822291


   > Please fix CI
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-945056493


   Hey guys, how is it going?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu merged pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-939755735


   Welcome here @zzs52 , could you look at conflicting files?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on a change in pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#discussion_r726061479



##########
File path: shardingsphere-kernel/shardingsphere-transaction/shardingsphere-transaction-core/src/test/java/org/apache/shardingsphere/transaction/ConnectionTransactionTest.java
##########
@@ -22,33 +22,58 @@
 import org.apache.shardingsphere.transaction.config.TransactionRuleConfiguration;
 import org.apache.shardingsphere.transaction.context.TransactionContexts;
 import org.apache.shardingsphere.transaction.rule.TransactionRule;
-import org.junit.Before;
+
 import org.junit.Test;
 
 import java.util.Collections;
 import java.util.Map;
 
-import static org.hamcrest.CoreMatchers.is;
-import static org.junit.Assert.assertThat;
+import static org.hamcrest.CoreMatchers.equalTo;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.*;

Review comment:
       Please do not use import *




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#discussion_r726065730



##########
File path: shardingsphere-kernel/shardingsphere-transaction/shardingsphere-transaction-core/src/test/java/org/apache/shardingsphere/transaction/ConnectionTransactionTest.java
##########
@@ -22,33 +22,58 @@
 import org.apache.shardingsphere.transaction.config.TransactionRuleConfiguration;
 import org.apache.shardingsphere.transaction.context.TransactionContexts;
 import org.apache.shardingsphere.transaction.rule.TransactionRule;
-import org.junit.Before;
+
 import org.junit.Test;
 
 import java.util.Collections;
 import java.util.Map;
 
-import static org.hamcrest.CoreMatchers.is;
-import static org.junit.Assert.assertThat;
+import static org.hamcrest.CoreMatchers.equalTo;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.*;

Review comment:
       https://blog.csdn.net/xinyuezitang/article/details/89708781




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-942420703


   Hi, the CI still failed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] menghaoranss commented on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-1001518120


   
   @zzs52 please fix the requested changes and ci errors ASAP to ensure that your commits will be merged into the upcoming release
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] zzs52 commented on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
zzs52 commented on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-939767747


   > Welcome here @zzs52 , could you look at conflicting files?
   
   Ok,thanks for reminding.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-942420703


   Hi, the CI still failed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-commenter commented on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-1001896430


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#12984](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e9b7483) into [master](https://codecov.io/gh/apache/shardingsphere/commit/4951c4c83147ff2b18b49f2834e51d5dda7382c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4951c4c) will **decrease** coverage by `3.65%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/12984/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #12984      +/-   ##
   ============================================
   - Coverage     63.43%   59.78%   -3.66%     
   - Complexity     1372     1784     +412     
   ============================================
     Files          2502     2938     +436     
     Lines         37553    43668    +6115     
     Branches       6458     7394     +936     
   ============================================
   + Hits          23822    26105    +2283     
   - Misses        11846    15548    +3702     
   - Partials       1885     2015     +130     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...resql/constant/PostgreSQLMessageSeverityLevel.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9jb25zdGFudC9Qb3N0Z3JlU1FMTWVzc2FnZVNldmVyaXR5TGV2ZWwuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ml/swapper/ShadowRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cveWFtbC9zd2FwcGVyL1NoYWRvd1J1bGVDb25maWd1cmF0aW9uWWFtbFN3YXBwZXIuamF2YQ==) | `16.12% <0.00%> (-77.42%)` | :arrow_down: |
   | [...or/statement/impl/SQL92TCLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL3N0YXRlbWVudC9pbXBsL1NRTDkyVENMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...alect/handler/ddl/CreateTableStatementHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9oYW5kbGVyL2RkbC9DcmVhdGVUYWJsZVN0YXRlbWVudEhhbmRsZXIuamF2YQ==) | `38.46% <0.00%> (-61.54%)` | :arrow_down: |
   | [...hecker/AbstractShadowRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvY2hlY2tlci9BYnN0cmFjdFNoYWRvd1J1bGVDb25maWd1cmF0aW9uQ2hlY2tlci5qYXZh) | `57.50% <0.00%> (-42.50%)` | :arrow_down: |
   | [...ardingSphereAlgorithmConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9zd2FwcGVyL2FsZ29yaXRobS9TaGFyZGluZ1NwaGVyZUFsZ29yaXRobUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `60.00% <0.00%> (-40.00%)` | :arrow_down: |
   | [...ropShardingBroadcastTableRulesStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yZGwvZHJvcC9pbXBsL0Ryb3BTaGFyZGluZ0Jyb2FkY2FzdFRhYmxlUnVsZXNTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `60.00% <0.00%> (-40.00%)` | :arrow_down: |
   | [...rdingsphere/infra/route/engine/SQLRouteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3JvdXRlL2VuZ2luZS9TUUxSb3V0ZUVuZ2luZS5qYXZh) | `33.33% <0.00%> (-33.34%)` | :arrow_down: |
   | [...ardingsphere/transaction/core/TransactionType.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYW5zYWN0aW9uL2NvcmUvVHJhbnNhY3Rpb25UeXBlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | [...t/sqlserver/ddl/SQLServerCreateTableStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvc3Fsc2VydmVyL2RkbC9TUUxTZXJ2ZXJDcmVhdGVUYWJsZVN0YXRlbWVudC5qYXZh) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [1551 more](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4951c4c...e9b7483](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] zzs52 commented on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
zzs52 commented on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-1002012656


   > @zzs52 there's no files changed
   
   Okay, I know


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #12984: Update ConnectionTransactionTest.java

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #12984:
URL: https://github.com/apache/shardingsphere/pull/12984#issuecomment-1001896430


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#12984](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0dfd807) into [master](https://codecov.io/gh/apache/shardingsphere/commit/4951c4c83147ff2b18b49f2834e51d5dda7382c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4951c4c) will **decrease** coverage by `3.78%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/12984/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #12984      +/-   ##
   ============================================
   - Coverage     63.43%   59.64%   -3.79%     
   - Complexity     1372     1793     +421     
   ============================================
     Files          2502     2953     +451     
     Lines         37553    43835    +6282     
     Branches       6458     7431     +973     
   ============================================
   + Hits          23822    26147    +2325     
   - Misses        11846    15663    +3817     
   - Partials       1885     2025     +140     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...resql/constant/PostgreSQLMessageSeverityLevel.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9jb25zdGFudC9Qb3N0Z3JlU1FMTWVzc2FnZVNldmVyaXR5TGV2ZWwuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ml/swapper/ShadowRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cveWFtbC9zd2FwcGVyL1NoYWRvd1J1bGVDb25maWd1cmF0aW9uWWFtbFN3YXBwZXIuamF2YQ==) | `16.12% <0.00%> (-77.42%)` | :arrow_down: |
   | [...or/statement/impl/SQL92TCLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL3N0YXRlbWVudC9pbXBsL1NRTDkyVENMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...alect/handler/ddl/CreateTableStatementHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9oYW5kbGVyL2RkbC9DcmVhdGVUYWJsZVN0YXRlbWVudEhhbmRsZXIuamF2YQ==) | `38.46% <0.00%> (-61.54%)` | :arrow_down: |
   | [...hecker/AbstractShadowRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvY2hlY2tlci9BYnN0cmFjdFNoYWRvd1J1bGVDb25maWd1cmF0aW9uQ2hlY2tlci5qYXZh) | `57.50% <0.00%> (-42.50%)` | :arrow_down: |
   | [...ardingSphereAlgorithmConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9zd2FwcGVyL2FsZ29yaXRobS9TaGFyZGluZ1NwaGVyZUFsZ29yaXRobUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `60.00% <0.00%> (-40.00%)` | :arrow_down: |
   | [...ropShardingBroadcastTableRulesStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yZGwvZHJvcC9pbXBsL0Ryb3BTaGFyZGluZ0Jyb2FkY2FzdFRhYmxlUnVsZXNTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `60.00% <0.00%> (-40.00%)` | :arrow_down: |
   | [...rdingsphere/infra/route/engine/SQLRouteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3JvdXRlL2VuZ2luZS9TUUxSb3V0ZUVuZ2luZS5qYXZh) | `33.33% <0.00%> (-33.34%)` | :arrow_down: |
   | [...ardingsphere/transaction/core/TransactionType.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYW5zYWN0aW9uL2NvcmUvVHJhbnNhY3Rpb25UeXBlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | [...t/sqlserver/ddl/SQLServerCreateTableStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvc3Fsc2VydmVyL2RkbC9TUUxTZXJ2ZXJDcmVhdGVUYWJsZVN0YXRlbWVudC5qYXZh) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [1569 more](https://codecov.io/gh/apache/shardingsphere/pull/12984/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4951c4c...0dfd807](https://codecov.io/gh/apache/shardingsphere/pull/12984?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org