You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/02/01 00:10:30 UTC

[GitHub] sijie commented on issue #3379: Issue #3378: [pulsar-io] Support Pulsar to receive and send data from Apache NiFi

sijie commented on issue #3379: Issue #3378: [pulsar-io] Support Pulsar to receive and send data from Apache NiFi 
URL: https://github.com/apache/pulsar/pull/3379#issuecomment-459556244
 
 
   @ambition119 the ack and fail implementation around transaction is still not correct. and I think you need to add more tests around that area in order to make this implementation solid.
   
   Once you addressed that problem, the change is ready to go.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services