You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by The-Loeki <gi...@git.apache.org> on 2016/05/13 14:04:38 UTC
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
GitHub user The-Loeki opened a pull request:
https://github.com/apache/cloudstack/pull/1547
Fixes for VirtualRouters in Basic Networking, especially with mutliple ranges in VLANs
During the last few modifications on the SystemVM scripts, it turns out quite a lot of stuff broke in our setups.
This PR fixes a number of things:
* Multiple IP's per VLAN interface are now supported & working again, including DNS, DHCP ranges, password and metadata services
* `useextdns` fixed (I had a small merge conflict with an attempt to fix this at 4.7, but these fixes are more comprehensive)
* CLOUDSTACK-8303
* Apache configs better in line with best-practices and distro-expected locations
* Added a few more helper functions & getters & setters for utility
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PCextreme/cloudstack vrouter-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1547.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1547
----
commit e09480728f4ed77d0bd0bdc6a6c0966d90f7ee26
Author: Ronald van Zantvoort <ro...@pcextreme.nl>
Date: 2016-05-12T16:56:37Z
Virtual Router fixes:
* Add IP addresses to interfaces when ip_aliases.json gets sent
* Generate multiple dnsmasq range sets when applicable
* Don't try to arping if there's no gateway associated with an address
commit 44c932f091f8403ecb69549904e62b5cf11a1efa
Author: Ronald van Zantvoort <ro...@pcextreme.nl>
Date: 2016-05-12T17:25:50Z
Virtual Router fixes:
* obey useextdns configuration setting
commit 55d1c3821d118bb6869bdb0bdf3918a1ffcef49a
Author: Ronald van Zantvoort <ro...@pcextreme.nl>
Date: 2016-05-12T21:46:09Z
Virtual Router fixes:
* DHCP lease times from infinite to ~a month +- 60 hours (fixes CLOUDSTACK-8303)
commit 9ac3f0914780c4be67ea4c3e7b4d3144b8908856
Author: Ronald van Zantvoort <ro...@pcextreme.nl>
Date: 2016-05-13T10:31:46Z
Virtual Router fixes:
* Fix broken to_str()
* minor cleanup of imports
commit c3b46e95d141f9e570dc75fd2c7b208560682a18
Author: Ronald van Zantvoort <ro...@pcextreme.nl>
Date: 2016-05-13T12:14:29Z
Virtual Router fixes:
* Add has_metadata(), has_dns() and is_dhcp() to Config
* CsIP post_config logic fixes for metadata, routing & dnsmasq services
commit 054000ac3366359b4f1a563f8ccdb13ebb2f86e6
Author: Ronald van Zantvoort <ro...@pcextreme.nl>
Date: 2016-05-13T13:03:43Z
Virtual Router fixes:
* VHosts to sites-enabled
* VHost confs by IP rather than by intf to accomodate multiple IP's per intf
* expose config to CsApp
* Change VHost server name to something sane-ish rather than a Korean squatted cloudinternal.com host
* CsDnsmasq: Only open DNS port if the SysVM is supposed to offer it
commit 2d6fde2e1365fc417ea89eb6c8b7c0846eccd684
Author: Ronald van Zantvoort <ro...@pcextreme.nl>
Date: 2016-05-13T13:43:17Z
Virtual Router fixes cleanup
commit 073db0462111e20375da28cdf2eb0706d418cc0b
Author: Ronald van Zantvoort <ro...@pcextreme.nl>
Date: 2016-05-13T13:56:10Z
Just our luck on the merge conflict there
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1547
@swill I agree, but that's also because this bug is hitting and hurting us. However, I need other people to say LGTM :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1547
### ACS CI BVT Run
**Sumarry:**
Build Number 195
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219273429
started the integration tests on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by linas-h1p <gi...@git.apache.org>.
Github user linas-h1p commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-220058896
Alright I posted in dev@ regarding other issues i'm noticing (Subject: Additional Subnets for networks and VR dhcp), because it seems it doesn't apply to this PR specifically. Still, it might be related.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63569193
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -58,25 +58,35 @@ def get_level(self):
return self.__LOG_LEVEL
def is_vpc(self):
- return self.cl.get_type() == "vpcrouter"
+ return self.cl.get_type() == 'vpcrouter'
def is_router(self):
- return self.cl.get_type() == "router"
+ return self.cl.get_type() == 'router'
+
+ def is_dhcp(self):
+ return self.cl.get_type() == 'dhcpsrvr'
+
+ def has_dns(self):
+ return not self.use_extdns()
+
+ def has_metadata(self):
+ return any((self.is_vpc(), self.is_router(), self.is_dhcp()))
def get_domain(self):
return self.cl.get_domain()
+ def use_extdns(self):
+ return self.cmdline().idata().get('useextdns', 'false') == 'true'
+
def get_dns(self):
+ conf = self.cmdline().idata()
dns = []
- if not self.cl.get_use_ext_dns():
- if not self.is_vpc() and self.cl.is_redundant():
--- End diff --
@DaanHoogland As I can see, the CsGuestNetwork means the vpc tiers.
For isolated networks/shared networks, the dns is set in CsConfig.get_dns().
So, I think the change in CsConfig.get_dns() is wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Networking, espec...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1547
@The-Loeki Do you have an update or where we are?
I've tested the code on a Virtual Router and that worked after the modifications I saw above. This is currently a blocker to me for anybody using multiple ranges inside the same POD.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65104294
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -1207,33 +1145,27 @@ setup_secstorage() {
fi
setup_apache2 $ETH2_IP
+ # Deprecated, should move to Cs Python all of it
+ sed -e "s/<VirtualHost .*:80>/<VirtualHost $ETH2_IP:80>/" \
+ -e "s/<VirtualHost .*:443>/<VirtualHost $ETH2_IP:443>/" \
+ -e "s/Listen .*:80/Listen $ETH2_IP:80/g" \
+ -e "s/Listen .*:443/Listen $ETH2_IP:443/g" \
+ -e "s/NameVirtualHost .*:80/NameVirtualHost $ETH2_IP:80/g" /etc/apache2/vhost.template > /etc/apache2/sites-enabled/vhost-${ETH2_IP}.conf
+
log_it "setting up apache2 for post upload of volume/template"
a2enmod proxy
a2enmod proxy_http
a2enmod headers
- SSL_FILE="/etc/apache2/sites-available/default-ssl"
- PATTERN="RewriteRule ^\/upload\/(.*)"
- CORS_PATTERN="Header set Access-Control-Allow-Origin"
- if [ -f $SSL_FILE ]; then
- if grep -q "$PATTERN" $SSL_FILE ; then
- log_it "rewrite rules already exist in file $SSL_FILE"
- else
- log_it "adding rewrite rules to file: $SSL_FILE"
- sed -i -e "s/<\/VirtualHost>/RewriteEngine On \n&/" $SSL_FILE
- sed -i -e "s/<\/VirtualHost>/RewriteCond %{HTTPS} =on \n&/" $SSL_FILE
- sed -i -e "s/<\/VirtualHost>/RewriteCond %{REQUEST_METHOD} =POST \n&/" $SSL_FILE
- sed -i -e "s/<\/VirtualHost>/RewriteRule ^\/upload\/(.*) http:\/\/127.0.0.1:8210\/upload?uuid=\$1 [P,L] \n&/" $SSL_FILE
- fi
- if grep -q "$CORS_PATTERN" $SSL_FILE ; then
- log_it "cors rules already exist in file $SSL_FILE"
- else
- log_it "adding cors rules to file: $SSL_FILE"
- sed -i -e "s/<\/VirtualHost>/Header always set Access-Control-Allow-Origin \"*\" \n&/" $SSL_FILE
- sed -i -e "s/<\/VirtualHost>/Header always set Access-Control-Allow-Methods \"POST, OPTIONS\" \n&/" $SSL_FILE
- sed -i -e "s/<\/VirtualHost>/Header always set Access-Control-Allow-Headers \"x-requested-with, Content-Type, origin, authorization, accept, client-security-token, x-signature, x-metadata, x-expires\" \n&/" $SSL_FILE
- fi
- fi
+ cat >/etc/apache2/cors.conf <<CORS
+RewriteEngine On
+RewriteCond %{HTTPS} =on
+RewriteCond %{REQUEST_METHOD} =POST
+RewriteRule ^/upload/(.*) http://127.0.0.1:8210/upload?uuid=\$1 [P,L]
+Header always set Access-Control-Allow-Origin "*"
+Header always set Access-Control-Allow-Methods "POST, OPTIONS"
+Header always set Access-Control-Allow-Headers "x-requested-with, Content-Type, origin, authorization, accept, client-security-token, x-signature, x-metadata, x-expires"
+CORS
--- End diff --
This file doesn't seem to be generated and thus fails Apache to start:
<pre>root@r-10-VM:~# ls -l /etc/apache2/
total 73
-rw-r--r-- 1 root root 9675 May 30 20:10 apache2.conf
drwxr-xr-x 2 root root 1024 May 30 20:10 conf.d
-rw-r--r-- 1 root root 1465 Aug 18 2015 envvars
-rwxr-xr-x 1 root root 8 May 30 19:12 httpd.conf
-rw-r--r-- 1 root root 31063 Aug 14 2015 magic
drwxr-xr-x 2 root root 5120 May 30 20:10 mods-available
drwxr-xr-x 2 root root 1024 Nov 9 2015 mods-enabled
drwxr-xr-x 2 root root 1024 May 30 19:54 sites-available
drwxr-xr-x 2 root root 1024 May 30 20:24 sites-enabled
-rwxr-xr-x 1 root root 9289 Jan 30 19:21 vhostexample.conf
-rwxr-xr-x 1 root root 10148 May 30 20:25 vhost.template
root@r-10-VM:~#</pre>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219054423
@The-Loeki those don't show in a short listing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1547
@remi: Thanks for the feedback! @DaanHoogland reported a failure as well, but his second test succeeded without any problems.
I don't have experience with VPC, but as far as I can tell this PR does not touch any VPC code.
In Daan's original results the 'test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL' test went fine.
``Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : SUCCESS ===
ok``
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219712536
@The-Loeki maybe it makes sense to split the PR, especially on the part where there is discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219274189
code looks clean. I don't understand all if it yet so I may ask questions yet. but anaother set of eyes required;
tag:needsreview
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1547
The above is a test against basic networking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1547
I ran the same network tests I mentioned above against master and I had the following results.
```
Tests Run: 24
Skipped: 0
Failed: 8
Errors: 2
Duration: 2h 35m 53s
```
All of the errors were the same on `master`, but in addition it also had a failure on this test:
```
FAIL: Test authorize ingress rule
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs2/cloudstack/test/integration/component/test_security_groups.py", line 459, in test_01_authorizeIngressRule
(self.virtual_machine.ipaddress, e)
AssertionError: SSH Access failed for 192.168.22.221: SSH connection has Failed. Waited 600s. Error is SSH Connection Failed
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_routers_ZEOUOD/results.txt
```
I am not sure if this PR fixed this issue or if it is just an intermittent issue, but this shows that this PR did not introduce any new issues into master (according to these unverified tests).
Given that this fixes issues in basic networking and does not appear to introduce any new issues, I am inclined to add it to the 4.9 release.
@wido, @remibergsma and @DaanHoogland do you guys agree with this decision? Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1547
CI Results: ok one test failed but retest manually succeeded
[1547.results.network.txt](https://github.com/apache/cloudstack/files/300726/1547.results.network.txt)
[1547.results.vpc_routers.txt](https://github.com/apache/cloudstack/files/300727/1547.results.vpc_routers.txt)
@ustcweizhou can you re-review?
@The-Loeki one travis run failed during install though the others succeeded. Maybe you can re-open to try your luck.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1547
Thanks for the feedback @remibergsma and @swill !
Hopefully the results come back positive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1547
I spend some more time testing this. After the latest commits from @The-Loeki it all seems to work:
* Virtual Router listens on all addresses
* Apache is configured properly
* DHCP is answered correctly by the VR
The IPs are configured properly inside the VR:
<pre>
root@r-10-VM:~# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 16436 qdisc noqueue state UNKNOWN
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8 scope host lo
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP qlen 1000
link/ether 06:ee:34:00:00:85 brd ff:ff:ff:ff:ff:ff
inet 109.XX.YY.248/26 brd 109.XX.YY.255 scope global eth0
inet 109.XX.YY.149/28 brd 109.XX.YY.159 scope global eth0
inet 31.XX.YY.133/26 brd 31.XX.YY.191 scope global eth0
3: eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP qlen 1000
link/ether 0e:00:a9:fe:00:5f brd ff:ff:ff:ff:ff:ff
inet 169.254.0.95/16 brd 169.254.255.255 scope global eth1
root@r-10-VM:~#
</pre>
Apache is also working properly on both the VR and the SecStore VM:
<pre>root@r-10-VM:~# ls -l /etc/apache2/sites-enabled/
total 30
-rwxr-xr-x 1 root root 10230 Jun 2 13:40 vhost-109.XX.YY.248.conf
-rwxr-xr-x 1 root root 10230 Jun 2 13:40 vhost-109.XX.YY.149.conf
-rwxr-xr-x 1 root root 10230 Jun 2 13:40 vhost-31.XX.YY.133.conf
root@r-10-VM:~# apache2ctl configtest
apache2: apr_sockaddr_info_get() failed for r-10-VM
apache2: Could not reliably determine the server's fully qualified domain name, using 127.0.0.1 for ServerName
Syntax OK
root@r-10-VM:~# </pre>
<pre>root@s-214-VM:~# ls -l /etc/apache2/sites-enabled/
total 10
lrwxrwxrwx 1 root root 26 Nov 9 2015 000-default -> ../sites-available/default
-rw-r--r-- 1 root root 10206 Jun 2 13:35 vhost-109.XX.YY.206.conf
root@s-214-VM:~# apache2ctl configtest
apache2: Could not reliably determine the server's fully qualified domain name, using 109.XX.YY.206 for ServerName
Syntax OK
root@s-214-VM:~#</pre>
Instances are also able to gather their metadata with cloud-init:
```
1.2.3.4 - - [02/Jun/2016:13:45:15 +0000] "GET //latest/meta-data/instance-id HTTP/1.1" 200 240 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +0000] "GET /latest/user-data HTTP/1.1" 200 202 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +0000] "GET /latest/meta-data/ HTTP/1.1" 200 341 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +0000] "GET /latest/meta-data/local-ipv4 HTTP/1.1" 200 216 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +0000] "GET /latest/meta-data/local-hostname HTTP/1.1" 200 221 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +0000] "GET /latest/meta-data/public-hostname HTTP/1.1" 200 221 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +0000] "GET /latest/meta-data/public-keys HTTP/1.1" 200 202 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +0000] "GET /latest/meta-data/cloud-identifier HTTP/1.1" 200 253 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +0000] "GET /latest/meta-data/service-offering HTTP/1.1" 200 225 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +0000] "GET /latest/meta-data/public-ipv4 HTTP/1.1" 200 216 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +0000] "GET /latest/meta-data/vm-id HTTP/1.1" 200 240 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +0000] "GET /latest/meta-data/availability-zone HTTP/1.1" 200 215 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +0000] "GET /latest/meta-data/instance-id HTTP/1.1" 200 240 "-" "Cloud-Init/0.7.5"
```
The Instance also reports this:
<pre>Cloud-init v. 0.7.5 finished at Thu, 02 Jun 2016 13:46:08 +0000. Datasource DataSourceCloudStack. Up 62.06 seconds</pre>
As far as I can test it is all working. The commits in the PR need to be squashed, but to me it looks good.
I consider this PR a **BLOCKER** for 4.9 though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by The-Loeki <gi...@git.apache.org>.
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219094194
Like this then :dart:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219053999
@The-Loeki 6 commits with the same message is not helpful and indeed confusing. Can you change them to shortly describe the individual fixes, or if you must squash them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219063444
:+1: maybe squash the conflict entries out?
you can rebase -i HEAD^7 and then reorder the commits. If you put the last one at position 3 and change the prefix 'pick' to 'f' for fixup you should be fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63314291
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -58,25 +58,35 @@ def get_level(self):
return self.__LOG_LEVEL
def is_vpc(self):
- return self.cl.get_type() == "vpcrouter"
+ return self.cl.get_type() == 'vpcrouter'
def is_router(self):
- return self.cl.get_type() == "router"
+ return self.cl.get_type() == 'router'
+
+ def is_dhcp(self):
+ return self.cl.get_type() == 'dhcpsrvr'
+
+ def has_dns(self):
+ return not self.use_extdns()
+
+ def has_metadata(self):
+ return any((self.is_vpc(), self.is_router(), self.is_dhcp()))
def get_domain(self):
return self.cl.get_domain()
+ def use_extdns(self):
+ return self.cmdline().idata().get('useextdns', 'false') == 'true'
+
def get_dns(self):
+ conf = self.cmdline().idata()
dns = []
- if not self.cl.get_use_ext_dns():
- if not self.is_vpc() and self.cl.is_redundant():
--- End diff --
these should not be changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1547
@swill Pinging @ustcweizhou again, I know leaseweb has an interest in this. They use advanced zones in several different setups so their ok is a good indication we can merge (together with pcxtreme their ok)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by NuxRo <gi...@git.apache.org>.
Github user NuxRo commented on the issue:
https://github.com/apache/cloudstack/pull/1547
+1 merging, I'm also interested in this if it affects Advanced zone + Security Groups.
Will test ASAP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1547
Great, if the RC is cut we can test that better. I'm about to leave on a 2 week holiday however.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1547
BTW, these tests results are for the following tests
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=basic \
component/test_deploy_vm_userdata_multi_nic.py \
component/test_escalations_securitygroups.py \
component/test_escalations_vpncustomergateways.py \
component/test_security_groups.py \
smoke/test_multipleips_per_nic.py \
smoke/test_portable_publicip.py \
smoke/test_routers.py
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a \
component/maint/test_multiple_ip_ranges.py
```
With `${marvinCfg}` of:
`/data/shared/marvin/mct-zone1-kvm1-basic.cfg`
and
`/data/shared/marvin/mct-zone3-kvm3-basic.cfg`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1547
@wido judging from your testing and commentary, I believe this has your LGTM? You have not officially specified that it does.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1547
Thanks @DaanHoogland for the tests! So it seems that the code looks OK to you?
I just force pushed so Travis should trigger again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1547
@ustcweizhou I can't wait forever on this. What I will likely do if I don't hear back from you is merge this and then cut the RC right away. I am hoping to cut the RC tomorrow, so if you can give me feedback before then I would appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1547
Ok, thanks @DaanHoogland , sounds good!
Looking forward to more input or LGTMs :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1547
### CI RESULTS
```
Tests Run: 22
Skipped: 1
Failed: 0
Errors: 0
Duration: 0h 32m 39s
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__Jun_08_2016_20_33_02_GR1LJ1:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/DeployDataCenter__Jun_08_2016_20_33_02_GR1LJ1/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/DeployDataCenter__Jun_08_2016_20_33_02_GR1LJ1/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/DeployDataCenter__Jun_08_2016_20_33_02_GR1LJ1/runinfo.txt)
**`/tmp/MarvinLogs/test_service_offerings_U496F9:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_service_offerings_U496F9/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_service_offerings_U496F9/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_service_offerings_U496F9/runinfo.txt)
**`/tmp/MarvinLogs/test_ssvm_WVHYBZ:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_ssvm_WVHYBZ/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_ssvm_WVHYBZ/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_ssvm_WVHYBZ/runinfo.txt)
Uploads will be available until `2016-08-08 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1547
Should this set of test have the "basic" tag? It only has the "sg" tag, which I am not targeting.
`/Users/swill/Dropbox/code/cs/cloudstack/test/integration/component/maint/test_multiple_ip_ranges.py`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1547
There have been a couple issues that have been reported on `master` so I don't expect the RC to be cut right away as we sort out those problems. I will probably merge this and we can then continue testing the other issues we have found.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219760013
I am currently testing this in both a basic and advanced zone. I will post results when I have them...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1547
Awesome @DaanHoogland ! As said, this is a problem currently on 4.8 when using multiple ranges inside a pod VLAN.
I/we can't find any issues with the changes made by @The-Loeki , so additional input is welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by The-Loeki <gi...@git.apache.org>.
Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63188699
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -66,8 +66,13 @@ def is_router(self):
def get_domain(self):
return self.cl.get_domain()
+ def use_extdns(self):
+ return self.cmdline().idata().get('useextdns', 'false') == 'true'
+
def get_dns(self):
+ conf = self.cmdline().idata()
dns = []
+<<<<<<< e09480728f4ed77d0bd0bdc6a6c0966d90f7ee26
--- End diff --
Yeah spotted it just too late... Thought I fixxed it but my git-merge-fu isn't fully up to spec yet ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1547
The tests run against basic networking hardly test the functionality of the network though. Apparently most of the tests for the network are only for advanced networking.
I will run against advanced networking again now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219300088
@swill can you schedule this one. Would be nice to get in before freeze. Mine test effort failed (see dev@)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63342702
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -58,25 +58,35 @@ def get_level(self):
return self.__LOG_LEVEL
def is_vpc(self):
- return self.cl.get_type() == "vpcrouter"
+ return self.cl.get_type() == 'vpcrouter'
def is_router(self):
- return self.cl.get_type() == "router"
+ return self.cl.get_type() == 'router'
+
+ def is_dhcp(self):
+ return self.cl.get_type() == 'dhcpsrvr'
+
+ def has_dns(self):
+ return not self.use_extdns()
+
+ def has_metadata(self):
+ return any((self.is_vpc(), self.is_router(), self.is_dhcp()))
def get_domain(self):
return self.cl.get_domain()
+ def use_extdns(self):
+ return self.cmdline().idata().get('useextdns', 'false') == 'true'
+
def get_dns(self):
+ conf = self.cmdline().idata()
dns = []
- if not self.cl.get_use_ext_dns():
- if not self.is_vpc() and self.cl.is_redundant():
--- End diff --
please explain @ustcweizhou?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by The-Loeki <gi...@git.apache.org>.
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-220004141
@linas-h1p thanks for noticing, that fix got lost in commit msg translation.
I've amended the `CsAddress.py` commit to (un)fix the whitespacing & readded the `arpPing()` fix which caused your `KeyError`.
The `ipaliases` stuff is for Pods which have multiple IP ranges in the same Guest VLAN, which is at least a Basic Networking feature.
They indeed don't bring a `gateway` key with them, but CS assumes there is one to ping to verify the connection is up.
By adding this tweak and reformatting the `ipalias.json` the ip aliases are now processed by the same code which adds & removes addresses, which prevents code duplication and additional files & bugs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63188515
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -66,8 +66,13 @@ def is_router(self):
def get_domain(self):
return self.cl.get_domain()
+ def use_extdns(self):
+ return self.cmdline().idata().get('useextdns', 'false') == 'true'
+
def get_dns(self):
+ conf = self.cmdline().idata()
dns = []
+<<<<<<< e09480728f4ed77d0bd0bdc6a6c0966d90f7ee26
--- End diff --
I think you want to squash these out with the last commit in your PR. We wouldn't want this in our history you dutch commercial fan ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219911999
I have seen these errors on two other PRs tonight, so I don't think they are related to this PR. I think this is a pretty clean CI result. I need to track down where those errors come from and see if they are on master right now as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65104266
--- Diff: systemvm/patches/debian/config/etc/apache2/vhost.template ---
@@ -83,10 +83,15 @@
Allow from 127.0.0.0/255.0.0.0 ::1/128
</Directory>
+ # Include CORS configuration if set
+ IncludeOptional /etc/apache2/cors.conf
--- End diff --
Not supported, the SSVM is Apache 2.2 and that doesn't support IncludeOptional
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1547
I see some tests failing on VPCs:
```
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
test_02_redundant_VPC_default_routes
```
Will rebuild from scratch to see if it fails again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1547
@swill: Yes, LGTM from me. But @The-Loeki and I tested this together, so I would prefer more LGTMs, but also want this bug fixed :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1547
### ACS CI BVT Run
**Sumarry:**
Build Number 192
Hypervisor xenserver
NetworkType Advanced
Passed=72
Failed=1
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_vm_life_cycle.py
* test_10_attachAndDetach_iso Failing since 3 runs
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by The-Loeki <gi...@git.apache.org>.
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219062321
@DaanHoogland like it better now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219409102
@ustcweizhou the integration tests are functional tests. If there is extra functionality to be tested please provide the test for it. And at least describe what is missing in the tests, here
You are of course right that we should be carefull with these, but given that @The-Loeki works at PCExtreme, I would not be surprised if this runs in production at the moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by The-Loeki <gi...@git.apache.org>.
Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63691374
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -58,25 +58,35 @@ def get_level(self):
return self.__LOG_LEVEL
def is_vpc(self):
- return self.cl.get_type() == "vpcrouter"
+ return self.cl.get_type() == 'vpcrouter'
def is_router(self):
- return self.cl.get_type() == "router"
+ return self.cl.get_type() == 'router'
+
+ def is_dhcp(self):
+ return self.cl.get_type() == 'dhcpsrvr'
+
+ def has_dns(self):
+ return not self.use_extdns()
+
+ def has_metadata(self):
+ return any((self.is_vpc(), self.is_router(), self.is_dhcp()))
def get_domain(self):
return self.cl.get_domain()
+ def use_extdns(self):
+ return self.cmdline().idata().get('useextdns', 'false') == 'true'
+
def get_dns(self):
+ conf = self.cmdline().idata()
dns = []
- if not self.cl.get_use_ext_dns():
- if not self.is_vpc() and self.cl.is_redundant():
--- End diff --
@ustcweizhou / @DaanHoogland: This should revert the behaviour
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219841186
@swill I think @ustcweizhou has a point. So at least that one commit tag:needslove. The rest should pass our regular suite. We can also create a Marvin definition for a basic zone and run tests on those. @The-Loeki @wido do you have a suitable definition to match your environment ready?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by linas-h1p <gi...@git.apache.org>.
Github user linas-h1p commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-220014434
Seems to be ok now. Thanks for the quick fix.
Another issue:
With the remade apache config generation, i see you are either putting multiple Listen directives or not cleaning up some. Hence apache fails to start with "Address already in use: make_sock: could not bind to address 172.30.0.11:80"
`root@r-74-VM:~# grep -r Listen /etc/apache2/
/etc/apache2/ports.conf:Listen 172.30.0.11:80
/etc/apache2/ports.conf: Listen 172.30.0.11:443
/etc/apache2/ports.conf: Listen 172.30.0.11:443
/etc/apache2/vhostexample.conf:Listen 10.1.1.1:80
/etc/apache2/vhostexample.conf: Listen 10.1.1.1:443
/etc/apache2/vhostexample.conf: Listen 10.1.1.1:443
/etc/apache2/sites-enabled/vhost-172.30.0.11.conf:Listen 172.30.0.11:80
/etc/apache2/sites-enabled/vhost-172.30.0.11.conf:Listen 172.30.0.11:443
/etc/apache2/sites-enabled/vhost-172.30.0.11.conf:Listen 172.30.0.11:443`
Putting Listen to ports.conf is enough, no need to add them to the vhosts themselves.
Currently this breaks metadata service on the VR
Also, i'm still checking the multiple subnets per vlan functionality (specifically dhcp) on my setup. Since we also need that right now, and i'm not sure if it's working for me yet. I'll get back on that soon, when i have specific info (trying to debug / understand the changes from these commits )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by The-Loeki <gi...@git.apache.org>.
Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65131979
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -1207,33 +1145,27 @@ setup_secstorage() {
fi
setup_apache2 $ETH2_IP
+ # Deprecated, should move to Cs Python all of it
+ sed -e "s/<VirtualHost .*:80>/<VirtualHost $ETH2_IP:80>/" \
+ -e "s/<VirtualHost .*:443>/<VirtualHost $ETH2_IP:443>/" \
+ -e "s/Listen .*:80/Listen $ETH2_IP:80/g" \
+ -e "s/Listen .*:443/Listen $ETH2_IP:443/g" \
+ -e "s/NameVirtualHost .*:80/NameVirtualHost $ETH2_IP:80/g" /etc/apache2/vhost.template > /etc/apache2/sites-enabled/vhost-${ETH2_IP}.conf
--- End diff --
It didn't fail, it just didn't happen because that piece of shellscript is exclusively for the SecStore, while VirtualRouter already utilizes the Python bits.
Fixing that migration is unfortunately out of scope for this PR.
The `NameVirtualHost` directive is now added to `CsApp.py`, tnx 4 testing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1547
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 4h 00m 38s
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__Jun_09_2016_06_44_20_ETRLGB:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/DeployDataCenter__Jun_09_2016_06_44_20_ETRLGB/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/DeployDataCenter__Jun_09_2016_06_44_20_ETRLGB/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/DeployDataCenter__Jun_09_2016_06_44_20_ETRLGB/runinfo.txt)
**`/tmp/MarvinLogs/test_network_N3C2B9:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/test_network_N3C2B9/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/test_network_N3C2B9/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/test_network_N3C2B9/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_7OVU64:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/test_vpc_routers_7OVU64/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/test_vpc_routers_7OVU64/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/test_vpc_routers_7OVU64/runinfo.txt)
Uploads will be available until `2016-08-09 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by linas-h1p <gi...@git.apache.org>.
Github user linas-h1p commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219951759
Disclaimer: i'm very new to the whole ACS, but i have built and deployed custom releases for ourselves. I understand the project structure somewhat.
So..
I've applied these commits to 4.8 branch (since that's what we're trying to use at the moment). They appear to be standalone and not affected by other parts of ACS, so 4.8 should be fine. (correct me if i'm wrong)
I'm using advanced networking with security groups.
After these patches, the VR doesn't load - fails when the scripts get executed with KeyErorr 'gateway'. This is in the ipaliases part. I'm not sure what the ip aliases are for there, but it would seem strange that it an ip alias would require gateway.
I've modified "process_ipaliases(self, dbag)" to include a fake gateway in the ipalias data, and the VR started successfully.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219831758
I think we can ignore a lot of this. My tests are mainly setup to test advanced networking. I have to revisit this to know how to test the basic networking stuff correctly. I have tests running against this PR for advanced networking to see if anything is broken on the advanced side because of this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1547
### ACS CI BVT Run
**Sumarry:**
Build Number 202
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65103774
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -801,38 +802,29 @@ setup_sshd(){
setup_vpc_apache2() {
log_it "Setting up apache web server for VPC"
chkconfig apache2 off
- rm -f /etc/apache2/conf.d/vhost*.conf
- [ -f /etc/apache2/sites-available/default ] && echo "" >/etc/apache2/sites-available/default
- [ -f /etc/apache2/sites-available/default-ssl ] && echo "">/etc/apache2/sites-available/default-ssl
- [ -f /etc/apache2/ports.conf ] && echo "">/etc/apache2/ports.conf
- [ -f /etc/apache2/ports.conf ] && echo "">/etc/apache2/ports.conf
- [ -f /etc/apache2/ports.conf ] && echo "">/etc/apache2/ports.conf
- [ -f /etc/apache2/conf.d/security ] && sed -i -e "s/^ServerTokens .*/ServerTokens Prod/g" /etc/apache2/conf.d/security
- [ -f /etc/apache2/conf.d/security ] && sed -i -e "s/^ServerSignature .*/ServerSignature Off/g" /etc/apache2/conf.d/security
-
- # Disable listing of http://SSVM-IP/icons folder for security issue. see article http://www.i-lateral.com/tutorials/disabling-the-icons-folder-on-an-ubuntu-web-server/
- [ -f /etc/apache2/mods-available/alias.conf ] && sed -i s/"Options Indexes MultiViews"/"Options -Indexes MultiViews"/ /etc/apache2/mods-available/alias.conf
-
- echo "Options -Indexes" > /var/www/html/.htaccess
+ clean_ipalias_config
+ setup_apache2_common
}
clean_ipalias_config() {
-rm -f /etc/apache2/conf.d/ports.*.meta-data.conf
-rm -f /etc/apache2/sites-available/ipAlias*
-rm -f /etc/apache2/sites-enabled/ipAlias*
-rm -rf /etc/failure_config
+ # Old
+ rm -f /etc/apache2/conf.d/ports.*.meta-data.conf
+ rm -f /etc/apache2/sites-available/ipAlias*
+ rm -f /etc/apache2/sites-enabled/ipAlias*
+ rm -f /etc/apache2/conf.d/vhost*.conf
+ rm -f /etc/apache2/ports.conf
+ rm -f /etc/apache2/sites-available/default
+ rm -f /etc/apache2/sites-available/default-ssl
--- End diff --
You want to remove the files in /etc/apache2/sites-enabled as well
<pre>rm -f /etc/apache2/sites-enabled/default
rm -f /etc/apache2/sites-enabled/default-ssl</pre>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1547
Yes @wido ,they look good to me but I am not running a cloud at the moment so hence I asked @ustcweizhou to have a look.
He had concerns but I did not see him react since.
The test I did were in advanced zone so we do have a rather broad coverage so far.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by The-Loeki <gi...@git.apache.org>.
Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65132038
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -1207,33 +1145,27 @@ setup_secstorage() {
fi
setup_apache2 $ETH2_IP
+ # Deprecated, should move to Cs Python all of it
+ sed -e "s/<VirtualHost .*:80>/<VirtualHost $ETH2_IP:80>/" \
+ -e "s/<VirtualHost .*:443>/<VirtualHost $ETH2_IP:443>/" \
+ -e "s/Listen .*:80/Listen $ETH2_IP:80/g" \
+ -e "s/Listen .*:443/Listen $ETH2_IP:443/g" \
+ -e "s/NameVirtualHost .*:80/NameVirtualHost $ETH2_IP:80/g" /etc/apache2/vhost.template > /etc/apache2/sites-enabled/vhost-${ETH2_IP}.conf
+
log_it "setting up apache2 for post upload of volume/template"
a2enmod proxy
a2enmod proxy_http
a2enmod headers
- SSL_FILE="/etc/apache2/sites-available/default-ssl"
- PATTERN="RewriteRule ^\/upload\/(.*)"
- CORS_PATTERN="Header set Access-Control-Allow-Origin"
- if [ -f $SSL_FILE ]; then
- if grep -q "$PATTERN" $SSL_FILE ; then
- log_it "rewrite rules already exist in file $SSL_FILE"
- else
- log_it "adding rewrite rules to file: $SSL_FILE"
- sed -i -e "s/<\/VirtualHost>/RewriteEngine On \n&/" $SSL_FILE
- sed -i -e "s/<\/VirtualHost>/RewriteCond %{HTTPS} =on \n&/" $SSL_FILE
- sed -i -e "s/<\/VirtualHost>/RewriteCond %{REQUEST_METHOD} =POST \n&/" $SSL_FILE
- sed -i -e "s/<\/VirtualHost>/RewriteRule ^\/upload\/(.*) http:\/\/127.0.0.1:8210\/upload?uuid=\$1 [P,L] \n&/" $SSL_FILE
- fi
- if grep -q "$CORS_PATTERN" $SSL_FILE ; then
- log_it "cors rules already exist in file $SSL_FILE"
- else
- log_it "adding cors rules to file: $SSL_FILE"
- sed -i -e "s/<\/VirtualHost>/Header always set Access-Control-Allow-Origin \"*\" \n&/" $SSL_FILE
- sed -i -e "s/<\/VirtualHost>/Header always set Access-Control-Allow-Methods \"POST, OPTIONS\" \n&/" $SSL_FILE
- sed -i -e "s/<\/VirtualHost>/Header always set Access-Control-Allow-Headers \"x-requested-with, Content-Type, origin, authorization, accept, client-security-token, x-signature, x-metadata, x-expires\" \n&/" $SSL_FILE
- fi
- fi
+ cat >/etc/apache2/cors.conf <<CORS
+RewriteEngine On
+RewriteCond %{HTTPS} =on
+RewriteCond %{REQUEST_METHOD} =POST
+RewriteRule ^/upload/(.*) http://127.0.0.1:8210/upload?uuid=\$1 [P,L]
+Header always set Access-Control-Allow-Origin "*"
+Header always set Access-Control-Allow-Methods "POST, OPTIONS"
+Header always set Access-Control-Allow-Headers "x-requested-with, Content-Type, origin, authorization, accept, client-security-token, x-signature, x-metadata, x-expires"
+CORS
--- End diff --
It should only generate on a SecStore which is why the `Include` of must be conditional
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1547: Fixes for VirtualRouters in Basic Networking,...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1547
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by The-Loeki <gi...@git.apache.org>.
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219054107
@DaanHoogland click on the (...) :dancers:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219911797
### CI RESULTS
```
Tests Run: 83
Skipped: 0
Failed: 0
Errors: 2
Duration: 8h 52m 19s
```
**Summary of the problem(s):**
```
ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestRVPCSite2SiteVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 835, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F29Y8L/results.txt
```
```
ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestVpcSite2SiteVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 472, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F29Y8L/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_17_2016_18_12_26_5B9U17:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/DeployDataCenter__May_17_2016_18_12_26_5B9U17/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/DeployDataCenter__May_17_2016_18_12_26_5B9U17/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/DeployDataCenter__May_17_2016_18_12_26_5B9U17/runinfo.txt)
**`/tmp/MarvinLogs/test_network_F29Y8L:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_network_F29Y8L/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_network_F29Y8L/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_network_F29Y8L/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_OX8K0O:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_vpc_routers_OX8K0O/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_vpc_routers_OX8K0O/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_vpc_routers_OX8K0O/runinfo.txt)
Uploads will be available until `2016-07-18 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by The-Loeki <gi...@git.apache.org>.
Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65131836
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -801,38 +802,29 @@ setup_sshd(){
setup_vpc_apache2() {
log_it "Setting up apache web server for VPC"
chkconfig apache2 off
- rm -f /etc/apache2/conf.d/vhost*.conf
- [ -f /etc/apache2/sites-available/default ] && echo "" >/etc/apache2/sites-available/default
- [ -f /etc/apache2/sites-available/default-ssl ] && echo "">/etc/apache2/sites-available/default-ssl
- [ -f /etc/apache2/ports.conf ] && echo "">/etc/apache2/ports.conf
- [ -f /etc/apache2/ports.conf ] && echo "">/etc/apache2/ports.conf
- [ -f /etc/apache2/ports.conf ] && echo "">/etc/apache2/ports.conf
- [ -f /etc/apache2/conf.d/security ] && sed -i -e "s/^ServerTokens .*/ServerTokens Prod/g" /etc/apache2/conf.d/security
- [ -f /etc/apache2/conf.d/security ] && sed -i -e "s/^ServerSignature .*/ServerSignature Off/g" /etc/apache2/conf.d/security
-
- # Disable listing of http://SSVM-IP/icons folder for security issue. see article http://www.i-lateral.com/tutorials/disabling-the-icons-folder-on-an-ubuntu-web-server/
- [ -f /etc/apache2/mods-available/alias.conf ] && sed -i s/"Options Indexes MultiViews"/"Options -Indexes MultiViews"/ /etc/apache2/mods-available/alias.conf
-
- echo "Options -Indexes" > /var/www/html/.htaccess
+ clean_ipalias_config
+ setup_apache2_common
}
clean_ipalias_config() {
-rm -f /etc/apache2/conf.d/ports.*.meta-data.conf
-rm -f /etc/apache2/sites-available/ipAlias*
-rm -f /etc/apache2/sites-enabled/ipAlias*
-rm -rf /etc/failure_config
+ # Old
+ rm -f /etc/apache2/conf.d/ports.*.meta-data.conf
+ rm -f /etc/apache2/sites-available/ipAlias*
+ rm -f /etc/apache2/sites-enabled/ipAlias*
+ rm -f /etc/apache2/conf.d/vhost*.conf
+ rm -f /etc/apache2/ports.conf
+ rm -f /etc/apache2/sites-available/default
+ rm -f /etc/apache2/sites-available/default-ssl
--- End diff --
I do & I just did ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1547
@wido FYI all Python code is shared between basic/advanced and router/vpc so it's important to test both. Will try to look into it again in the next days. Not saying it's broken, just want to be careful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by The-Loeki <gi...@git.apache.org>.
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219709644
@DaanHoogland is correct; we're running this code in test-production. Keep in mind however that we only use Basic Networking Zones, so I did my best to keep the behaviour in other circumstances (barring obvious bugs) the same, but I can't test those either.
Regarding @ustcweizhou 's comment; the only change I perceive there is that, analogous to what's in the CsGuestNetwork, the code seems to imply that the guest_gateway_ip will be added as DNS server in the case the SysVM is either a VPC or a redundant router.
As I encountered a merge conflict while building this PR, I think this is a relatively new conditional which seems to mirror the one (incorrectly) in CsGuestNetwork (one depends on the is_vpc() or is_redundant(), the other depends on the availability of the `router_guest_gateway` key).
If this both is true, I propose to change the `has_dns()` method to incorporate this logic and merge the same decision in CsGuestNetwork with that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1547
@ustcweizhou can you review this PR please. I think we are ready on this one and since it fixes issues on master I would like to get it in before I cut the RC. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219121539
I like the first two.
The third should read something like:
CLOUDSTACK-8303 allow multiple ranges & finite lease time
the 4th and 5th I really need to think about but these are not very concise or clear
the 6th could be something like
```
Fixing router ipaddress issues
cleanup imports,
fix get_str(),
improve & fix service post_config logic
```
that way all the info is there for who takes the trouble to click the (...) and for those that are to lazy there is a clear subtract in less then 72 chars.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219827463
### CI RESULTS
```
Tests Run: 57
Skipped: 0
Failed: 18
Errors: 37
Duration: 2h 54m 41s
```
**Summary of the problem(s):**
```
ERROR: Test restart network
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers.py", line 388, in test_03_restart_network_cleanup
self.apiclient.restartNetwork(cmd)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2145, in restartNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-17T19:15:44+0200', cmd : u'org.apache.cloudstack.api.command.user.network.RestartNetworkCmd', userid : u'10b0d755-1c49-11e6-929c-5254001daa61', jobstatus : 2, jobid : u'4cfda548-c261-473e-9b28-64153433c766', jobresultcode : 530, jobresulttype : u'object', jobresult : {errorcode : 530, errortext : u'Failed to restart network'}, accountid : u'10b0c251-1c49-11e6-929c-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: test suite for <class 'integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_reset_vm_on_reboot.py", line 75, in setUpClass
mode=cls.services["mode"]
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 563, in create
virtual_machine = apiclient.deployVirtualMachine(cmd, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 1340, in deployVirtualMachine
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-17T19:31:58+0200', jobresult : {errorcode : 530, errortext : u'Unable to start a VM due to insufficient capacity'}, cmd : u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : u'10b0d755-1c49-11e6-929c-5254001daa61', jobstatus : 2, jobid : u'dd63665e-7c16-41ef-9ac1-94f9c9479515', jobresultcode : 530, jobinstanceid : u'183e2185-7722-4a58-afbb-551a36bbdb08', jobresulttype : u'object', jobinstancetype : u'VirtualMachine', accountid : u'10b0c251-1c49-11e6-929c-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: test suite for <class 'integration.smoke.test_vm_life_cycle.TestDeployVM'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 95, in setUpClass
mode=cls.services['mode']
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 563, in create
virtual_machine = apiclient.deployVirtualMachine(cmd, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 1340, in deployVirtualMachine
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-17T19:47:53+0200', jobresult : {errorcode : 530, errortext : u'Unable to start a VM due to insufficient capacity'}, cmd : u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : u'10b0d755-1c49-11e6-929c-5254001daa61', jobstatus : 2, jobid : u'2d2fdeef-093d-47e5-857e-8d7d72adc18e', jobresultcode : 530, jobinstanceid : u'663fca3c-0b1c-4517-b9af-c6176de609b1', jobresulttype : u'object', jobinstancetype : u'VirtualMachine', accountid : u'10b0c251-1c49-11e6-929c-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: test suite for <class 'integration.smoke.test_vm_life_cycle.TestVMLifeCycle'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 312, in setUpClass
mode=cls.services["mode"]
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 563, in create
virtual_machine = apiclient.deployVirtualMachine(cmd, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 1340, in deployVirtualMachine
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-17T20:03:23+0200', jobresult : {errorcode : 530, errortext : u'Unable to start a VM due to insufficient capacity'}, cmd : u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : u'10b0d755-1c49-11e6-929c-5254001daa61', jobstatus : 2, jobid : u'77d899a2-b3a9-46b5-b3cc-0d58ebc683da', jobresultcode : 530, jobinstanceid : u'4601556f-27eb-492f-9e56-2ec68db36208', jobresulttype : u'object', jobinstancetype : u'VirtualMachine', accountid : u'10b0c251-1c49-11e6-929c-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: test suite for <class 'integration.smoke.test_service_offerings.TestServiceOfferings'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_service_offerings.py", line 202, in setUpClass
mode=cls.services["mode"]
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 563, in create
virtual_machine = apiclient.deployVirtualMachine(cmd, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 1340, in deployVirtualMachine
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-17T20:20:33+0200', jobresult : {errorcode : 530, errortext : u'Unable to start a VM due to insufficient capacity'}, cmd : u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : u'10b0d755-1c49-11e6-929c-5254001daa61', jobstatus : 2, jobid : u'f89bff99-e8fe-45a5-a043-700eba171f8a', jobresultcode : 530, jobinstanceid : u'406bb071-4c06-4531-8af1-23f6397ff1d0', jobresulttype : u'object', jobinstancetype : u'VirtualMachine', accountid : u'10b0c251-1c49-11e6-929c-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: Test for delete account
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 924, in setUp
serviceofferingid=self.service_offering.id
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 563, in create
virtual_machine = apiclient.deployVirtualMachine(cmd, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 1340, in deployVirtualMachine
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-17T20:35:52+0200', jobresult : {errorcode : 530, errortext : u'Unable to start a VM due to insufficient capacity'}, cmd : u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : u'10b0d755-1c49-11e6-929c-5254001daa61', jobstatus : 2, jobid : u'673ba199-907e-4ba6-b213-d423bb85d91f', jobresultcode : 530, jobinstanceid : u'ccf57397-7cc0-4ead-8b0c-155bb77d4b7b', jobresulttype : u'object', jobinstancetype : u'VirtualMachine', accountid : u'10b0c251-1c49-11e6-929c-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: test suite for <class 'integration.smoke.test_network.TestPublicIP'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 104, in setUpClass
cls.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: Test for release public IP address
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 785, in setUp
serviceofferingid=self.service_offering.id
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 563, in create
virtual_machine = apiclient.deployVirtualMachine(cmd, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 1340, in deployVirtualMachine
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-17T20:51:23+0200', jobresult : {errorcode : 530, errortext : u'Unable to start a VM due to insufficient capacity'}, cmd : u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : u'10b0d755-1c49-11e6-929c-5254001daa61', jobstatus : 2, jobid : u'5df5ae03-0cd8-4d36-a270-6e7ae0ada521', jobresultcode : 530, jobinstanceid : u'11451e9b-b647-4111-99b2-6b343834cb22', jobresulttype : u'object', jobinstancetype : u'VirtualMachine', accountid : u'10b0c251-1c49-11e6-929c-5254001daa61'}
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: Test VPC offering without load balancing service
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/component/test_vpc_offerings.py", line 553, in test_03_vpc_off_without_lb
domainid=self.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: Test VPC offering without static NAT service
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/component/test_vpc_offerings.py", line 675, in test_04_vpc_off_without_static_nat
domainid=self.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: Test VPC offering without port forwarding service
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/component/test_vpc_offerings.py", line 799, in test_05_vpc_off_without_pf
domainid=self.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: Test update VPC offering
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/component/test_vpc_offerings.py", line 943, in test_07_update_vpc_off
domainid=self.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: test_09_create_redundant_vpc_offering (integration.component.test_vpc_offerings.TestVPCOffering)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/component/test_vpc_offerings.py", line 1178, in test_09_create_redundant_vpc_offering
domainid=self.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: test suite for <class 'integration.component.test_vpc_routers.TestVPCRouterOneNetwork'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/component/test_vpc_routers.py", line 681, in setUpClass
domainid=cls.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: test suite for <class 'integration.component.test_vpc_routers.TestVPCRoutersBasic'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/component/test_vpc_routers.py", line 243, in setUpClass
domainid=cls.account.domainid
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
FAIL: Test router internal advanced zone
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers.py", line 222, in test_02_router_internal_adv
"Check list response returns a valid list"
AssertionError: Check list response returns a valid list
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
FAIL: Test router basic setup
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers.py", line 556, in test_05_router_basic
"Check list response returns a valid list"
AssertionError: Check list response returns a valid list
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
FAIL: Test router advanced setup
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers.py", line 622, in test_06_router_advanced
"Check list response returns a valid list"
AssertionError: Check list response returns a valid list
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
FAIL: Test stop router
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers.py", line 703, in test_07_stop_router
"Check list response returns a valid list"
AssertionError: Check list response returns a valid list
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
FAIL: Test start router
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers.py", line 746, in test_08_start_router
"Check list response returns a valid list"
AssertionError: Check list response returns a valid list
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
FAIL: Test reboot router
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers.py", line 798, in test_09_reboot_router
"Check list response returns a valid list"
AssertionError: Check list response returns a valid list
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt
```
```
ERROR: test suite for <class 'integration.smoke.test_password_server.TestIsolatedNetworksPasswdServer'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_password_server.py", line 110, in setUpClass
zoneid=cls.zone.id)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Create a redundant VPC with two networks with two VMs in each network
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 270, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Create a redundant VPC with two networks with two VMs in each network and check default routes
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 270, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Create a redundant VPC with two networks with two VMs in each network
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 270, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC Nics
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 270, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC Nics
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_redundant.py", line 270, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Test iptables default INPUT/FORWARD policies on VPC router
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_iptables_default_policy.py", line 273, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 729, in test_01_isolate_network_FW_PF_default_routes_egress_true
zoneid=self.zone.id)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 885, in test_02_isolate_network_FW_PF_default_routes_egress_false
zoneid=self.zone.id)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 170, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
zoneid=self.zone.id
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 335, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
zoneid=self.zone.id
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 510, in test_03_RVR_Network_check_router_state
zoneid=self.zone.id
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Create a VPC with two networks with one VM in each network and test nics after destroy
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_router_nics.py", line 243, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Create a VPC with two networks with one VM in each network and test default routes
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_router_nics.py", line 243, in setUp
domainid=self.account.domainid)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2420, in createVPC
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: test suite for <class 'integration.smoke.test_router_dhcphosts.TestRouterDHCPHosts'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_router_dhcphosts.py", line 110, in setUpClass
zoneid=cls.zone.id)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 2877, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 790, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only AclType=Domain can be specified for network creation in Basic zone
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: test suite for <class 'integration.smoke.test_loadbalance.TestLoadBalance'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_loadbalance.py", line 93, in setUpClass
cls.services["virtual_machine"]
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1581, in create
return PublicIPAddress(apiclient.associateIpAddress(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2590, in associateIpAddress
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: associateipaddress failed, due to: errorCode: 533, errorText:Insufficient address capacity
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Test Remote Access VPN in VPC
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 336, in test_01_vpc_remote_access_vpn
self.assert_(vpc is not None, "VPC creation failed")
UnboundLocalError: local variable 'vpc' referenced before assignment
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Test for port forwarding on non source NAT
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 459, in test_02_port_fwd_on_non_src_nat
self.services["virtual_machine"]
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1581, in create
return PublicIPAddress(apiclient.associateIpAddress(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2590, in associateIpAddress
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: associateipaddress failed, due to: errorCode: 533, errorText:Insufficient address capacity
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Test for reboot router
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 630, in setUp
e)
Exception: Warning: Exception during fetching source NAT: 'NoneType' object has no attribute '__getitem__'
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Test for Router rules for network rules on acquired public IP
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/ddt.py", line 122, in wrapper
return func(self, *args, **kwargs)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 1215, in test_network_rules_acquired_public_ip
networkid=self.defaultNetworkId
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1581, in create
return PublicIPAddress(apiclient.associateIpAddress(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2590, in associateIpAddress
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: associateipaddress failed, due to: errorCode: 533, errorText:Insufficient address capacity
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Test for Router rules for network rules on acquired public IP
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/ddt.py", line 122, in wrapper
return func(self, *args, **kwargs)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 1215, in test_network_rules_acquired_public_ip
networkid=self.defaultNetworkId
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1581, in create
return PublicIPAddress(apiclient.associateIpAddress(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2590, in associateIpAddress
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: associateipaddress failed, due to: errorCode: 533, errorText:Insufficient address capacity
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
ERROR: Test for Router rules for network rules on acquired public IP
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/ddt.py", line 122, in wrapper
return func(self, *args, **kwargs)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 1215, in test_network_rules_acquired_public_ip
networkid=self.defaultNetworkId
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1581, in create
return PublicIPAddress(apiclient.associateIpAddress(cmd).__dict__)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2590, in associateIpAddress
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
CloudstackAPIException: Execute cmd: associateipaddress failed, due to: errorCode: 533, errorText:Insufficient address capacity
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
FAIL: Test iptables default INPUT/FORWARD policy on RouterVM
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_iptables_default_policy.py", line 418, in test_02_routervm_iptables_policies
"Check for list routers response return valid data")
AssertionError: Check for list routers response return valid data
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
FAIL: Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Single VPC
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 599, in test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
self.execute_internallb_roundrobin_tests(vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 635, in execute_internallb_roundrobin_tests
vpc = self.create_vpc(vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 363, in create_vpc
self.fail("Failed to create VPC due to %s" % e)
AssertionError: Failed to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
FAIL: Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's in a Redundant VPC
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 617, in test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80
self.execute_internallb_roundrobin_tests(redundant_vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 635, in execute_internallb_roundrobin_tests
vpc = self.create_vpc(vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 363, in create_vpc
self.fail("Failed to create VPC due to %s" % e)
AssertionError: Failed to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
FAIL: Test to verify access to loadbalancer haproxy admin stats page
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 763, in test_03_vpc_internallb_haproxy_stats_on_all_interfaces
self.execute_internallb_haproxy_tests(vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 807, in execute_internallb_haproxy_tests
vpc = self.create_vpc(vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 363, in create_vpc
self.fail("Failed to create VPC due to %s" % e)
AssertionError: Failed to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
FAIL: Test to verify access to loadbalancer haproxy admin stats page
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 784, in test_04_rvpc_internallb_haproxy_stats_on_all_interfaces
self.execute_internallb_haproxy_tests(redundant_vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 807, in execute_internallb_haproxy_tests
vpc = self.create_vpc(vpc_offering)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 363, in create_vpc
self.fail("Failed to create VPC due to %s" % e)
AssertionError: Failed to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
FAIL: Test Site 2 Site VPN Across redundant VPCs
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 965, in test_01_redundant_vpc_site2site_vpn
self.assert_(vpc1 is not None, "VPC1 creation failed")
AssertionError: VPC1 creation failed
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
FAIL: Test Site 2 Site VPN Across VPCs
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 598, in test_01_vpc_site2site_vpn
self.assert_(vpc1 is not None, "VPC1 creation failed")
AssertionError: VPC1 creation failed
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
FAIL: test_01_vpc_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 235, in test_01_vpc_privategw_acl
vpc = self.createVPC(vpc_off)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 472, in createVPC
self.fail('Unable to create VPC due to %s ' % e)
AssertionError: Unable to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
FAIL: test_02_vpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 262, in test_02_vpc_privategw_static_routes
self.performVPCTests(vpc_off)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 302, in performVPCTests
vpc_1 = self.createVPC(vpc_off, cidr = '10.0.1.0/24')
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 472, in createVPC
self.fail('Unable to create VPC due to %s ' % e)
AssertionError: Unable to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
FAIL: test_03_vpc_privategw_restart_vpc_cleanup (integration.smoke.test_privategw_acl.TestPrivateGwACL)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 274, in test_03_vpc_privategw_restart_vpc_cleanup
self.performVPCTests(vpc_off, restart_with_cleanup = True)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 302, in performVPCTests
vpc_1 = self.createVPC(vpc_off, cidr = '10.0.1.0/24')
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 472, in createVPC
self.fail('Unable to create VPC due to %s ' % e)
AssertionError: Unable to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
FAIL: test_04_rvpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 286, in test_04_rvpc_privategw_static_routes
self.performVPCTests(vpc_off)
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 302, in performVPCTests
vpc_1 = self.createVPC(vpc_off, cidr = '10.0.1.0/24')
File "/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 472, in createVPC
self.fail('Unable to create VPC due to %s ' % e)
AssertionError: Unable to create VPC due to Execute cmd: createvpc failed, due to: errorCode: 431, errorText:Provider VpcVirtualRouter should be enabled in at least one physical network of the zone specified
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
```
FAIL: Test for port forwarding on source NAT
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_network.py", line 332, in test_01_port_fwd_on_src_nat
"Check list response returns a valid list"
AssertionError: Check list response returns a valid list
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_F4VHF4/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_17_2016_18_07_26_DIMQZZ:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/DeployDataCenter__May_17_2016_18_07_26_DIMQZZ/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/DeployDataCenter__May_17_2016_18_07_26_DIMQZZ/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/DeployDataCenter__May_17_2016_18_07_26_DIMQZZ/runinfo.txt)
**`/tmp/MarvinLogs/test_network_F4VHF4:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_network_F4VHF4/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_network_F4VHF4/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_network_F4VHF4/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_offerings_CCC6Z5:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_vpc_offerings_CCC6Z5/runinfo.txt)
Uploads will be available until `2016-07-17 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by The-Loeki <gi...@git.apache.org>.
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-220022831
@linas-h1p tnx for the intel. Strange that I didn't encounter this, I'll go check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63692269
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -82,7 +82,10 @@ def get_dns(self):
conf = self.cmdline().idata()
dns = []
if not self.use_extdns():
- dns.append(self.address().get_guest_ip())
+ if not self.is_vpc() and self.cl.is_redundant() and self.cl.get_guest_gw():
--- End diff --
so this would treat isolated and shared networks alike. Is that acceptable @ustcweizhou ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219358546
guys, please donot merge the changes on VR before a LGTM with functional testing.
the changes on VR should be careful and careful.
a code review and an integration test are not enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1547
Here is a run against advanced networking.
I am trying to test a bunch of basic zone networking tests, but I had never previously verified if they were broken. I have run them against this PR, but there are a bunch of issues. I am going to run the same set of tests against master to see if there is a difference in the results.
Unverified tests run against this PR. Doing the same against master now...
```
Tests Run: 24
Skipped: 0
Failed: 7
Errors: 2
Duration: 2h 21m 30s
```
(details masked intentionally as this set of tests is unverified)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by The-Loeki <gi...@git.apache.org>.
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-220043104
'aight, pulling that string reveals a few more problems to fix unfortunately.
* `cloud-init-early` shell script creates/modifies `ports.conf`, `default`, `default-ssl`. Considering the work towards the Python based code and the deprecation and bitrot already in that script, it seems most logical to stop `cloud-init-early` from touching Apaches' ports & default vhost files.
* the SSL config in `default-ssl` differs from the one in `vhostexample.conf`, and I'm assuming the former is the correct one.
If someone can confirm this I'll hack up the necessary patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1547
Can you also run one against advanced please @swill?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1547
@wido, I am not in favour of squashing these. They seem to be different fixes with their own history. I will start an integration run.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by The-Loeki <gi...@git.apache.org>.
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219754165
Maybe, but for now it's still just one conditional which needs just one decision/explanation.
On the plus side, if the decision can be taken in CsConfig correctly and CsGuestNetwork can employ the same logic this reduces code duplication and improves the overall quality.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fixes for VirtualRouters in Basic Network...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219950557
@DaanHoogland I haven't touched this code much. @The-Loeki ran into this issue when working on our Private Cloud (which is where we test upgrades first).
We don't have a modified Marvin suite. The main problem was when you have multiple IPv4 ranges in a POD only the first/primary one would be configured on the VR.
This PR is to make sure that the VR configures all ranges sent to it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1547
@swill: Before we start squashing all these commits can we get a CI run on this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---