[jira] [Commented] (MAPREDUCE-2932) Missing instrumentation plugin class shouldn't crash the TT startup per design

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097198#comment-13097198 ] 

Hadoop QA commented on MAPREDUCE-2932:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12493041/0.20-MAPREDUCE-2932.r1.diff
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/607//console

This message is automatically generated.

> Missing instrumentation plugin class shouldn't crash the TT startup per design
> ------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2932
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2932
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tasktracker
>    Affects Versions: 0.20.2
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>         Attachments: 0.20-MAPREDUCE-2932.r1.diff
>
>
> Per the implementation of the TaskTracker instrumentation plugin implementation (from 2008), a ClassNotFoundException during loading up of an configured TaskTracker instrumentation class shouldn't have hampered TT start up at all.
> But, there is one class-fetching call outside try/catch, which makes TT fall down with a RuntimeException if there's a class not found. Would be good to include this line into the try/catch itself.
> Strace would appear as:
> {code}
> 2011-08-25 11:45:38,470 ERROR org.apache.hadoop.mapred.TaskTracker: Can not start task tracker because java.lang.RuntimeException: java.lang.RuntimeException: java.lang.ClassNotFoundException: org.apache.hadoop.mapred.CustomInstPlugin 
> at org.apache.hadoop.conf.Configuration.getClass(Configuration.java) 
> at org.apache.hadoop.mapred.TaskTracker.getInstrumentationClass(TaskTracker.java) 
> at org.apache.hadoop.mapred.TaskTracker.initialize(TaskTracker.java) 
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira