You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/01 19:04:12 UTC

[GitHub] [arrow] jonkeane commented on pull request #12531: ARROW-15816: [R][DOCS] pkgdown config refactoring

jonkeane commented on pull request #12531:
URL: https://github.com/apache/arrow/pull/12531#issuecomment-1055761755


   Hello, first I want to say thanks so much for all the work here + other PRs I've seen.
   
   As you both have mentioned: we're a bit stuck and have to choose between supporting search + the version picker we have without putting some time into the JS that does the version picking to be compatible with bootstrap 5. I agree that search is super important, but also that we don't want to lose our version picker since we do that for other languages that Arrow supports.
   
   Would it be possible to push to this branch | PR the changes that get us to using bootstrap 5 (even though it results in a broken site)? Mention the javascript issue, and then we can either leave this open or close it until we have the time to do the necessary javascript work. We'll have a record of what we need to do when we have that javascript skills + headspace to do it, but we don't break anything now. I'm also happy to make sure that you @eitsupi  are listed as a co-author of that PR|commit if + when it merges 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org