[jira] [Commented] (HBASE-8651) Result of integer multiplication cast to long in HRegionFileSystem#sleepBeforeRetry()

["ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683640#comment-13683640 ] 

ramkrishna.s.vasudevan commented on HBASE-8651:
-----------------------------------------------

+1 on patch.
                
> Result of integer multiplication cast to long in HRegionFileSystem#sleepBeforeRetry()
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-8651
>                 URL: https://issues.apache.org/jira/browse/HBASE-8651
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: samar
>            Priority: Minor
>             Fix For: 0.98.0
>
>         Attachments: HBASE-8651.patch
>
>
> {code}
>     Threads.sleep(baseSleepBeforeRetries * sleepMultiplier);
> {code}
> Both baseSleepBeforeRetries and sleepMultiplier are integers. Without proper casting, their product may be negative.
> Here is an example:
> {code}
>   static int i = Integer.MAX_VALUE-1;
>   static long j = i * 2;
> {code}
> value of j above is -4 while 4294967292 was the expected value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira