You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/09/29 19:06:30 UTC
[GitHub] [arrow-adbc] paleolimbot opened a new pull request, #1136: fix(r/adbcdrivermanager): Fix valgrind errors identified by CRAN 0.7.0 submission
paleolimbot opened a new pull request, #1136:
URL: https://github.com/apache/arrow-adbc/pull/1136
There were two problems:
- I forgot that `allocate_xptr<>()` didn't register a finalizer!
- Apparently `ArrowError`s have to be zero-initialized before getting passed to the driver manager to avoid errors.
Closes #1124.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] paleolimbot merged pull request #1136: fix(r/adbcdrivermanager): Fix valgrind errors identified by CRAN 0.7.0 submission
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #1136:
URL: https://github.com/apache/arrow-adbc/pull/1136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #1136: fix(r/adbcdrivermanager): Fix valgrind errors identified by CRAN 0.7.0 submission
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1136:
URL: https://github.com/apache/arrow-adbc/pull/1136#issuecomment-1741366605
Should we add an R-with-valgrind run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] paleolimbot commented on pull request #1136: fix(r/adbcdrivermanager): Fix valgrind errors identified by CRAN 0.7.0 submission
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #1136:
URL: https://github.com/apache/arrow-adbc/pull/1136#issuecomment-1741374311
In general I'm not too worried about this because those parts of the internals don't change very often but I think it's pretty easy to set up (#1138).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #1136: fix(r/adbcdrivermanager): Fix valgrind errors identified by CRAN 0.7.0 submission
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1136:
URL: https://github.com/apache/arrow-adbc/pull/1136#issuecomment-1741366274
> Apparently `ArrowError`s have to be zero-initialized before getting passed to the driver manager to avoid errors.
This was always true, but became even more true after the 1.1.0 changes (since we use a value as a sentinel to decide what ABI version of the error to use)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org