You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Karthik Kambatla (JIRA)" <ji...@apache.org> on 2017/04/03 19:02:41 UTC

[jira] [Comment Edited] (YARN-6245) Add FinalResource object to reduce overhead of Resource class instancing

    [ https://issues.apache.org/jira/browse/YARN-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954014#comment-15954014 ] 

Karthik Kambatla edited comment on YARN-6245 at 4/3/17 7:02 PM:
----------------------------------------------------------------

[~leftnoteasy] - I see the difference between LightResource and FinalResource and the need for both of them. Is the latter an immutable version of the former? 

bq. solve the multi-ops calculation, like d = (res_a * float_x + res_b) / res_c. During the calculation, we need to create some temporary resource instances. A observable copy is not enough because we need to write resource values of these temp resource instances.

I am not sure I fully understand. Mind posting some pseudo code for how this operation *should* look with the API you have in mind? 



was (Author: kasha):
[~leftnoteasy] - I see the difference between LightResource and FinalResource and the need for both of them. The latter 

bq. solve the multi-ops calculation, like d = (res_a * float_x + res_b) / res_c. During the calculation, we need to create some temporary resource instances. A observable copy is not enough because we need to write resource values of these temp resource instances.

I am not sure I fully understand. Mind posting some pseudo code for how this operation *should* look with the API you have in mind? 


> Add FinalResource object to reduce overhead of Resource class instancing
> ------------------------------------------------------------------------
>
>                 Key: YARN-6245
>                 URL: https://issues.apache.org/jira/browse/YARN-6245
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>         Attachments: observable-resource.patch, YARN-6245.preliminary-staled.1.patch
>
>
> There're lots of Resource object creation in YARN Scheduler, since Resource object is backed by protobuf, creation of such objects is expensive and becomes bottleneck.
> To address the problem, we can introduce a FinalResource (Is it better to call it ImmutableResource?) object, which is not backed by PBImpl. We can use this object in frequent invoke paths in the scheduler.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org