You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "John Hjelmstad (JIRA)" <ji...@apache.org> on 2009/04/17 01:31:14 UTC
[jira] Created: (SHINDIG-1015) Allow transitively-required
locked-domain feature to enable locked-domain
Allow transitively-required locked-domain feature to enable locked-domain
-------------------------------------------------------------------------
Key: SHINDIG-1015
URL: https://issues.apache.org/jira/browse/SHINDIG-1015
Project: Shindig
Issue Type: Improvement
Components: Java
Affects Versions: trunk
Reporter: John Hjelmstad
Assignee: John Hjelmstad
Priority: Minor
Fix For: trunk
At present, the only way that locked-domain is enabled is if a gadget explicitly includes:
<Require feature="locked-domain"/>
It should be possible for any particular feature, such as OpenSocial, which deals with sensitive information to always require locked-domain as well. This can be achieved by way of its dependencies (in its feature.xml):
<dependency>locked-domain</dependency>
The new Gadget.getAllFeatures() method makes it possible to support this. Patch forthcoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1015) Allow transitively-required
locked-domain feature to enable locked-domain
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700233#action_12700233 ]
Adam Winer commented on SHINDIG-1015:
-------------------------------------
Patch looks good to me.
> Allow transitively-required locked-domain feature to enable locked-domain
> -------------------------------------------------------------------------
>
> Key: SHINDIG-1015
> URL: https://issues.apache.org/jira/browse/SHINDIG-1015
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: trunk
> Reporter: John Hjelmstad
> Assignee: John Hjelmstad
> Priority: Minor
> Fix For: trunk
>
> Attachments: SHINDIG-1015-1.patch
>
>
> At present, the only way that locked-domain is enabled is if a gadget explicitly includes:
> <Require feature="locked-domain"/>
> It should be possible for any particular feature, such as OpenSocial, which deals with sensitive information to always require locked-domain as well. This can be achieved by way of its dependencies (in its feature.xml):
> <dependency>locked-domain</dependency>
> The new Gadget.getAllFeatures() method makes it possible to support this. Patch forthcoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1015) Allow transitively-required
locked-domain feature to enable locked-domain
Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Hjelmstad updated SHINDIG-1015:
------------------------------------
Attachment: SHINDIG-1015-1.patch
Patch attached that implements this functionality.
NOTE: This patch (of necessity) *changes* the interface for LockedDomainService. In particular, where GadgetSpec was passed, now Gadget is. All calling contexts have Gadget available, so the transition is easy, but installations will nevertheless have to slightly modify any overridden LockedDomainService implementations they may have.
> Allow transitively-required locked-domain feature to enable locked-domain
> -------------------------------------------------------------------------
>
> Key: SHINDIG-1015
> URL: https://issues.apache.org/jira/browse/SHINDIG-1015
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: trunk
> Reporter: John Hjelmstad
> Assignee: John Hjelmstad
> Priority: Minor
> Fix For: trunk
>
> Attachments: SHINDIG-1015-1.patch
>
>
> At present, the only way that locked-domain is enabled is if a gadget explicitly includes:
> <Require feature="locked-domain"/>
> It should be possible for any particular feature, such as OpenSocial, which deals with sensitive information to always require locked-domain as well. This can be achieved by way of its dependencies (in its feature.xml):
> <dependency>locked-domain</dependency>
> The new Gadget.getAllFeatures() method makes it possible to support this. Patch forthcoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1015) Allow transitively-required
locked-domain feature to enable locked-domain
Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Hjelmstad resolved SHINDIG-1015.
-------------------------------------
Resolution: Fixed
Patch committed.
> Allow transitively-required locked-domain feature to enable locked-domain
> -------------------------------------------------------------------------
>
> Key: SHINDIG-1015
> URL: https://issues.apache.org/jira/browse/SHINDIG-1015
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: trunk
> Reporter: John Hjelmstad
> Assignee: John Hjelmstad
> Priority: Minor
> Fix For: trunk
>
> Attachments: SHINDIG-1015-1.patch
>
>
> At present, the only way that locked-domain is enabled is if a gadget explicitly includes:
> <Require feature="locked-domain"/>
> It should be possible for any particular feature, such as OpenSocial, which deals with sensitive information to always require locked-domain as well. This can be achieved by way of its dependencies (in its feature.xml):
> <dependency>locked-domain</dependency>
> The new Gadget.getAllFeatures() method makes it possible to support this. Patch forthcoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1015) Allow transitively-required
locked-domain feature to enable locked-domain
Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699929#action_12699929 ]
John Hjelmstad commented on SHINDIG-1015:
-----------------------------------------
Comments on the patch welcome.
> Allow transitively-required locked-domain feature to enable locked-domain
> -------------------------------------------------------------------------
>
> Key: SHINDIG-1015
> URL: https://issues.apache.org/jira/browse/SHINDIG-1015
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: trunk
> Reporter: John Hjelmstad
> Assignee: John Hjelmstad
> Priority: Minor
> Fix For: trunk
>
> Attachments: SHINDIG-1015-1.patch
>
>
> At present, the only way that locked-domain is enabled is if a gadget explicitly includes:
> <Require feature="locked-domain"/>
> It should be possible for any particular feature, such as OpenSocial, which deals with sensitive information to always require locked-domain as well. This can be achieved by way of its dependencies (in its feature.xml):
> <dependency>locked-domain</dependency>
> The new Gadget.getAllFeatures() method makes it possible to support this. Patch forthcoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.