You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/10 19:15:11 UTC

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8799: Update sql validator status

betodealmeida commented on a change in pull request #8799: Update sql validator status
URL: https://github.com/apache/incubator-superset/pull/8799#discussion_r356226243
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -2638,11 +2638,15 @@ def validate_sql_json(self):
         except Exception as e:
             logging.exception(e)
             msg = _(
-                f"{validator.name} was unable to check your query.\nPlease "
-                "make sure that any services it depends on are available\n"
+                f"{validator.name} was unable to check your query.\n"
+                "Please recheck your query.\n"
 
 Review comment:
   Do we know why the validator is unable to check the query? Is this is something the user can fix? Seems to me that there's nothing the user can do, and the validator should be doing the work of checking the query, no?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org