You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/07 12:06:54 UTC

[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request #3892: Insert clause sharding column null exception

SteNicholas opened a new pull request #3892: Insert clause sharding column null exception
URL: https://github.com/apache/incubator-shardingsphere/pull/3892
 
 
   Fixes #3880. 
   
   Method `createShardingCondition` of `InsertClauseShardingConditionEngine ` couldn't handle the situation that `ExpressionSegment` of null value in literal insert SQL is `CommonExpressionSegment`. Therefore, null value doesn't add to shardingValues and also not throw exception.
   
   Changes proposed in this pull request:
   - Method `createShardingCondition` of `InsertClauseShardingConditionEngine ` adds null expression judgement and throws exception.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] KomachiSion merged pull request #3892: Insert clause sharding column null exception

Posted by GitBox <gi...@apache.org>.
KomachiSion merged pull request #3892: Insert clause sharding column null exception
URL: https://github.com/apache/incubator-shardingsphere/pull/3892
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services