You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/08 08:14:59 UTC
[GitHub] [ozone] ChenSammi opened a new pull request #2001: HDDS-4911. List container by container state.
ChenSammi opened a new pull request #2001:
URL: https://github.com/apache/ozone/pull/2001
https://issues.apache.org/jira/browse/HDDS-4911
There are a lot of unhealthy (CLOSING) state container in our production cluster, add this command line filter to find them all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao commented on a change in pull request #2001: HDDS-4911. List container by container state.
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #2001:
URL: https://github.com/apache/ozone/pull/2001#discussion_r589785681
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java
##########
@@ -98,12 +98,13 @@ void deleteContainer(long containerId, Pipeline pipeline, boolean force)
*
* @param startContainerID start containerID.
* @param count count must be {@literal >} 0.
+ * @param state Container of this state will be returned.
*
* @return a list of pipeline.
* @throws IOException
*/
List<ContainerInfo> listContainer(long startContainerID,
Review comment:
This also helps avoiding some unnecessary unit test changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2001: HDDS-4911. List container by container state.
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2001:
URL: https://github.com/apache/ozone/pull/2001#issuecomment-796545889
@adoroszlai , thanks for the commets. I added one new test step in container.robot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao commented on a change in pull request #2001: HDDS-4911. List container by container state.
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #2001:
URL: https://github.com/apache/ozone/pull/2001#discussion_r589784305
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java
##########
@@ -98,12 +98,13 @@ void deleteContainer(long containerId, Pipeline pipeline, boolean force)
*
* @param startContainerID start containerID.
* @param count count must be {@literal >} 0.
+ * @param state Container of this state will be returned.
*
* @return a list of pipeline.
* @throws IOException
*/
List<ContainerInfo> listContainer(long startContainerID,
Review comment:
Can we add a new listContainer API with state and keep the existing one for better backward compatibility?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi merged pull request #2001: HDDS-4911. List container by container state.
Posted by GitBox <gi...@apache.org>.
ChenSammi merged pull request #2001:
URL: https://github.com/apache/ozone/pull/2001
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a change in pull request #2001: HDDS-4911. List container by container state.
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #2001:
URL: https://github.com/apache/ozone/pull/2001#discussion_r589991592
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java
##########
@@ -98,12 +98,13 @@ void deleteContainer(long containerId, Pipeline pipeline, boolean force)
*
* @param startContainerID start containerID.
* @param count count must be {@literal >} 0.
+ * @param state Container of this state will be returned.
*
* @return a list of pipeline.
* @throws IOException
*/
List<ContainerInfo> listContainer(long startContainerID,
Review comment:
Sure. I will add a new listContainer API. Actually that's the way of my first patch. Then I thought a consolidated API looks like more neat.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2001: HDDS-4911. List container by container state.
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2001:
URL: https://github.com/apache/ozone/pull/2001#issuecomment-796605217
Thanks @adoroszlai @xiaoyuyao for the code review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org