You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "pnoltes (via GitHub)" <gi...@apache.org> on 2023/10/01 15:04:09 UTC
[PR] Feature/508 remove deployment admin bundle (celix)
pnoltes opened a new pull request, #664:
URL: https://github.com/apache/celix/pull/664
This PR removes the deployment admin bundle. This is task in #509.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/508 remove deployment admin bundle (celix)
Posted by "pnoltes (via GitHub)" <gi...@apache.org>.
pnoltes commented on PR #664:
URL: https://github.com/apache/celix/pull/664#issuecomment-1742116464
Note I made a typo with the feature issue nr. So `feature/508-remove-deployment-admin-bundle` should be `feature/509-remove-deployment-admin-bundle`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/508 remove deployment admin bundle (celix)
Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng commented on code in PR #664:
URL: https://github.com/apache/celix/pull/664#discussion_r1347318550
##########
conanfile.py:
##########
@@ -384,12 +378,11 @@ def requirements(self):
if self.options.build_framework or self.options.build_pubsub:
self.requires("util-linux-libuuid/2.39")
if ((self.options.build_framework and self.options.framework_curlinit)
- or self.options.build_celix_etcdlib or self.options.build_deployment_admin
+ or self.options.build_celix_etcdlib
or self.options.build_rsa_discovery_common or self.options.build_rsa_remote_service_admin_dfi
or self.options.build_launcher):
self.requires("libcurl/[>=7.64.1 <8.0.0]")
- if self.options.build_deployment_admin:
- self.requires("zlib/[>=1.2.8 <2.0.0]")
+ self.requires("zlib/[>=1.2.13 <2.0.0]") #Direct dep on zlib is needed to resolve a conflict with libcurl and libzip
Review Comment:
In Conan 2.0, require-override should be done as the following:
```Python
self.requires("openssl/1.1.1t", override=True)
```
Note that the above does not make openssl a requirement, just override upstream requirements.
This is explained here: https://docs.conan.io/2/tutorial/versioning/conflicts.html#resolving-conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/508 remove deployment admin bundle (celix)
Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng commented on code in PR #664:
URL: https://github.com/apache/celix/pull/664#discussion_r1347318550
##########
conanfile.py:
##########
@@ -384,12 +378,11 @@ def requirements(self):
if self.options.build_framework or self.options.build_pubsub:
self.requires("util-linux-libuuid/2.39")
if ((self.options.build_framework and self.options.framework_curlinit)
- or self.options.build_celix_etcdlib or self.options.build_deployment_admin
+ or self.options.build_celix_etcdlib
or self.options.build_rsa_discovery_common or self.options.build_rsa_remote_service_admin_dfi
or self.options.build_launcher):
self.requires("libcurl/[>=7.64.1 <8.0.0]")
- if self.options.build_deployment_admin:
- self.requires("zlib/[>=1.2.8 <2.0.0]")
+ self.requires("zlib/[>=1.2.13 <2.0.0]") #Direct dep on zlib is needed to resolve a conflict with libcurl and libzip
Review Comment:
In Conan 2.0, require-override should be done as the following:
```Python
self.requires("openssl/1.1.1t", override=True)
```
Note that the above does not make openssl a requirement, just override upstream requirements.
This is explained here: https://github.com/conan-io/conan/issues/14535#issuecomment-1687716696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/508 remove deployment admin bundle (celix)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #664:
URL: https://github.com/apache/celix/pull/664#issuecomment-1742111611
## [Codecov](https://app.codecov.io/gh/apache/celix/pull/664?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#664](https://app.codecov.io/gh/apache/celix/pull/664?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (60eab04) into [master](https://app.codecov.io/gh/apache/celix/commit/fedbff5e60a11421cff239581e42bfdb0283d032?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (fedbff5) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 60eab04 differs from pull request most recent head 55078a9. Consider uploading reports for the commit 55078a9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #664 +/- ##
==========================================
+ Coverage 81.61% 81.65% +0.03%
==========================================
Files 260 260
Lines 34677 34677
==========================================
+ Hits 28303 28315 +12
+ Misses 6374 6362 -12
```
[see 5 files with indirect coverage changes](https://app.codecov.io/gh/apache/celix/pull/664/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/508 remove deployment admin bundle (celix)
Posted by "pnoltes (via GitHub)" <gi...@apache.org>.
pnoltes merged PR #664:
URL: https://github.com/apache/celix/pull/664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org