You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Yann Kerherve (JIRA)" <ji...@apache.org> on 2010/04/14 23:20:55 UTC

[jira] Created: (THRIFT-758) incorrect deference in exception handling

incorrect deference in exception handling
-----------------------------------------

                 Key: THRIFT-758
                 URL: https://issues.apache.org/jira/browse/THRIFT-758
             Project: Thrift
          Issue Type: Bug
          Components: Compiler (Perl)
    Affects Versions: 0.2, 0.3
         Environment: thrift from github mirror. Mac OS 10.6.3 
            Reporter: Yann Kerherve



This is a nasty error that is triggered during exception, leaving
the user clueless about the error since she gets a Perl error
instead:
    
    "Can't use string ("0") as a SCALAR ref while "strict refs" in use"
    
For instance:
http://stackoverflow.com/questions/2488783/why-do-i-get-an-error-when-insert

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (THRIFT-758) incorrect deference in exception handling

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-758.
--------------------------------

         Assignee: Yann Kerherve
    Fix Version/s: 0.5
       Resolution: Fixed

I just committed this patch.

> incorrect deference in exception handling
> -----------------------------------------
>
>                 Key: THRIFT-758
>                 URL: https://issues.apache.org/jira/browse/THRIFT-758
>             Project: Thrift
>          Issue Type: Bug
>          Components: Perl - Compiler
>    Affects Versions: 0.2, 0.3
>         Environment: thrift from github mirror. Mac OS 10.6.3 
>            Reporter: Yann Kerherve
>            Assignee: Yann Kerherve
>             Fix For: 0.5
>
>         Attachments: yann.patch
>
>
> This is a nasty error that is triggered during exception, leaving
> the user clueless about the error since she gets a Perl error
> instead:
>     
>     "Can't use string ("0") as a SCALAR ref while "strict refs" in use"
>     
> For instance:
> http://stackoverflow.com/questions/2488783/why-do-i-get-an-error-when-insert

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-758) incorrect deference in exception handling

Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868060#action_12868060 ] 

T Jake Luciani commented on THRIFT-758:
---------------------------------------

Oh sorry, could you include a test case for this under lib/perl/test please?

Thanks!

> incorrect deference in exception handling
> -----------------------------------------
>
>                 Key: THRIFT-758
>                 URL: https://issues.apache.org/jira/browse/THRIFT-758
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Perl)
>    Affects Versions: 0.2, 0.3
>         Environment: thrift from github mirror. Mac OS 10.6.3 
>            Reporter: Yann Kerherve
>         Attachments: yann.patch
>
>
> This is a nasty error that is triggered during exception, leaving
> the user clueless about the error since she gets a Perl error
> instead:
>     
>     "Can't use string ("0") as a SCALAR ref while "strict refs" in use"
>     
> For instance:
> http://stackoverflow.com/questions/2488783/why-do-i-get-an-error-when-insert

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-758) incorrect deference in exception handling

Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868020#action_12868020 ] 

T Jake Luciani commented on THRIFT-758:
---------------------------------------

Hi Yann,

If you want this patch applied, then you'll need to attach it to the JIRA this is the ASF protocol and will ensure there are no licensing issues.

Thanks! 

> incorrect deference in exception handling
> -----------------------------------------
>
>                 Key: THRIFT-758
>                 URL: https://issues.apache.org/jira/browse/THRIFT-758
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Perl)
>    Affects Versions: 0.2, 0.3
>         Environment: thrift from github mirror. Mac OS 10.6.3 
>            Reporter: Yann Kerherve
>
> This is a nasty error that is triggered during exception, leaving
> the user clueless about the error since she gets a Perl error
> instead:
>     
>     "Can't use string ("0") as a SCALAR ref while "strict refs" in use"
>     
> For instance:
> http://stackoverflow.com/questions/2488783/why-do-i-get-an-error-when-insert

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-758) incorrect deference in exception handling

Posted by "Yann Kerherve (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yann Kerherve updated THRIFT-758:
---------------------------------

    Attachment: yann.patch

> incorrect deference in exception handling
> -----------------------------------------
>
>                 Key: THRIFT-758
>                 URL: https://issues.apache.org/jira/browse/THRIFT-758
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Perl)
>    Affects Versions: 0.2, 0.3
>         Environment: thrift from github mirror. Mac OS 10.6.3 
>            Reporter: Yann Kerherve
>         Attachments: yann.patch
>
>
> This is a nasty error that is triggered during exception, leaving
> the user clueless about the error since she gets a Perl error
> instead:
>     
>     "Can't use string ("0") as a SCALAR ref while "strict refs" in use"
>     
> For instance:
> http://stackoverflow.com/questions/2488783/why-do-i-get-an-error-when-insert

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-758) incorrect deference in exception handling

Posted by "Yann Kerherve (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868036#action_12868036 ] 

Yann Kerherve commented on THRIFT-758:
--------------------------------------

Done! Thanks Jake.

> incorrect deference in exception handling
> -----------------------------------------
>
>                 Key: THRIFT-758
>                 URL: https://issues.apache.org/jira/browse/THRIFT-758
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Perl)
>    Affects Versions: 0.2, 0.3
>         Environment: thrift from github mirror. Mac OS 10.6.3 
>            Reporter: Yann Kerherve
>         Attachments: yann.patch
>
>
> This is a nasty error that is triggered during exception, leaving
> the user clueless about the error since she gets a Perl error
> instead:
>     
>     "Can't use string ("0") as a SCALAR ref while "strict refs" in use"
>     
> For instance:
> http://stackoverflow.com/questions/2488783/why-do-i-get-an-error-when-insert

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-758) incorrect deference in exception handling

Posted by "Yann Kerherve (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868343#action_12868343 ] 

Yann Kerherve commented on THRIFT-758:
--------------------------------------

Jake,

I unfortunately have no clue how to generate a TApplicationException with the provided ThriftTest.

I didn't find a way to run the tests automatically either. I manually executed:
perl -Iblib/lib -Ilib -Itest/gen-perl test/processor.t

Thanks,

Yann

> incorrect deference in exception handling
> -----------------------------------------
>
>                 Key: THRIFT-758
>                 URL: https://issues.apache.org/jira/browse/THRIFT-758
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Perl)
>    Affects Versions: 0.2, 0.3
>         Environment: thrift from github mirror. Mac OS 10.6.3 
>            Reporter: Yann Kerherve
>         Attachments: yann.patch
>
>
> This is a nasty error that is triggered during exception, leaving
> the user clueless about the error since she gets a Perl error
> instead:
>     
>     "Can't use string ("0") as a SCALAR ref while "strict refs" in use"
>     
> For instance:
> http://stackoverflow.com/questions/2488783/why-do-i-get-an-error-when-insert

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-758) incorrect deference in exception handling

Posted by "Yann Kerherve (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857101#action_12857101 ] 

Yann Kerherve commented on THRIFT-758:
--------------------------------------

Please see patch in my github fork:

http://github.com/yannk/thrift/commit/4f54015ac02dc33ea4ae22c8b80389e5d6ee9ae6




> incorrect deference in exception handling
> -----------------------------------------
>
>                 Key: THRIFT-758
>                 URL: https://issues.apache.org/jira/browse/THRIFT-758
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Perl)
>    Affects Versions: 0.2, 0.3
>         Environment: thrift from github mirror. Mac OS 10.6.3 
>            Reporter: Yann Kerherve
>
> This is a nasty error that is triggered during exception, leaving
> the user clueless about the error since she gets a Perl error
> instead:
>     
>     "Can't use string ("0") as a SCALAR ref while "strict refs" in use"
>     
> For instance:
> http://stackoverflow.com/questions/2488783/why-do-i-get-an-error-when-insert

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira