You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/23 17:13:17 UTC
[GitHub] [arrow] pitrou opened a new pull request #12497: ARROW-15769: [C++] Generate less arithmetic kernels
pitrou opened a new pull request #12497:
URL: https://github.com/apache/arrow/pull/12497
Template arithmetic kernel executors with the underlying physical type to increase code reuse, decrease binary size, decrease compilation times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12497: ARROW-15769: [C++] Generate less arithmetic kernels
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12497:
URL: https://github.com/apache/arrow/pull/12497#issuecomment-1049058457
Benchmark runs are scheduled for baseline = 1ae81a60d7fc9545103367882908da16a85df04f and contender = 6b631036800e488e6d1e8f9a388b3cd42300fe10. 6b631036800e488e6d1e8f9a388b3cd42300fe10 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2888fe9bd71a488997ffa40d31da0205...5814ff80990c4d0d8842fb41076a50c7/)
[Finished :arrow_down:0.34% :arrow_up:0.08%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fbe294f3aeb440d299c48daf4d9b9e01...b8a31429077c4934b7ef09e09602c4e8/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2b1f68d3fc35483b812aa10acf9ababd...e7d97cb4bdc24e79854a6947cd2ce17b/)
[Finished :arrow_down:0.26% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/27b81ce10c0c4569b46530d3d295e904...8b35d05860da4af695b60c361e5493c5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12497: ARROW-15769: [C++] Generate less arithmetic kernels
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12497:
URL: https://github.com/apache/arrow/pull/12497#issuecomment-1049041973
I think it's still needed for other kernels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12497: ARROW-15769: [C++] Generate less arithmetic kernels
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12497:
URL: https://github.com/apache/arrow/pull/12497#issuecomment-1049013291
cc @rok @lidavidm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12497: ARROW-15769: [C++] Generate less arithmetic kernels
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12497:
URL: https://github.com/apache/arrow/pull/12497#issuecomment-1049034532
@pitrou makes sense. Didn't check but maybe we don't need [this](https://github.com/apache/arrow/pull/12497/files#diff-3eafd7246f6a8c699f10d46e3276852fe44b6853b5517ef10396e561730c09f4L1652-L1653) anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12497: ARROW-15769: [C++] Generate less arithmetic kernels
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12497:
URL: https://github.com/apache/arrow/pull/12497#issuecomment-1049013545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12497: ARROW-15769: [C++] Generate less arithmetic kernels
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12497:
URL: https://github.com/apache/arrow/pull/12497#issuecomment-1049058457
Benchmark runs are scheduled for baseline = 1ae81a60d7fc9545103367882908da16a85df04f and contender = 6b631036800e488e6d1e8f9a388b3cd42300fe10. 6b631036800e488e6d1e8f9a388b3cd42300fe10 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2888fe9bd71a488997ffa40d31da0205...5814ff80990c4d0d8842fb41076a50c7/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fbe294f3aeb440d299c48daf4d9b9e01...b8a31429077c4934b7ef09e09602c4e8/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2b1f68d3fc35483b812aa10acf9ababd...e7d97cb4bdc24e79854a6947cd2ce17b/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/27b81ce10c0c4569b46530d3d295e904...8b35d05860da4af695b60c361e5493c5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #12497: ARROW-15769: [C++] Generate less arithmetic kernels
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12497:
URL: https://github.com/apache/arrow/pull/12497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12497: ARROW-15769: [C++] Generate less arithmetic kernels
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12497:
URL: https://github.com/apache/arrow/pull/12497#issuecomment-1049058457
Benchmark runs are scheduled for baseline = 1ae81a60d7fc9545103367882908da16a85df04f and contender = 6b631036800e488e6d1e8f9a388b3cd42300fe10. 6b631036800e488e6d1e8f9a388b3cd42300fe10 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2888fe9bd71a488997ffa40d31da0205...5814ff80990c4d0d8842fb41076a50c7/)
[Finished :arrow_down:0.34% :arrow_up:0.08%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fbe294f3aeb440d299c48daf4d9b9e01...b8a31429077c4934b7ef09e09602c4e8/)
[Failed :arrow_down:0.72% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2b1f68d3fc35483b812aa10acf9ababd...e7d97cb4bdc24e79854a6947cd2ce17b/)
[Finished :arrow_down:0.26% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/27b81ce10c0c4569b46530d3d295e904...8b35d05860da4af695b60c361e5493c5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12497: ARROW-15769: [C++] Generate less arithmetic kernels
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12497:
URL: https://github.com/apache/arrow/pull/12497#issuecomment-1049058457
Benchmark runs are scheduled for baseline = 1ae81a60d7fc9545103367882908da16a85df04f and contender = 6b631036800e488e6d1e8f9a388b3cd42300fe10. 6b631036800e488e6d1e8f9a388b3cd42300fe10 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2888fe9bd71a488997ffa40d31da0205...5814ff80990c4d0d8842fb41076a50c7/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fbe294f3aeb440d299c48daf4d9b9e01...b8a31429077c4934b7ef09e09602c4e8/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2b1f68d3fc35483b812aa10acf9ababd...e7d97cb4bdc24e79854a6947cd2ce17b/)
[Finished :arrow_down:0.26% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/27b81ce10c0c4569b46530d3d295e904...8b35d05860da4af695b60c361e5493c5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12497: ARROW-15769: [C++] Generate less arithmetic kernels
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12497:
URL: https://github.com/apache/arrow/pull/12497#issuecomment-1049058457
Benchmark runs are scheduled for baseline = 1ae81a60d7fc9545103367882908da16a85df04f and contender = 6b631036800e488e6d1e8f9a388b3cd42300fe10. 6b631036800e488e6d1e8f9a388b3cd42300fe10 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2888fe9bd71a488997ffa40d31da0205...5814ff80990c4d0d8842fb41076a50c7/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fbe294f3aeb440d299c48daf4d9b9e01...b8a31429077c4934b7ef09e09602c4e8/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2b1f68d3fc35483b812aa10acf9ababd...e7d97cb4bdc24e79854a6947cd2ce17b/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/27b81ce10c0c4569b46530d3d295e904...8b35d05860da4af695b60c361e5493c5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org