You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/07/29 06:38:57 UTC
[GitHub] zeppelin pull request #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in ...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1241
[ZEPPELIN-1217] Remove horizontal scrollbar in Zeppelin conf table
### What is this PR for?
This PR will fix [ZEPPELIN-1217](https://issues.apache.org/jira/browse/ZEPPELIN-1217).
Current [Zeppelin configuration table](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#apache-zeppelin-configuration) is hard to compare the env variable name with the descriptions at a glance because of the horizontal scrollbar. So I just removed the scrollbar.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-1217](https://issues.apache.org/jira/browse/ZEPPELIN-1217)
### Screenshots (if appropriate)
- Before
- After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1217
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1241
----
commit 2c822524df2ce3cf504774baa6d44a18618e1d4c
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-07-29T06:23:47Z
Remove horizontal scrollbar in Zeppelin conf table
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1241
@zjffdu I'm not sure, your issue is related with [this issue](https://github.com/bundler/bundler/issues/4065#issuecomment-149596385), could you try
```
gem uninstall bundler
sudo gem install bundler
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1241
@AhyoungRyu I follow the instruction here to build the doc https://github.com/apache/zeppelin/blob/master/docs/README.md#build-documentation, but fails. Here's the error after `bundle install`
```
Using bundler 1.12.5
An error occurred while installing RedCloth (4.2.9), and Bundler cannot continue.
Make sure that `gem install RedCloth -v '4.2.9'` succeeds before bundling.
```
I ran it on mac os 10.11, and also did `xcode-select --install`, do you know how can I fix this ? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1241
@zjffdu Could you review this PR as a reporter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1241
LGTM :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in ...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/zeppelin/pull/1241
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1241
@zjffdu Yeah I also struggled with ruby and my OSX version issues. Anyway thanks for providing the link :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1241
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1241
@AhyoungRyu Just pointing out that using a Table component to show the config variable isn't great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1241
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in ...
Posted by AhyoungRyu <gi...@git.apache.org>.
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/1241
[ZEPPELIN-1217] Remove horizontal scrollbar in Zeppelin conf table
### What is this PR for?
This PR will fix [ZEPPELIN-1217](https://issues.apache.org/jira/browse/ZEPPELIN-1217).
Current [Zeppelin configuration table](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#apache-zeppelin-configuration) is hard to compare the env variable name with the descriptions at a glance because of the horizontal scrollbar. So I just removed the scrollbar.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-1217](https://issues.apache.org/jira/browse/ZEPPELIN-1217)
### Screenshots (if appropriate)
- Before
- After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1217
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1241
----
commit 2c822524df2ce3cf504774baa6d44a18618e1d4c
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-07-29T06:23:47Z
Remove horizontal scrollbar in Zeppelin conf table
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1241
LGTM, could be good to try changing that Table by something more descriptive.
Although the fact that there is 2 different configuration files with possible exclusive configurations doesn't help.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1241
@corneadoug I'm not sure I got your point correctly,
"You can configure Apache Zeppelin with both environment variables in `conf/zeppelin-env.sh` (`conf\zeppelin-env.cmd` for Windows) and Java properties in `conf/zeppelin-site.xml`. If both are defined, then the environment variables will take priority."
This short sentence is written in the above of the table. So do you mean this sentence is not enough? Or do you want me to add more description to the `Description` column?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1241
@zjffdu Did you run `bundle install` under `ZEPPELIN_HOME/docs` dir?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1241
yes, I run it under `ZEPPELIN_HOME/docs`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1241
Is this good to go now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1241
Thanks @AhyoungRyu , the new UI lgtm. BTW, this link helps me in case someone else need this,
http://pragmaticstudio.com/blog/2010/9/23/install-rails-ruby-mac
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---