[GitHub] [druid] jihoonson commented on a change in pull request #9128: Small fixes from #7701

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #9128: Small fixes from #7701
URL: https://github.com/apache/druid/pull/9128#discussion_r363932857
 
 

 ##########
 File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/IndexGeneratorJob.java
 ##########
 @@ -114,13 +114,13 @@
 
     final Path descriptorInfoDir = config.makeDescriptorInfoDir();
 
-    try {
-      FileSystem fs = descriptorInfoDir.getFileSystem(conf);
-
+    try (FileSystem fs = descriptorInfoDir.getFileSystem(conf)) {
 
 Review comment:
   Hi @Fokko, would you elaborate more on this change? Seems like `Path.getFileSystem()` returns a cached instance of a FileSystem and I guess it might be better to leave the cached one rather than removing it from the cache?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org