You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2015/07/30 10:22:15 UTC
[GitHub] tajo pull request: TAJO-1725: TaskContainer can hang when RuntimeE...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/667
TAJO-1725: TaskContainer can hang when RuntimeException occurs in TaskImpl
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1725
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/667.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #667
----
commit 14e8c62bb5032f3742059697dd6a90fee605838e
Author: Hyunsik Choi <hy...@apache.org>
Date: 2015-07-30T08:21:13Z
TAJO-1725: TaskContainer can hang when RuntimeException occurs in TaskImpl.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1725: TaskContainer can hang when RuntimeE...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/667#discussion_r35937482
--- Diff: tajo-core/src/main/java/org/apache/tajo/worker/TaskContainer.java ---
@@ -66,7 +66,8 @@ public void run() {
}
task.cleanup();
- } catch (Exception e) {
+
+ } catch (Throwable e) {
--- End diff --
Nice catch!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1725: TaskContainer can hang when RuntimeE...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/667#issuecomment-126579289
@hyunsik
Query hang is fixed by TAJO-1731. Could you test again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1725: TaskContainer can hang when RuntimeE...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/667#discussion_r35937479
--- Diff: tajo-core/src/main/java/org/apache/tajo/worker/TaskImpl.java ---
@@ -400,10 +401,14 @@ public void run() throws Exception {
}
}
} catch (Throwable e) {
+ // clean up TaskImpl resource
error = e ;
- LOG.error(e.getMessage(), e);
stopScriptExecutors();
context.stop();
+
+ // rethrow the exception in order to propagate the abnormal status to TaskContainer
+ throw new TajoInternalError(e);
--- End diff --
If an exception causes in physical operator, it can be sent failure report in finally block. But rethrow the exception are sent report twice
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1725: TaskContainer can hang when RuntimeE...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/667#issuecomment-126596832
@hyunsik
TAJO-1726 is caused by rethrow the exception
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1725: TaskContainer can hang when RuntimeE...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/667#issuecomment-126579511
This bug seems to be fixed in TAJO-1731. I close this issue. Thank you :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1725: TaskContainer can hang when RuntimeE...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik closed the pull request at:
https://github.com/apache/tajo/pull/667
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---