You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/03/02 10:22:46 UTC
Review Request 57240: AMBARI-20268.WFM generates duplicate kill nodes
in XML if decision paths have multiple transition to kill node.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57240/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
Bugs: AMBARI-20268
https://issues.apache.org/jira/browse/AMBARI-20268
Repository: ambari
Description
-------
Fixed by storing nodes by name instead of id in the visited nodes array
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js eb8534b
Diff: https://reviews.apache.org/r/57240/diff/1/
Testing
-------
Manual Testing
Thanks,
Padma Priya N
Re: Review Request 57240: AMBARI-20268.WFM generates duplicate kill
nodes in XML if decision paths have multiple transition to kill node.
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57240/#review167674
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On March 2, 2017, 10:22 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57240/
> -----------------------------------------------------------
>
> (Updated March 2, 2017, 10:22 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20268
> https://issues.apache.org/jira/browse/AMBARI-20268
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed by storing nodes by name instead of id in the visited nodes array
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js eb8534b
>
>
> Diff: https://reviews.apache.org/r/57240/diff/1/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 57240: AMBARI-20268.WFM generates duplicate kill
nodes in XML if decision paths have multiple transition to kill node.
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57240/#review167665
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On March 2, 2017, 10:22 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57240/
> -----------------------------------------------------------
>
> (Updated March 2, 2017, 10:22 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20268
> https://issues.apache.org/jira/browse/AMBARI-20268
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed by storing nodes by name instead of id in the visited nodes array
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js eb8534b
>
>
> Diff: https://reviews.apache.org/r/57240/diff/1/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>