You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/08/07 02:55:20 UTC
[GitHub] [cordova-common] RomanovX opened a new issue #172: getPreference broken in #133
RomanovX opened a new issue #172:
URL: https://github.com/apache/cordova-common/issues/172
https://github.com/apache/cordova-common/blob/3c9b9ffb93e9ecdbf495a782bb2e5806d060b410/src/ConfigParser/ConfigParser.js#L161
By using pop() over the previous situation, only the last block is selected rather than all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] erisu edited a comment on issue #172: getPreference broken in #133
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on issue #172:
URL: https://github.com/apache/cordova-common/issues/172#issuecomment-895868385
There should only be one `<platform>` entry for a given platform. More then one element for the same platform appears wrong.
If what @raphinesse defined above is the case, I think you should merge the two elements together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] erisu commented on issue #172: getPreference broken in #133
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #172:
URL: https://github.com/apache/cordova-common/issues/172#issuecomment-895868385
There should only be one entry for a given platform.
If what @raphinesse defined above is the case, I think you should merge the two elements together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] raphinesse edited a comment on issue #172: getPreference broken in #133
Posted by GitBox <gi...@apache.org>.
raphinesse edited a comment on issue #172:
URL: https://github.com/apache/cordova-common/issues/172#issuecomment-895853085
Thanks for reporting this. So if I understand it correctly, the issue is the following:
Given following `config.xml`:
```xml
<platform name="android"></platform>
<platform name="android">
<preference name="Fullscreen" value="true" />
</platform>
```
Pre #133 we would have
```js
config.getPreference('Fullscreen', 'android') === 'true'
```
and post #133 we would have
```js
config.getPreference('Fullscreen', 'android') === ''
```
Is that correct?
> This breaks various plugins that depend on this.
Would you mind giving some specific example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org