You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/10 12:26:35 UTC
[GitHub] [flink] akalash opened a new pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
akalash opened a new pull request #16135:
URL: https://github.com/apache/flink/pull/16135
… the first barrier or the barrier announcement received
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*PR fixes the moment since when alignment timeout should start *
## Brief change log
- *firstBarrierArrivalTime recalculated when the checkpoint barrier or the barrier announcement was received rather than as in the past when only the barrier announcement was considered*
## Verifying this change
This change added tests and can be verified as follows:
- *Added new test in AlternatingCheckpointsTest which takes into account the gate with Remote and Local channel*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #16135:
URL: https://github.com/apache/flink/pull/16135#discussion_r655330366
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointOptions.java
##########
@@ -47,7 +47,11 @@
FORCED_ALIGNED
}
- public static final long NO_ALIGNMENT_TIME_OUT = Long.MAX_VALUE;
+ /**
+ * Long.MAX_VALUE can not be used because this value should represent ms which will be converted
+ * to ns.
+ */
+ public static final long NO_ALIGNMENT_TIME_OUT = 2L * Integer.MAX_VALUE;
Review comment:
Oh, I actually think it isn't allowed to do so. I need to rethink it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
}, {
"hash" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19024",
"triggerID" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"triggerType" : "PUSH"
}, {
"hash" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19058",
"triggerID" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"triggerType" : "PUSH"
}, {
"hash" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146",
"triggerID" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"triggerType" : "PUSH"
}, {
"hash" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232",
"triggerID" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"triggerType" : "PUSH"
}, {
"hash" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7bd68734bb46fa17d901f516d69257a6f6a1a6b2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146)
* 0a0544adb7231854460edd0e7c4852f0fd1705b7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232)
* aa01c305c853d067998e3669a107f47d6ff5c173 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #16135:
URL: https://github.com/apache/flink/pull/16135#discussion_r654245153
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/SingleCheckpointBarrierHandler.java
##########
@@ -255,7 +255,6 @@ public void processBarrierAnnouncement(
CheckpointBarrier announcedBarrier, int sequenceNumber, InputChannelInfo channelInfo)
throws IOException {
if (checkNewCheckpoint(announcedBarrier)) {
- firstBarrierArrivalTime = getClock().relativeTimeNanos();
if (alternating) {
Review comment:
Shouldn't we register the Alignment timer on the first barrier as well If there were no announcements for that barrier? I think we could move this block into the `checkNewCheckpoint` method.
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -117,12 +118,13 @@ private boolean executeIgnoreInFlightDataDuringRecovery() {
env.enableCheckpointing(10);
env.disableOperatorChaining();
env.getCheckpointConfig().enableUnalignedCheckpoints();
+ env.getCheckpointConfig().setAlignmentTimeout(Duration.ZERO);
env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);
env.getCheckpointConfig().setCheckpointIdOfIgnoredInFlightData(1);
env.setRestartStrategy(fixedDelayRestart(1, 0));
env.addSource(new NumberSource(lastCheckpointValue))
- .shuffle()
+ .rebalance()
Review comment:
Why is this necessary?
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -117,12 +118,13 @@ private boolean executeIgnoreInFlightDataDuringRecovery() {
env.enableCheckpointing(10);
env.disableOperatorChaining();
env.getCheckpointConfig().enableUnalignedCheckpoints();
+ env.getCheckpointConfig().setAlignmentTimeout(Duration.ZERO);
env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);
env.getCheckpointConfig().setCheckpointIdOfIgnoredInFlightData(1);
env.setRestartStrategy(fixedDelayRestart(1, 0));
env.addSource(new NumberSource(lastCheckpointValue))
- .shuffle()
+ .rebalance()
Review comment:
Why can't we use the default `forward` partitioner then?
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/SingleCheckpointBarrierHandler.java
##########
@@ -255,7 +255,6 @@ public void processBarrierAnnouncement(
CheckpointBarrier announcedBarrier, int sequenceNumber, InputChannelInfo channelInfo)
throws IOException {
if (checkNewCheckpoint(announcedBarrier)) {
- firstBarrierArrivalTime = getClock().relativeTimeNanos();
if (alternating) {
Review comment:
I think that's a valid yet, unrelated issue. It's the same independent if we first receive an announcement or a barrier for a given checkpoint.
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/SingleCheckpointBarrierHandler.java
##########
@@ -255,7 +255,6 @@ public void processBarrierAnnouncement(
CheckpointBarrier announcedBarrier, int sequenceNumber, InputChannelInfo channelInfo)
throws IOException {
if (checkNewCheckpoint(announcedBarrier)) {
- firstBarrierArrivalTime = getClock().relativeTimeNanos();
if (alternating) {
Review comment:
cc @pnowojski
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -117,12 +118,13 @@ private boolean executeIgnoreInFlightDataDuringRecovery() {
env.enableCheckpointing(10);
env.disableOperatorChaining();
env.getCheckpointConfig().enableUnalignedCheckpoints();
+ env.getCheckpointConfig().setAlignmentTimeout(Duration.ZERO);
env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);
env.getCheckpointConfig().setCheckpointIdOfIgnoredInFlightData(1);
env.setRestartStrategy(fixedDelayRestart(1, 0));
env.addSource(new NumberSource(lastCheckpointValue))
- .shuffle()
+ .rebalance()
Review comment:
Does your source have different parallelism than the following map operator? I don't think so. Using `ForwardPartitioner` will result in subtask 0 of the source pushing to subtask 0 of the map operator and so on. If your only goal is to have each of the map operators receive data, I think that's enough, isn't it?
Rebalance means that each source subtask will produce to every map subtask.
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -117,12 +118,13 @@ private boolean executeIgnoreInFlightDataDuringRecovery() {
env.enableCheckpointing(10);
env.disableOperatorChaining();
env.getCheckpointConfig().enableUnalignedCheckpoints();
+ env.getCheckpointConfig().setAlignmentTimeout(Duration.ZERO);
env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);
env.getCheckpointConfig().setCheckpointIdOfIgnoredInFlightData(1);
env.setRestartStrategy(fixedDelayRestart(1, 0));
env.addSource(new NumberSource(lastCheckpointValue))
- .shuffle()
+ .rebalance()
Review comment:
Does your source have lower parallelism than the following map operator? I don't think so. Using `ForwardPartitioner` will result in subtask 0 of the source pushing to subtask 0 of the map operator and so on. If your only goal is to have each of the map operators receive data, I think that's enough, isn't it?
Rebalance means that each source subtask will produce to every map subtask.
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -117,12 +118,13 @@ private boolean executeIgnoreInFlightDataDuringRecovery() {
env.enableCheckpointing(10);
env.disableOperatorChaining();
env.getCheckpointConfig().enableUnalignedCheckpoints();
+ env.getCheckpointConfig().setAlignmentTimeout(Duration.ZERO);
env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);
env.getCheckpointConfig().setCheckpointIdOfIgnoredInFlightData(1);
env.setRestartStrategy(fixedDelayRestart(1, 0));
env.addSource(new NumberSource(lastCheckpointValue))
- .shuffle()
+ .rebalance()
Review comment:
Are you sure? Where do you set the parallelism to `1` for the source? I can't seem to find it.
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -117,12 +118,13 @@ private boolean executeIgnoreInFlightDataDuringRecovery() {
env.enableCheckpointing(10);
env.disableOperatorChaining();
env.getCheckpointConfig().enableUnalignedCheckpoints();
+ env.getCheckpointConfig().setAlignmentTimeout(Duration.ZERO);
env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);
env.getCheckpointConfig().setCheckpointIdOfIgnoredInFlightData(1);
env.setRestartStrategy(fixedDelayRestart(1, 0));
env.addSource(new NumberSource(lastCheckpointValue))
- .shuffle()
+ .rebalance()
Review comment:
Are you sure? Where do you set the parallelism to `1` for the source? I can't find it.
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -117,12 +118,13 @@ private boolean executeIgnoreInFlightDataDuringRecovery() {
env.enableCheckpointing(10);
env.disableOperatorChaining();
env.getCheckpointConfig().enableUnalignedCheckpoints();
+ env.getCheckpointConfig().setAlignmentTimeout(Duration.ZERO);
env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);
env.getCheckpointConfig().setCheckpointIdOfIgnoredInFlightData(1);
env.setRestartStrategy(fixedDelayRestart(1, 0));
env.addSource(new NumberSource(lastCheckpointValue))
- .shuffle()
+ .rebalance()
Review comment:
Right, I keep forgetting about the `ParallelSourceFuntion` :facepalm: It's such a design failure imo.
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -117,12 +118,13 @@ private boolean executeIgnoreInFlightDataDuringRecovery() {
env.enableCheckpointing(10);
env.disableOperatorChaining();
env.getCheckpointConfig().enableUnalignedCheckpoints();
+ env.getCheckpointConfig().setAlignmentTimeout(Duration.ZERO);
env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);
env.getCheckpointConfig().setCheckpointIdOfIgnoredInFlightData(1);
env.setRestartStrategy(fixedDelayRestart(1, 0));
env.addSource(new NumberSource(lastCheckpointValue))
- .shuffle()
+ .rebalance()
Review comment:
Still, I believe you don't need to specify the partitioning explicitly. If you remove the `rebalance` whatsoever it will use the `RescalePartitioner` which behaves the same as `RebalancePartitioner` in this case, because you have just a single source task.
If you do believe a `rebalance` is better, add a comment why you need the `rebalance` there. It's not straightforward to figure out the role of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
}, {
"hash" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19024",
"triggerID" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"triggerType" : "PUSH"
}, {
"hash" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19058",
"triggerID" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"triggerType" : "PUSH"
}, {
"hash" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146",
"triggerID" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"triggerType" : "PUSH"
}, {
"hash" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232",
"triggerID" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"triggerType" : "PUSH"
}, {
"hash" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253",
"triggerID" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a0544adb7231854460edd0e7c4852f0fd1705b7 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232)
* aa01c305c853d067998e3669a107f47d6ff5c173 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
}, {
"hash" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19024",
"triggerID" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"triggerType" : "PUSH"
}, {
"hash" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19058",
"triggerID" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"triggerType" : "PUSH"
}, {
"hash" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146",
"triggerID" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"triggerType" : "PUSH"
}, {
"hash" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232",
"triggerID" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"triggerType" : "PUSH"
}, {
"hash" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253",
"triggerID" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7bd68734bb46fa17d901f516d69257a6f6a1a6b2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146)
* 0a0544adb7231854460edd0e7c4852f0fd1705b7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232)
* aa01c305c853d067998e3669a107f47d6ff5c173 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
}, {
"hash" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19024",
"triggerID" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"triggerType" : "PUSH"
}, {
"hash" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19058",
"triggerID" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"triggerType" : "PUSH"
}, {
"hash" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146",
"triggerID" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"triggerType" : "PUSH"
}, {
"hash" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232",
"triggerID" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"triggerType" : "PUSH"
}, {
"hash" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253",
"triggerID" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"triggerType" : "PUSH"
}, {
"hash" : "176ac8c9f370336255f7b00cf4ddb9d9796a0ea8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19322",
"triggerID" : "176ac8c9f370336255f7b00cf4ddb9d9796a0ea8",
"triggerType" : "PUSH"
}, {
"hash" : "fe4b23fb539fa8f31b06b7283cb17db136406d35",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fe4b23fb539fa8f31b06b7283cb17db136406d35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aa01c305c853d067998e3669a107f47d6ff5c173 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253)
* 176ac8c9f370336255f7b00cf4ddb9d9796a0ea8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19322)
* fe4b23fb539fa8f31b06b7283cb17db136406d35 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
}, {
"hash" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19024",
"triggerID" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"triggerType" : "PUSH"
}, {
"hash" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19058",
"triggerID" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"triggerType" : "PUSH"
}, {
"hash" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146",
"triggerID" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"triggerType" : "PUSH"
}, {
"hash" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232",
"triggerID" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"triggerType" : "PUSH"
}, {
"hash" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253",
"triggerID" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"triggerType" : "PUSH"
}, {
"hash" : "176ac8c9f370336255f7b00cf4ddb9d9796a0ea8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19322",
"triggerID" : "176ac8c9f370336255f7b00cf4ddb9d9796a0ea8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aa01c305c853d067998e3669a107f47d6ff5c173 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253)
* 176ac8c9f370336255f7b00cf4ddb9d9796a0ea8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19322)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
}, {
"hash" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19024",
"triggerID" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ccb16da36ee8408261b7b77e5828c495af3e23c9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996)
* db167e9db88e576e58eb8ef2e47d08c5123b7320 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19024)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #16135:
URL: https://github.com/apache/flink/pull/16135#discussion_r655330366
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointOptions.java
##########
@@ -47,7 +47,11 @@
FORCED_ALIGNED
}
- public static final long NO_ALIGNMENT_TIME_OUT = Long.MAX_VALUE;
+ /**
+ * Long.MAX_VALUE can not be used because this value should represent ms which will be converted
+ * to ns.
+ */
+ public static final long NO_ALIGNMENT_TIME_OUT = 2L * Integer.MAX_VALUE;
Review comment:
Oh, I actually think it isn't allowed to do so. I need to rethink it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys merged pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #16135:
URL: https://github.com/apache/flink/pull/16135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
}, {
"hash" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19024",
"triggerID" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"triggerType" : "PUSH"
}, {
"hash" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19058",
"triggerID" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"triggerType" : "PUSH"
}, {
"hash" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146",
"triggerID" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"triggerType" : "PUSH"
}, {
"hash" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232",
"triggerID" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7bd68734bb46fa17d901f516d69257a6f6a1a6b2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146)
* 0a0544adb7231854460edd0e7c4852f0fd1705b7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #16135:
URL: https://github.com/apache/flink/pull/16135#discussion_r654276097
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/SingleCheckpointBarrierHandler.java
##########
@@ -255,7 +255,6 @@ public void processBarrierAnnouncement(
CheckpointBarrier announcedBarrier, int sequenceNumber, InputChannelInfo channelInfo)
throws IOException {
if (checkNewCheckpoint(announcedBarrier)) {
- firstBarrierArrivalTime = getClock().relativeTimeNanos();
if (alternating) {
Review comment:
Good point. I believe it indeed makes sense to move it to `checkNewCheckpoint`
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -117,12 +118,13 @@ private boolean executeIgnoreInFlightDataDuringRecovery() {
env.enableCheckpointing(10);
env.disableOperatorChaining();
env.getCheckpointConfig().enableUnalignedCheckpoints();
+ env.getCheckpointConfig().setAlignmentTimeout(Duration.ZERO);
env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);
env.getCheckpointConfig().setCheckpointIdOfIgnoredInFlightData(1);
env.setRestartStrategy(fixedDelayRestart(1, 0));
env.addSource(new NumberSource(lastCheckpointValue))
- .shuffle()
+ .rebalance()
Review comment:
This test should guarantee that all three subtasks will receive at least one record. Right now, the source emits fifty records which are enough to make this test working even with `shuffle` but strictly to say `shuffle` doesn't make sense here while `rebalance` does exactly what we need. So this change is not really necessary but it provides more correct behaviour for this test.
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/SingleCheckpointBarrierHandler.java
##########
@@ -255,7 +255,6 @@ public void processBarrierAnnouncement(
CheckpointBarrier announcedBarrier, int sequenceNumber, InputChannelInfo channelInfo)
throws IOException {
if (checkNewCheckpoint(announcedBarrier)) {
- firstBarrierArrivalTime = getClock().relativeTimeNanos();
if (alternating) {
Review comment:
As I understand, this will be only partially working anyway: if we received the first barrier from localChannel without announcement and the timeout happened, then only barriers that have the announcements can be prioritized but if the other channel is local there will be no effect.
So how do you think it is problem or not if we can prioritize the barriers only for the remote channel(which has an announcement)?
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -117,12 +118,13 @@ private boolean executeIgnoreInFlightDataDuringRecovery() {
env.enableCheckpointing(10);
env.disableOperatorChaining();
env.getCheckpointConfig().enableUnalignedCheckpoints();
+ env.getCheckpointConfig().setAlignmentTimeout(Duration.ZERO);
env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);
env.getCheckpointConfig().setCheckpointIdOfIgnoredInFlightData(1);
env.setRestartStrategy(fixedDelayRestart(1, 0));
env.addSource(new NumberSource(lastCheckpointValue))
- .shuffle()
+ .rebalance()
Review comment:
Perhaps, I don't understand something but who guarantees that all subtasks will receive the records? As I can see in the implementation of ForwardPartitioner it always returns the first subpartition(`return 0;`)
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -117,12 +118,13 @@ private boolean executeIgnoreInFlightDataDuringRecovery() {
env.enableCheckpointing(10);
env.disableOperatorChaining();
env.getCheckpointConfig().enableUnalignedCheckpoints();
+ env.getCheckpointConfig().setAlignmentTimeout(Duration.ZERO);
env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);
env.getCheckpointConfig().setCheckpointIdOfIgnoredInFlightData(1);
env.setRestartStrategy(fixedDelayRestart(1, 0));
env.addSource(new NumberSource(lastCheckpointValue))
- .shuffle()
+ .rebalance()
Review comment:
> Does your source have lower parallelism than the following map operator?
Actually, it does. I have only one source and three followed maps.I did it because it is easier to manage the execution when you have only one source.
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -117,12 +118,13 @@ private boolean executeIgnoreInFlightDataDuringRecovery() {
env.enableCheckpointing(10);
env.disableOperatorChaining();
env.getCheckpointConfig().enableUnalignedCheckpoints();
+ env.getCheckpointConfig().setAlignmentTimeout(Duration.ZERO);
env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);
env.getCheckpointConfig().setCheckpointIdOfIgnoredInFlightData(1);
env.setRestartStrategy(fixedDelayRestart(1, 0));
env.addSource(new NumberSource(lastCheckpointValue))
- .shuffle()
+ .rebalance()
Review comment:
> Does your source have lower parallelism than the following map operator?
Actually, it does. I have only one source and three followed maps.I did it because it is easier to manage the execution when you have only one source.
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -117,12 +118,13 @@ private boolean executeIgnoreInFlightDataDuringRecovery() {
env.enableCheckpointing(10);
env.disableOperatorChaining();
env.getCheckpointConfig().enableUnalignedCheckpoints();
+ env.getCheckpointConfig().setAlignmentTimeout(Duration.ZERO);
env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);
env.getCheckpointConfig().setCheckpointIdOfIgnoredInFlightData(1);
env.setRestartStrategy(fixedDelayRestart(1, 0));
env.addSource(new NumberSource(lastCheckpointValue))
- .shuffle()
+ .rebalance()
Review comment:
Yes, I am sure. It happens because I implemented SourceFunction which always has parallelism 1 rather than ParallelSourceFunction which has the configured parallelism.
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
##########
@@ -117,12 +118,13 @@ private boolean executeIgnoreInFlightDataDuringRecovery() {
env.enableCheckpointing(10);
env.disableOperatorChaining();
env.getCheckpointConfig().enableUnalignedCheckpoints();
+ env.getCheckpointConfig().setAlignmentTimeout(Duration.ZERO);
env.getCheckpointConfig().setCheckpointingMode(CheckpointingMode.EXACTLY_ONCE);
env.getCheckpointConfig().setCheckpointIdOfIgnoredInFlightData(1);
env.setRestartStrategy(fixedDelayRestart(1, 0));
env.addSource(new NumberSource(lastCheckpointValue))
- .shuffle()
+ .rebalance()
Review comment:
Ok, I see it works pretty well even without `rebalance`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
}, {
"hash" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ccb16da36ee8408261b7b77e5828c495af3e23c9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996)
* db167e9db88e576e58eb8ef2e47d08c5123b7320 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #16135:
URL: https://github.com/apache/flink/pull/16135#discussion_r656363060
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointOptions.java
##########
@@ -47,7 +48,8 @@
FORCED_ALIGNED
}
- public static final long NO_ALIGNMENT_TIME_OUT = Long.MAX_VALUE;
+ /** The maximum possible value is Long.MAX_VALUE 'ns' but API receives 'ms'. */
+ public static final long NO_ALIGNMENT_TIME_OUT = Duration.ofNanos(Long.MAX_VALUE).toMillis();
Review comment:
Hmm, ok I understand the problem, but then I think the solution is actually wrong. The `NO_ALIGNEMNT_TIME_OUT` means there should be no alignment timeout, therefore we should not register the timer.
We should rather add a condition in the `checkNewCheckpoint`:
```
private void checkNewCheckpoint(CheckpointBarrier barrier) throws IOException {
long barrierId = barrier.getId();
if (currentCheckpointId < barrierId) {
if (isCheckpointPending()) {
cancelSubsumedCheckpoint(barrierId);
}
currentCheckpointId = barrierId;
numBarriersReceived = 0;
allBarriersReceivedFuture = new CompletableFuture<>();
return true;
if (currentCheckpointId >= barrierId) {
return; // This barrier is not the first for this checkpoint.
}
if (isCheckpointPending()) {
cancelSubsumedCheckpoint(barrierId);
}
currentCheckpointId = barrierId;
numBarriersReceived = 0;
allBarriersReceivedFuture = new CompletableFuture<>();
firstBarrierArrivalTime = getClock().relativeTimeNanos();
if (alternating && barrier.getCheckpointOptions().isTimeoutable()) {
registerAlignmentTimer(barrier);
}
return false;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dad95587d4b4670259711ad6fdc9f0601499126d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937)
* ccb16da36ee8408261b7b77e5828c495af3e23c9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #16135:
URL: https://github.com/apache/flink/pull/16135#discussion_r656345974
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointOptions.java
##########
@@ -47,7 +48,8 @@
FORCED_ALIGNED
}
- public static final long NO_ALIGNMENT_TIME_OUT = Long.MAX_VALUE;
+ /** The maximum possible value is Long.MAX_VALUE 'ns' but API receives 'ms'. */
+ public static final long NO_ALIGNMENT_TIME_OUT = Duration.ofNanos(Long.MAX_VALUE).toMillis();
Review comment:
It was impossible to set NO_ALIGNMENT_TIME_OUT when alternating is enabled because when we are registering the register timer it converts this value to nanosecond which leads to the error because it was Long.MAX_VALUE.
We didn't see this problem because such a combination alternating + NO_ALIGNEMNT_TIME_OUT didn't meet before my changes but after I moved registerAlignmentTimer to checkNewCheckpoint some tests meet this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
}, {
"hash" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19024",
"triggerID" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"triggerType" : "PUSH"
}, {
"hash" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19058",
"triggerID" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"triggerType" : "PUSH"
}, {
"hash" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146",
"triggerID" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"triggerType" : "PUSH"
}, {
"hash" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232",
"triggerID" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"triggerType" : "PUSH"
}, {
"hash" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253",
"triggerID" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aa01c305c853d067998e3669a107f47d6ff5c173 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
akalash commented on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-866104401
@dawidwys. I squashed a couple of commits. And I answered your question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
}, {
"hash" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19024",
"triggerID" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"triggerType" : "PUSH"
}, {
"hash" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19058",
"triggerID" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"triggerType" : "PUSH"
}, {
"hash" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146",
"triggerID" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"triggerType" : "PUSH"
}, {
"hash" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232",
"triggerID" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"triggerType" : "PUSH"
}, {
"hash" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253",
"triggerID" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"triggerType" : "PUSH"
}, {
"hash" : "176ac8c9f370336255f7b00cf4ddb9d9796a0ea8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19322",
"triggerID" : "176ac8c9f370336255f7b00cf4ddb9d9796a0ea8",
"triggerType" : "PUSH"
}, {
"hash" : "fe4b23fb539fa8f31b06b7283cb17db136406d35",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19329",
"triggerID" : "fe4b23fb539fa8f31b06b7283cb17db136406d35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 176ac8c9f370336255f7b00cf4ddb9d9796a0ea8 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19322)
* fe4b23fb539fa8f31b06b7283cb17db136406d35 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19329)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-863877226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #16135:
URL: https://github.com/apache/flink/pull/16135#discussion_r656363060
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointOptions.java
##########
@@ -47,7 +48,8 @@
FORCED_ALIGNED
}
- public static final long NO_ALIGNMENT_TIME_OUT = Long.MAX_VALUE;
+ /** The maximum possible value is Long.MAX_VALUE 'ns' but API receives 'ms'. */
+ public static final long NO_ALIGNMENT_TIME_OUT = Duration.ofNanos(Long.MAX_VALUE).toMillis();
Review comment:
Hmm, ok I understand the problem, but then I think the solution is actually wrong. The `NO_ALIGNEMNT_TIME_OUT` means there should be no alignment timeout, therefore we should not register the timer.
We should rather add a condition in the `checkNewCheckpoint`:
```
private void checkNewCheckpoint(CheckpointBarrier barrier) throws IOException {
long barrierId = barrier.getId();
if (currentCheckpointId < barrierId) {
if (isCheckpointPending()) {
cancelSubsumedCheckpoint(barrierId);
}
currentCheckpointId = barrierId;
numBarriersReceived = 0;
allBarriersReceivedFuture = new CompletableFuture<>();
return true;
if (currentCheckpointId >= barrierId) {
return; // This barrier is not the first for this checkpoint.
}
if (isCheckpointPending()) {
cancelSubsumedCheckpoint(barrierId);
}
currentCheckpointId = barrierId;
numBarriersReceived = 0;
allBarriersReceivedFuture = new CompletableFuture<>();
firstBarrierArrivalTime = getClock().relativeTimeNanos();
if (alternating && barrier.getCheckpointOptions().isTimeoutable()) {
registerAlignmentTimer(barrier);
}
return false;
}
```
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
}, {
"hash" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19024",
"triggerID" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"triggerType" : "PUSH"
}, {
"hash" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19058",
"triggerID" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"triggerType" : "PUSH"
}, {
"hash" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146",
"triggerID" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"triggerType" : "PUSH"
}, {
"hash" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232",
"triggerID" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"triggerType" : "PUSH"
}, {
"hash" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253",
"triggerID" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"triggerType" : "PUSH"
}, {
"hash" : "176ac8c9f370336255f7b00cf4ddb9d9796a0ea8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19322",
"triggerID" : "176ac8c9f370336255f7b00cf4ddb9d9796a0ea8",
"triggerType" : "PUSH"
}, {
"hash" : "fe4b23fb539fa8f31b06b7283cb17db136406d35",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19329",
"triggerID" : "fe4b23fb539fa8f31b06b7283cb17db136406d35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aa01c305c853d067998e3669a107f47d6ff5c173 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253)
* 176ac8c9f370336255f7b00cf4ddb9d9796a0ea8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19322)
* fe4b23fb539fa8f31b06b7283cb17db136406d35 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19329)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dad95587d4b4670259711ad6fdc9f0601499126d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937)
* ccb16da36ee8408261b7b77e5828c495af3e23c9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858578314
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fe4b23fb539fa8f31b06b7283cb17db136406d35 (Thu Sep 23 17:27:00 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-866070940
I have just a single question. Apart from that looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
akalash commented on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-859003490
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858578314
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff (Thu Jun 10 12:28:38 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
akalash commented on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-859503605
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ccb16da36ee8408261b7b77e5828c495af3e23c9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
}, {
"hash" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19024",
"triggerID" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"triggerType" : "PUSH"
}, {
"hash" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19058",
"triggerID" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"triggerType" : "PUSH"
}, {
"hash" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146",
"triggerID" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"triggerType" : "PUSH"
}, {
"hash" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232",
"triggerID" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"triggerType" : "PUSH"
}, {
"hash" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253",
"triggerID" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"triggerType" : "PUSH"
}, {
"hash" : "176ac8c9f370336255f7b00cf4ddb9d9796a0ea8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19322",
"triggerID" : "176ac8c9f370336255f7b00cf4ddb9d9796a0ea8",
"triggerType" : "PUSH"
}, {
"hash" : "fe4b23fb539fa8f31b06b7283cb17db136406d35",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19329",
"triggerID" : "fe4b23fb539fa8f31b06b7283cb17db136406d35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fe4b23fb539fa8f31b06b7283cb17db136406d35 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19329)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
}, {
"hash" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19024",
"triggerID" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"triggerType" : "PUSH"
}, {
"hash" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19058",
"triggerID" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"triggerType" : "PUSH"
}, {
"hash" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146",
"triggerID" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"triggerType" : "PUSH"
}, {
"hash" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7bd68734bb46fa17d901f516d69257a6f6a1a6b2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146)
* 0a0544adb7231854460edd0e7c4852f0fd1705b7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
akalash commented on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-863942914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18930",
"triggerID" : "859503605",
"triggerType" : "MANUAL"
}, {
"hash" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18937",
"triggerID" : "dad95587d4b4670259711ad6fdc9f0601499126d",
"triggerType" : "PUSH"
}, {
"hash" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18996",
"triggerID" : "ccb16da36ee8408261b7b77e5828c495af3e23c9",
"triggerType" : "PUSH"
}, {
"hash" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19024",
"triggerID" : "db167e9db88e576e58eb8ef2e47d08c5123b7320",
"triggerType" : "PUSH"
}, {
"hash" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19058",
"triggerID" : "c0398270a0045becd6a0a62fc94f1ba8d679a111",
"triggerType" : "PUSH"
}, {
"hash" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19146",
"triggerID" : "7bd68734bb46fa17d901f516d69257a6f6a1a6b2",
"triggerType" : "PUSH"
}, {
"hash" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19232",
"triggerID" : "0a0544adb7231854460edd0e7c4852f0fd1705b7",
"triggerType" : "PUSH"
}, {
"hash" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253",
"triggerID" : "aa01c305c853d067998e3669a107f47d6ff5c173",
"triggerType" : "PUSH"
}, {
"hash" : "176ac8c9f370336255f7b00cf4ddb9d9796a0ea8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "176ac8c9f370336255f7b00cf4ddb9d9796a0ea8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aa01c305c853d067998e3669a107f47d6ff5c173 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19253)
* 176ac8c9f370336255f7b00cf4ddb9d9796a0ea8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #16135:
URL: https://github.com/apache/flink/pull/16135#discussion_r656437615
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointOptions.java
##########
@@ -47,7 +48,8 @@
FORCED_ALIGNED
}
- public static final long NO_ALIGNMENT_TIME_OUT = Long.MAX_VALUE;
+ /** The maximum possible value is Long.MAX_VALUE 'ns' but API receives 'ms'. */
+ public static final long NO_ALIGNMENT_TIME_OUT = Duration.ofNanos(Long.MAX_VALUE).toMillis();
Review comment:
good point. I made such a fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #16135:
URL: https://github.com/apache/flink/pull/16135#discussion_r656315138
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/SingleCheckpointBarrierHandler.java
##########
@@ -299,18 +294,23 @@ private void registerAlignmentTimer(CheckpointBarrier announcedBarrier) {
announcedBarrier.getCheckpointOptions().getAlignmentTimeout()));
}
- private boolean checkNewCheckpoint(CheckpointBarrier barrier) throws IOException {
+ private void checkNewCheckpoint(CheckpointBarrier barrier) throws IOException {
long barrierId = barrier.getId();
- if (currentCheckpointId < barrierId) {
- if (isCheckpointPending()) {
- cancelSubsumedCheckpoint(barrierId);
- }
- currentCheckpointId = barrierId;
- numBarriersReceived = 0;
- allBarriersReceivedFuture = new CompletableFuture<>();
- return true;
+ if (currentCheckpointId >= barrierId) {
Review comment:
Nice refactoring! I like returning early.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #16135:
URL: https://github.com/apache/flink/pull/16135#discussion_r656312977
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointOptions.java
##########
@@ -47,7 +48,8 @@
FORCED_ALIGNED
}
- public static final long NO_ALIGNMENT_TIME_OUT = Long.MAX_VALUE;
+ /** The maximum possible value is Long.MAX_VALUE 'ns' but API receives 'ms'. */
+ public static final long NO_ALIGNMENT_TIME_OUT = Duration.ofNanos(Long.MAX_VALUE).toMillis();
Review comment:
What is the problem with the old value? After all, it's just a marker value. It does not have any true meaning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16135: [FLINK-22961][streaming] firstBarrierArrivalTime is recalculated when…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16135:
URL: https://github.com/apache/flink/pull/16135#issuecomment-858597022
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878",
"triggerID" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"triggerType" : "PUSH"
}, {
"hash" : "d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893",
"triggerID" : "859003490",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d645c3c4c3a0d102bf6bbff8c4a77c6e9b7f22ff Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18878) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18893)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org