You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/12/15 03:00:12 UTC
[GitHub] [incubator-mxnet] ChaiBapchya opened a new issue #19673: PR Status Labeler Bot doesn't get triggered by reviews
ChaiBapchya opened a new issue #19673:
URL: https://github.com/apache/incubator-mxnet/issues/19673
## Description
some PRs get pr-awaiting-merge label when CI passes and it already has an approval, but others dont when the approval comes after the CI has already completed.
https://github.com/apache/incubator-mxnet/pull/19669
@samskalicky Thanks for reporting
### Error Message
NA
### Steps to reproduce
1.Review a PR after CI has passed.
## What have you tried to solve it?
1. Manually label the PR using label-bot
## Environment
NA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #19673: PR Status Labeler Bot doesn't get triggered by reviews
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #19673:
URL: https://github.com/apache/incubator-mxnet/issues/19673#issuecomment-745496048
Ticket created: https://issues.apache.org/jira/browse/INFRA-21193
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #19673: PR Status Labeler Bot doesn't get triggered by reviews
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #19673:
URL: https://github.com/apache/incubator-mxnet/issues/19673#issuecomment-745020200
@mxnet-label-bot update [bug]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #19673: PR Status Labeler Bot doesn't get triggered by reviews
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #19673:
URL: https://github.com/apache/incubator-mxnet/issues/19673#issuecomment-745023224
Cause of issue: Currently, Github webhook only sends events related to "Status"
https://issues.apache.org/jira/browse/INFRA-20624
What does Status event cover?
```
Commit status updated from the API
```
Basically, any change that happens to the commit status [CI running/success/failure]
However, PR review event is not part of Statuses event.
Next Steps
- Create a request for updating github webhook for PR Status Label to send events related to PR Review
There are 3 options
1. Pull request reviews
```
Pull request review submitted, edited, or dismissed.
```
2. Pull request review comments
```
Pull request diff comment created, edited, or deleted.
```
3. Pull requests
```
Pull request opened, closed, reopened, edited, assigned, unassigned, review requested, review request removed, labeled, unlabeled, synchronized, ready for review, converted to draft, locked, or unlocked.
```
Out of the 3, 1st one is the most applicable. It's necessary & sufficient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org