You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/19 22:40:54 UTC

[GitHub] [airflow] uranusjr commented on issue #17012: NONE_FAILED_OR_SKIPPED and NONE_FAILED do the same

uranusjr commented on issue #17012:
URL: https://github.com/apache/airflow/issues/17012#issuecomment-882907844


   I `git blame`-ed this and `NONE_FAILED_OR_SKIPPED` was added in #7464. `NONE_FAILED_OR_SKIPPED` is intentionally implemented to be almost exactly the same as `NONE_FAILED`, but sets the state of the *current* task differently.
   
   https://github.com/apache/airflow/blob/16c55f100374df8cb17a85d06396aa42785fed0e/airflow/ti_deps/deps/trigger_rule_dep.py#L128-L156
   
   Assuming no upstream fails…
   
   * `ALL_SUCCESS` skips the current task if at least one upstream is skipped.
   * `NONE_FAILED` does nothing (continues the current task).
   * `NONE_FAILED_OR_SKIPPED` skips the current task only if *all* upstream tasks are skipped, otherwise continues.
   
   So I don’t think we can afford to change anything.
   
   cc @yuqian90 maybe you could recall some of the context here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org