[GitHub] [shardingsphere] azexcy commented on a diff in pull request #20967: Refactor : refactor the IT to support customized proxy test image.

[GitBox <gi...@apache.org>]

azexcy commented on code in PR #20967:
URL: https://github.com/apache/shardingsphere/pull/20967#discussion_r972841922


##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/java/org/apache/shardingsphere/integration/data/pipeline/framework/container/compose/DockerContainerComposer.java:
##########
@@ -65,7 +65,7 @@ public DockerContainerComposer(final DatabaseType databaseType, final String sto
             storageContainerConfig = StorageContainerConfigurationFactory.newInstance(databaseType);
         }
         storageContainer = getContainers().registerContainer((DockerStorageContainer) StorageContainerFactory.newInstance(databaseType, storageContainerImage,
-                "", storageContainerConfig));
+                "", StorageContainerConfigurationFactory.newInstance(databaseType)));

Review Comment:
   create mysql 8 container will volumn another `my.cnf`, relation code is at 61~64 line at this file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org