You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/09/28 02:47:33 UTC

[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1774: [IOTDB-920] Disable insert row thats only contains time/timestamp column

mychaow commented on a change in pull request #1774:
URL: https://github.com/apache/incubator-iotdb/pull/1774#discussion_r495662971



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
##########
@@ -145,9 +145,13 @@
 import org.apache.iotdb.tsfile.utils.Pair;
 import org.apache.iotdb.tsfile.write.schema.MeasurementSchema;
 import org.apache.iotdb.tsfile.write.writer.RestorableTsFileIOWriter;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class PlanExecutor implements IPlanExecutor {
 
+  private static final Logger LOG = LoggerFactory.getLogger(PlanExecutor.class);

Review comment:
       We usually use logger, maybe you could rename it.

##########
File path: server/src/test/java/org/apache/iotdb/db/integration/IOTDBInsertIT.java
##########
@@ -0,0 +1,104 @@
+package org.apache.iotdb.db.integration;

Review comment:
       add license.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org