You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/11/02 20:34:17 UTC
Re: Review Request 39827: Made slave version required in master.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39827/
-----------------------------------------------------------
(Updated Nov. 2, 2015, 7:34 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
fixed constness. NNFR.
Repository: mesos
Description
-------
Slave version is being set by the slave since 0.21.0. Cleaned up the code in master that expected it to be optional.
Diffs (updated)
-----
src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac
src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5
Diff: https://reviews.apache.org/r/39827/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 39827: Made slave version required in master.cpp.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39827/
-----------------------------------------------------------
(Updated Nov. 5, 2015, 6:03 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
minor fix for slave version not being constant anymore.
Repository: mesos
Description
-------
Slave version is being set by the slave since 0.21.0. Cleaned up the code in master that expected it to be optional.
Diffs (updated)
-----
src/master/http.cpp 9d20346460b4f9659aacba3fcb950ab564ba9d0d
src/master/master.hpp b19f23be135d191ce119cf87fd25c4d6746faed3
src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965
Diff: https://reviews.apache.org/r/39827/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 39827: Made slave version required in master.cpp.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39827/
-----------------------------------------------------------
(Updated Nov. 5, 2015, 3:38 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased. NNFR.
Repository: mesos
Description
-------
Slave version is being set by the slave since 0.21.0. Cleaned up the code in master that expected it to be optional.
Diffs (updated)
-----
src/master/master.hpp b19f23be135d191ce119cf87fd25c4d6746faed3
src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965
Diff: https://reviews.apache.org/r/39827/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 39827: Made slave version required in master.cpp.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39827/#review104867
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 十一月 2, 2015, 7:34 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39827/
> -----------------------------------------------------------
>
> (Updated 十一月 2, 2015, 7:34 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Slave version is being set by the slave since 0.21.0. Cleaned up the code in master that expected it to be optional.
>
>
> Diffs
> -----
>
> src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac
> src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5
>
> Diff: https://reviews.apache.org/r/39827/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>