You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/20 09:51:33 UTC
[GitHub] [spark] viirya opened a new pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
viirya opened a new pull request #34959:
URL: https://github.com/apache/spark/pull/34959
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This is a followup of SPARK-6305. Some places in build files (maven and sbt) which remove log4j properties files should be updated. Some tests programmingly write log4j properties should be updated to log4j 2 syntax too.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To clean up build files and migrate some tests to log4j2 syntax.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Pass all tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998572374
I will try to reproduce it locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34959:
URL: https://github.com/apache/spark/pull/34959#discussion_r772946915
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
##########
@@ -1220,11 +1220,13 @@ abstract class HiveThriftServer2TestBase extends SparkFunSuite with BeforeAndAft
val tempLog4jConf = Utils.createTempDir().getCanonicalPath
Files.write(
- """log4j.rootCategory=INFO, console
- |log4j.appender.console=org.apache.log4j.ConsoleAppender
- |log4j.appender.console.target=System.err
- |log4j.appender.console.layout=org.apache.log4j.PatternLayout
- |log4j.appender.console.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss} %p %c{1}: %m%n
+ """rootLogger.level = info
+ |rootLogger.appenderRef.file.ref = console
+ |appender.console.type = Console
+ |appender.console.name = console
+ |appender.console.target = SYSTEM_ERR
+ |appender.console.layout.type = PatternLayout
+ |appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} %p %c{1}: %m%n
""".stripMargin,
new File(s"$tempLog4jConf/log4j.properties"),
Review comment:
new File(s"$tempLog4jConf/log4j.properties") -> new File(s"$tempLog4jConf/log4j2.properties")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34959:
URL: https://github.com/apache/spark/pull/34959#discussion_r772964014
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
##########
@@ -1220,11 +1220,13 @@ abstract class HiveThriftServer2TestBase extends SparkFunSuite with BeforeAndAft
val tempLog4jConf = Utils.createTempDir().getCanonicalPath
Files.write(
- """log4j.rootCategory=INFO, console
- |log4j.appender.console=org.apache.log4j.ConsoleAppender
- |log4j.appender.console.target=System.err
- |log4j.appender.console.layout=org.apache.log4j.PatternLayout
- |log4j.appender.console.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss} %p %c{1}: %m%n
+ """rootLogger.level = info
+ |rootLogger.appenderRef.file.ref = console
+ |appender.console.type = Console
+ |appender.console.name = console
+ |appender.console.target = SYSTEM_ERR
+ |appender.console.layout.type = PatternLayout
+ |appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} %p %c{1}: %m%n
""".stripMargin,
new File(s"$tempLog4jConf/log4j.properties"),
Review comment:
I corrected this together in #34965.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-997889573
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146396/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-997767287
**[Test build #146396 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146396/testReport)** for PR 34959 at commit [`14a9d84`](https://github.com/apache/spark/commit/14a9d844e56afddeadf4d40fdf8f43c9fa3288fc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-997848446
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50871/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998579015
> Do you see other issues? Seems other tests are all passed on maven, right?
It seems so, only `hive-thriftserver` module test fail now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998178440
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50877/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998320428
**[Test build #146406 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146406/testReport)** for PR 34959 at commit [`6ae05e1`](https://github.com/apache/spark/commit/6ae05e190a283f100b22346a7248c9c272aa3fef).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998285163
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50881/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-997767287
**[Test build #146396 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146396/testReport)** for PR 34959 at commit [`14a9d84`](https://github.com/apache/spark/commit/14a9d844e56afddeadf4d40fdf8f43c9fa3288fc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998573766
> The log4j error I have seen locally, but it doesn't affect SBT test. Not sure if it is related.
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34959:
URL: https://github.com/apache/spark/pull/34959#discussion_r772957327
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
##########
@@ -1220,11 +1220,13 @@ abstract class HiveThriftServer2TestBase extends SparkFunSuite with BeforeAndAft
val tempLog4jConf = Utils.createTempDir().getCanonicalPath
Files.write(
- """log4j.rootCategory=INFO, console
- |log4j.appender.console=org.apache.log4j.ConsoleAppender
- |log4j.appender.console.target=System.err
- |log4j.appender.console.layout=org.apache.log4j.PatternLayout
- |log4j.appender.console.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss} %p %c{1}: %m%n
+ """rootLogger.level = info
+ |rootLogger.appenderRef.file.ref = console
+ |appender.console.type = Console
+ |appender.console.name = console
+ |appender.console.target = SYSTEM_ERR
+ |appender.console.layout.type = PatternLayout
+ |appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} %p %c{1}: %m%n
""".stripMargin,
new File(s"$tempLog4jConf/log4j.properties"),
Review comment:
SBT cannot reproduce it. But we should use `log4j2.properties`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998291309
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50881/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998139429
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50877/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998218698
**[Test build #146406 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146406/testReport)** for PR 34959 at commit [`6ae05e1`](https://github.com/apache/spark/commit/6ae05e190a283f100b22346a7248c9c272aa3fef).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998558288
@viirya It seems that test failure still exists in `hive-thriftserver` module:
https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-maven-hadoop-3.2/3527/consoleFull
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya edited a comment on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998564320
Which one you mean? I don't see failed test in test results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998177315
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50877/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998575025
Do you see other issues? Seems other tests are all passed on maven, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998201787
I think there is a related error in the kubernetes integration tests:
```
<testcase
name="Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j.properties" classname="org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite" time="204.286">
<failure
message="The code passed to eventually never returned normally. Attempted 180 times over 3.000611025833334 minutes. Last failure message: "++ id -u&#010;+ myuid=185&#010;++ id -g&#010;+ mygid=0&#01
0;+ set +e&#010;++ getent passwd 185&#010;+ uidentry=&#010;+ set -e&#010;+ '[' -z '' ']'&#010;+ ...
```
It is around here:
https://github.com/apache/spark/blob/14a9d844e56afddeadf4d40fdf8f43c9fa3288fc/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SparkConfPropagateSuite.scala#L30-L45
Switching on DEBUG for log4j initialization does not trigger the logging of the expected output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998178440
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50877/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-997845870
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50871/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998291309
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50881/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34959:
URL: https://github.com/apache/spark/pull/34959#discussion_r772953492
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
##########
@@ -1220,11 +1220,13 @@ abstract class HiveThriftServer2TestBase extends SparkFunSuite with BeforeAndAft
val tempLog4jConf = Utils.createTempDir().getCanonicalPath
Files.write(
- """log4j.rootCategory=INFO, console
- |log4j.appender.console=org.apache.log4j.ConsoleAppender
- |log4j.appender.console.target=System.err
- |log4j.appender.console.layout=org.apache.log4j.PatternLayout
- |log4j.appender.console.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss} %p %c{1}: %m%n
+ """rootLogger.level = info
+ |rootLogger.appenderRef.file.ref = console
+ |appender.console.type = Console
+ |appender.console.name = console
+ |appender.console.target = SYSTEM_ERR
+ |appender.console.layout.type = PatternLayout
+ |appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} %p %c{1}: %m%n
""".stripMargin,
new File(s"$tempLog4jConf/log4j.properties"),
Review comment:
However, it seems that all logs are printed to the console, which is different from the previous behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998109264
Thanks @dongjoon-hyun . Wait for CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998139085
**[Test build #146402 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146402/testReport)** for PR 34959 at commit [`cec77a4`](https://github.com/apache/spark/commit/cec77a49cb92d2c71b31d46c92aca2ac30676580).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998272136
Hmm, I changed the log4j properties file for the k8s integration test. But seems the test still cannot get the log4j 2 configuration file. Not sure why now. I will merge this first and keep looking at the k8s integration test issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998324276
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146406/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998218698
**[Test build #146406 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146406/testReport)** for PR 34959 at commit [`6ae05e1`](https://github.com/apache/spark/commit/6ae05e190a283f100b22346a7248c9c272aa3fef).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998322712
Jenkins tests were passed. Thanks for reviewing. Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-997805502
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50871/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-997867025
**[Test build #146396 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146396/testReport)** for PR 34959 at commit [`14a9d84`](https://github.com/apache/spark/commit/14a9d844e56afddeadf4d40fdf8f43c9fa3288fc).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998254674
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146402/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998250436
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50881/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998572656
And there are some error log as follows:
```
Discovery starting.
2021-12-20 22:41:21,477 ScalaTest-main ERROR Filters contains invalid attributes "onMatch", "onMismatch"
2021-12-20 22:41:21,492 ScalaTest-main ERROR Filters contains invalid attributes "onMatch", "onMismatch"
Discovery completed in 1 second, 557 milliseconds.
Run starting. Expected test count is: 551
```
It seems that there is some thing wrong with log4j2 configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34959:
URL: https://github.com/apache/spark/pull/34959#discussion_r772946915
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
##########
@@ -1220,11 +1220,13 @@ abstract class HiveThriftServer2TestBase extends SparkFunSuite with BeforeAndAft
val tempLog4jConf = Utils.createTempDir().getCanonicalPath
Files.write(
- """log4j.rootCategory=INFO, console
- |log4j.appender.console=org.apache.log4j.ConsoleAppender
- |log4j.appender.console.target=System.err
- |log4j.appender.console.layout=org.apache.log4j.PatternLayout
- |log4j.appender.console.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss} %p %c{1}: %m%n
+ """rootLogger.level = info
+ |rootLogger.appenderRef.file.ref = console
+ |appender.console.type = Console
+ |appender.console.name = console
+ |appender.console.target = SYSTEM_ERR
+ |appender.console.layout.type = PatternLayout
+ |appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} %p %c{1}: %m%n
""".stripMargin,
new File(s"$tempLog4jConf/log4j.properties"),
Review comment:
change `new File(s"$tempLog4jConf/log4j.properties")` to `new File(s"$tempLog4jConf/log4j2.properties")`, then `HiveThriftBinaryServerSuite` no longer hang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998324276
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146406/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #34959:
URL: https://github.com/apache/spark/pull/34959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998250739
**[Test build #146402 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146402/testReport)** for PR 34959 at commit [`cec77a4`](https://github.com/apache/spark/commit/cec77a49cb92d2c71b31d46c92aca2ac30676580).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998139085
**[Test build #146402 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146402/testReport)** for PR 34959 at commit [`cec77a4`](https://github.com/apache/spark/commit/cec77a49cb92d2c71b31d46c92aca2ac30676580).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998254674
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146402/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998564320
Which one you mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-997848446
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50871/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-997889573
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146396/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998570135
```
=========================================
End HiveThriftServer2Suite failure output
=========================================
22:53:44.821 INFO org.apache.spark.sql.hive.thriftserver.HiveThriftBinaryServerSuite: HiveThriftServer2 stopped
22:53:44.827 WARN org.apache.spark.sql.hive.thriftserver.HiveThriftBinaryServerSuite:
===== POSSIBLE THREAD LEAK IN SUITE o.a.s.sql.hive.thriftserver.HiveThriftBinaryServerSuite, threads: Thread-13 (daemon=true), Thread-12 (daemon=true) =====
*** RUN ABORTED ***
java.util.concurrent.TimeoutException: Futures timed out after [3 minutes]
at scala.concurrent.impl.Promise$DefaultPromise.ready(Promise.scala:259)
at scala.concurrent.impl.Promise$DefaultPromise.result(Promise.scala:263)
at org.apache.spark.util.ThreadUtils$.awaitResult(ThreadUtils.scala:293)
at org.apache.spark.sql.hive.thriftserver.HiveThriftServer2TestBase.startThriftServer(HiveThriftServer2Suites.scala:1344)
at org.apache.spark.sql.hive.thriftserver.HiveThriftServer2TestBase.$anonfun$beforeAll$4(HiveThriftServer2Suites.scala:1397)
at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
at scala.util.Try$.apply(Try.scala:213)
at org.apache.spark.sql.hive.thriftserver.HiveThriftServer2TestBase.$anonfun$beforeAll$3(HiveThriftServer2Suites.scala:1396)
at scala.util.Failure.orElse(Try.scala:224)
at org.apache.spark.sql.hive.thriftserver.HiveThriftServer2TestBase.$anonfun$beforeAll$2(HiveThriftServer2Suites.scala:1394)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #34959: [SPARK-6305][BUILD][FOLLOWUP] Some cleanups for log4j properties
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34959:
URL: https://github.com/apache/spark/pull/34959#issuecomment-998573543
The log4j error I have seen locally, but it doesn't affect SBT test. Not sure if it is related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org