[Bug 7878] New: SHORT_SHORTNER hits mails with bodies larger than 512 bytes

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7878

            Bug ID: 7878
           Summary: SHORT_SHORTNER hits mails with bodies larger than 512
                    bytes
           Product: Spamassassin
           Version: 3.4.4
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Rules
          Assignee: dev@spamassassin.apache.org
          Reporter: dam@one.com
  Target Milestone: Undefined

Created attachment 5735
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5735&action=edit
1024+ byte body and youtu.be link

Since 2021-01-05 the amount of mails hitting SHORT_SHORTNER has increased with
more than 2000%...

Some testing shows me that
1: It hits mails with body larger than 512 bytes
2: youtu.be is considered an url shortener

As far as I can tell the __PDS_MSG_512 meta rule that SHORT_SHORTNER is based
on should only trigger for bodies smaller than 512B, should it not?

I can't say I really agree with the classification of youtu.be as a
urlshortener either, but that's not the main problem here, the body size is. As
far as I know youtu.be can only be used for links to youtube videos and is not
a all purpose shortener.

Including example mail trigger the rule. It has 1024 bytes of lorem ipsum in
body, and a youtu.be link

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7878] SHORT_SHORTNER hits mails with bodies larger than 512 bytes

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7878

RW <rw...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rwmaillists@googlemail.com

--- Comment #2 from RW <rw...@googlemail.com> ---

I think that:

   rawbody __MIME_QPC          
eval:check_for_mime('mime_quoted-printable_count')

should be

   rawbody __MIME_QPC           eval:check_for_mime('mime_qp_count')

The former is presumably giving __MIME_QPC a value of 0.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7878] SHORT_SHORTNER hits mails with bodies larger than 512 bytes

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7878

Steadramon <pa...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |paul.stead@gmail.com
         Resolution|---                         |FIXED

--- Comment #1 from Steadramon <pa...@gmail.com> ---
The 512 byte issue was introduced by a quoted-printable count addition, which
wasn't counting properly.

The erroneous counting was removed in
https://svn.apache.org/viewvc?view=revision&revision=1885113

I have dropped youtu.be from the URI shorteners list - I'd agree this is a
special type of shortener and shouldn't be included.

Sending        20_urlshort.cf
Transmitting file data .done
Committing transaction...
Committed revision 1885193.

-- 
You are receiving this mail because:
You are the assignee for the bug.