[jira] [Commented] (WICKET-6970) Unnecessary string building in AssociatedMarkupSourcingStrategy

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520424#comment-17520424 ] 

ASF subversion and git services commented on WICKET-6970:
---------------------------------------------------------

Commit 2a6ae40b023bc828a3c5a0d9b480040d6eab6e0e in wicket's branch refs/heads/master from Emond Papegaaij
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=2a6ae40b02 ]

WICKET-6970: do not build error message for every render for every panel


> Unnecessary string building in AssociatedMarkupSourcingStrategy
> ---------------------------------------------------------------
>
>                 Key: WICKET-6970
>                 URL: https://issues.apache.org/jira/browse/WICKET-6970
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 10.0.0, 9.9.0
>            Reporter: Emond Papegaaij
>            Assignee: Emond Papegaaij
>            Priority: Major
>
> {{AssociatedMarkupSourcingStrategy.renderAssociatedMarkup}} builds a string just for an exception message. The method {{MarkupContainer.renderAssociatedMarkup}} is only called from this single location and is not really meant for public consumption. I suggest we inline the message and only build it when it's actually needed. For 9.x we must keep the parameter, but we can call it with {{null.}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)