[GitHub] [incubator-mxnet] ptrendx opened a new pull request #14377: Correct update count with Gluon trainer and update_on_kvstore=False

[GitBox <gi...@apache.org>]

ptrendx opened a new pull request #14377: Correct update count with Gluon trainer and update_on_kvstore=False
URL: https://github.com/apache/incubator-mxnet/pull/14377
 
 
   ## Description ##
   This PR fixes the update count when Gluon trainer is created with multiple devices and `update_on_kvstore=False`.
   Fixes #13752, fixes #12713
   
   @eric-haibin-lin This slightly hacky but should work for all cases. Thoughts?
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ## Comments ##
   - The real fix here should be moving the _index_update_count to Updater (which is per device) from optimizer (which is common to all updaters), but that would require breaking API change. FYI @szha 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services