[GitHub] jmcarp commented on issue #4401: [AIRFLOW-3596] Clean up undefined template variables.

[GitBox <gi...@apache.org>]

jmcarp commented on issue #4401: [AIRFLOW-3596] Clean up undefined template variables.
URL: https://github.com/apache/airflow/pull/4401#issuecomment-452392057
 
 
   @feng-tao: I configured jinja to raise exceptions for undefined template variables using `jinja2.StrictUndefined` and ran view tests to find templates with undefined variables. Then I either passed those undefined variables to the templates if they appeared to be used, deleted them from templates if no views *ever* passed those variables, or explicitly tested that the variables were defined using the `is defined` check in jinja2.
   
   Once https://github.com/dpgaspar/Flask-AppBuilder/pull/883 is merged, we should be able to set `StrictUndefined` and avoid undefined template variables in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services