You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nemo.apache.org by wo...@apache.org on 2022/11/14 09:25:41 UTC
[incubator-nemo] branch master updated: [MINOR] Fix apache-related issues with GitHub actions (#343) (#343)
This is an automated email from the ASF dual-hosted git repository.
wonook pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nemo.git
The following commit(s) were added to refs/heads/master by this push:
new 8f5a3d14f [MINOR] Fix apache-related issues with GitHub actions (#343) (#343)
8f5a3d14f is described below
commit 8f5a3d14f714989c77c2dc06cdb1debd263e8cc8
Author: Won Wook SONG <wo...@apache.org>
AuthorDate: Mon Nov 14 18:25:34 2022 +0900
[MINOR] Fix apache-related issues with GitHub actions (#343) (#343)
**Major changes:**
- Removes unallowed actions from the maven workflow
- Updates the sonarcloud token variable to meet the name provided by apache software foundation
**Minor changes to note:**
- None
**Tests for the changes:**
- Existing tests
**Other comments:**
- None
Closes #343
---
.asf.yaml | 4 ++--
.github/workflows/maven.yml | 5 ++---
.github/workflows/sonarcloud.yml | 18 +++++++++---------
3 files changed, 13 insertions(+), 14 deletions(-)
diff --git a/.asf.yaml b/.asf.yaml
index 4a34ba4b2..bb6197c85 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -26,8 +26,8 @@ github:
strict: true
# contexts are the names of checks that must pass
contexts:
- - workflows/maven
- - workflows/node.js
+ - Java CI with Maven / Build on Java 11 and ubuntu-18.04 (pull_request)
+ - Node.js CI / build (16.x, ubuntu-18.04) (pull_request)
required_pull_request_reviews:
dismiss_stale_reviews: true
diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index 226d9058b..ec26922c4 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -54,6 +54,5 @@ jobs:
run: mvn -B verify --file pom.xml -q -ff -Dsurefire.useFile=false -Dorg.slf4j.simpleLogger.defaultLogLevel=info
# Optional: Uploads the full dependency graph to GitHub to improve the quality of Dependabot alerts this repository can receive
- - name: Update dependency graph
- uses: advanced-security/maven-dependency-submission-action@571e99aab1055c2e71a1e2309b9691de18d6b7d6
-
+# - name: Update dependency graph
+# uses: advanced-security/maven-dependency-submission-action@571e99aab1055c2e71a1e2309b9691de18d6b7d6
diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml
index 17ac42122..93a9c2445 100644
--- a/.github/workflows/sonarcloud.yml
+++ b/.github/workflows/sonarcloud.yml
@@ -21,7 +21,7 @@
# separate terms of service, privacy policy, and support
# documentation.
-# This workflow helps you trigger a SonarCloud analysis of your code and populates
+# This workflow helps you trigger a SonarCloud analysis of your code and populates
# GitHub Code Scanning alerts with the vulnerabilities found.
# Free for open source project.
@@ -29,16 +29,16 @@
#
# 2. Import your project on SonarCloud
# * Add your GitHub organization first, then add your repository as a new project.
-# * Please note that many languages are eligible for automatic analysis,
+# * Please note that many languages are eligible for automatic analysis,
# which means that the analysis will start automatically without the need to set up GitHub Actions.
# * This behavior can be changed in Administration > Analysis Method.
-#
+#
# 3. Follow the SonarCloud in-product tutorial
# * a. Copy/paste the Project Key and the Organization Key into the args parameter below
# (You'll find this information in SonarCloud. Click on "Information" at the bottom left)
#
# * b. Generate a new token and add it to your Github repository's secrets using the name SONAR_TOKEN
-# (On SonarCloud, click on your avatar on top-right > My account > Security
+# (On SonarCloud, click on your avatar on top-right > My account > Security
# or go directly to https://sonarcloud.io/account/security/)
# Feel free to take a look at our documentation (https://docs.sonarcloud.io/getting-started/github/)
@@ -59,18 +59,18 @@ permissions:
jobs:
Analysis:
runs-on: ubuntu-latest
-
+
steps:
- - name: Analyze with SonarCloud
+ - name: Analyze with SonarCloud
# You can pin the exact commit or the version.
uses: SonarSource/sonarcloud-github-action@de2e56b42aa84d0b1c5b622644ac17e505c9a049
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information
- SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} # Generate a token on Sonarcloud.io, add it to the secrets of this repo with the name SONAR_TOKEN (Settings > Secrets > Actions > add new repository secret)
+ SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }} # Generate a token on Sonarcloud.io, add it to the secrets of this repo with the name SONAR_TOKEN (Settings > Secrets > Actions > add new repository secret)
with:
# Additional arguments for the sonarcloud scanner
- args:
+ args:
# Unique keys of your project and organization. You can find them in SonarCloud > Information (bottom-left menu)
# mandatory
-Dsonar.projectKey=org.apache.nemo:nemo-project
@@ -82,4 +82,4 @@ jobs:
# Comma-separated paths to directories containing test source files.
# -Dsonar.tests= # optional. For more info about Code Coverage, please refer to https://docs.sonarcloud.io/enriching/test-coverage/overview/
# Adds more detail to both client and server-side analysis logs, activating DEBUG mode for the scanner, and adding client-side environment variables and system properties to the server-side log of analysis report processing.
- # -Dsonar.verbose= # optional, default is false
+ # -Dsonar.verbose= # optional, default is false