[GitHub] [spark] HeartSaVioR commented on issue #24014: [SPARK-27092][SQL] Apply refactored pattern in ScalaReflection and JavaTypeInference to RowEncoder

[GitBox <gi...@apache.org>]

HeartSaVioR commented on issue #24014: [SPARK-27092][SQL] Apply refactored pattern in ScalaReflection and JavaTypeInference to RowEncoder
URL: https://github.com/apache/spark/pull/24014#issuecomment-471527793
 
 
   While I'm adding new methods to `SerializerBuildHelper` / `DeserializerBuildHelper`, I've also found some parts which are exactly doing same things for what `JavaTypeInference` and `ScalaReflection` are doing. e.g. `createDeserializerForJavaBigDecimal`, `createDeserializerForString`, `createSerializerForDecimalType`, etc. 
   
   So for some parts they're doing different, but some other parts they're just doing same. I can remove added methods and just let RowEncoder reuse available methods in `SerializerBuildHelper` / `DeserializerBuildHelper` if we are not seeing benefit of doing it. Please let me know your thought about it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org